All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: kbuild-all@lists.01.org,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
	linux-kernel@vger.kernel.org,
	Amit Pundir <amit.pundir@linaro.org>
Subject: [RFC PATCH ammarfaizi2-block] ANDROID: net: paranoid: commoncap: __cap_capable() can be static
Date: Thu, 3 Mar 2022 14:12:36 +0800	[thread overview]
Message-ID: <20220303061236.GA70904@6305ff5a442d> (raw)
In-Reply-To: <202203031440.TcuCrT9t-lkp@intel.com>

security/commoncap.c:75:5: warning: symbol '__cap_capable' was not declared. Should it be static?

Fixes: 2b02b4ab89b9 ("ANDROID: net: paranoid: commoncap: Begin to warn users of implicit PARANOID_NETWORK capability grants")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 security/commoncap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/commoncap.c b/security/commoncap.c
index 2ed79a834a965..f38709ba26317 100644
--- a/security/commoncap.c
+++ b/security/commoncap.c
@@ -72,7 +72,7 @@ static void warn_setuid_and_fcaps_mixed(const char *fname)
  * cap_has_capability() returns 0 when a task has a capability, but the
  * kernel's capable() and has_capability() returns 1 for this case.
  */
-int __cap_capable(const struct cred *cred, struct user_namespace *targ_ns,
+static int __cap_capable(const struct cred *cred, struct user_namespace *targ_ns,
 		int cap, int audit)
 {
 	struct user_namespace *ns = targ_ns;

      reply	other threads:[~2022-03-03  6:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03  6:15 [ammarfaizi2-block:google/android/kernel/common/deprecated/android-4.14-p-release 137/6167] security/commoncap.c:75:5: sparse: sparse: symbol '__cap_capable' was not declared. Should it be static? kernel test robot
2022-03-03  6:12 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220303061236.GA70904@6305ff5a442d \
    --to=lkp@intel.com \
    --cc=amit.pundir@linaro.org \
    --cc=gwml@vger.gnuweeb.org \
    --cc=john.stultz@linaro.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.