Re: [PATCH] arm: Add AM335x based CBC board

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2185 bytes --]

On Thu, Mar 03, 2022 at 03:48:46PM +0100, Lukasz Majewski wrote:
> Hi Tom,
> 
> > On Thu, Mar 03, 2022 at 03:07:47PM +0100, Lukasz Majewski wrote:
> > > Hi Tom,
> > >   
> > > > On Thu, Mar 03, 2022 at 10:27:10AM +0100, Lukasz Majewski wrote:  
> > > > > Hi Tom,
> > > > >     
> > > > > > This commit adds CBC board to U-Boot.
> > > > > > 
> > > > > > U-Boot 2022.04-rc1-00271-g930634a4c9 (Feb 21 2022 - 15:08:13
> > > > > > +0100)
> > > > > > 
> > > > > > CPU  : AM335X-GP rev 2.1
> > > > > > Model: AM335x Bosch CBC
> > > > > > DRAM:  512 MiB
> > > > > > Core:  198 devices, 14 uclasses, devicetree: separate
> > > > > > MMC:   OMAP SD/MMC: 2, OMAP SD/MMC: 0, OMAP SD/MMC: 1
> > > > > > Loading Environment from MMC... OK
> > > > > > Boot Device is eMMC
> > > > > > CBC Variant found: BCT531
> > > > > > Net:   eth2: ethernet@4a100000
> > > > > > Hit any key to stop autoboot:  0
> > > > > > 
> > > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > > > 
> > > > > > ---
> > > > > > 
> > > > > >  arch/arm/Kconfig                    |   1 +
> > > > > >  arch/arm/dts/Makefile               |   1 +
> > > > > >  arch/arm/dts/am335x-cbc-u-boot.dtsi |  18 ++
> > > > > >  arch/arm/dts/am335x-cbc.dts         | 309
> > > > > > ++++++++++++++++++++ arch/arm/dts/am335x-cbc.dtsi        |
> > > > > > 136 +++++++++    
> > > > 
> > > > Is this dts upstream?
> > > >   
> > > 
> > > No, not yet. This is the smallest required DTS for this board (and
> > > hence it is a subset of the full blown Linux kernel DTS).
> > > 
> > > (Shall it be first accepted to the Linux kernel?)  
> > 
> > Everything that's not -u-boot.dtsi stuff needs to be at least in
> > linux-next first, yes.  For all SoCs, not just am33xx.
> > 
> 
> But then I do have a question - what if I don't need the whole DTS
> accepted to Linux?
> 
> Would it be OK, to provide just a subset (to save space)?

If it's something that belongs to a U-Boot binding we haven't
upstreamed, it goes in -u-boot.dtsi.  Otherwise it goes in the full DTS
which gets upstreamed, even if the kernel doesn't use it, since that's
where DTS files live currently.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]