All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Clément Léger" <clement.leger@bootlin.com>
To: <Eugen.Hristev@microchip.com>
Cc: <Ludovic.Desroches@microchip.com>, <u-boot@lists.denx.de>,
	<Nicolas.Ferre@microchip.com>, <thomas.petazzoni@bootlin.com>,
	<Claudiu.Beznea@microchip.com>
Subject: Re: [PATCH v3 2/3] ARM: dts: at91: sama5d2: add TCB node
Date: Fri, 4 Mar 2022 10:35:52 +0100	[thread overview]
Message-ID: <20220304103552.05abd65d@fixe.home> (raw)
In-Reply-To: <01e61ac7-0ab3-ab42-5bd4-e8f847299cbe@microchip.com>

Le Fri, 4 Mar 2022 09:32:16 +0000,
<Eugen.Hristev@microchip.com> a écrit :

> On 3/4/22 11:12 AM, Clément Léger wrote:
> 
> > Add the device-tree node to describe the TCB timer.
> > 
> > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> > ---
> >   arch/arm/dts/sama5d2.dtsi | 16 ++++++++++++++++
> >   1 file changed, 16 insertions(+)
> > 
> > diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
> > index 038cd73c03..63588b27b8 100644
> > --- a/arch/arm/dts/sama5d2.dtsi
> > +++ b/arch/arm/dts/sama5d2.dtsi
> > @@ -700,6 +700,22 @@
> >                                  clocks = <&h32ck>;
> >                          };
> > 
> > +                       tcb0: timer@f800c000 {
> > +                               compatible = "atmel,sama5d2-tcb", "simple-mfd",
> > +                                            "syscon";
> > +                               reg = <0xf800c000 0x100>;
> > +
> > +                               clocks = <&tcb0_clk>, <&tcb0_gclk>, <&clk32k>;
> > +                               clock-names = "t0_clk", "gclk", "slow_clk";
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +
> > +                               timer0: timer@0 {
> > +                                       compatible = "atmel,tcb-timer";
> > +                                       reg = <0>, <1>;
> > +                               };
> > +                       };  
> 
> Hello Clement,
> 
> As discussed in v2, interrupts property is mandatory.

Args, I added syscon but forgot interrupts... Will resubmit then

> 
> 
> Eugen
> > +
> >                          watchdog@f8048040 {
> >                                  compatible = "atmel,sama5d4-wdt";
> >                                  reg = <0xf8048040 0x10>;
> > --
> > 2.34.1
> >   
> 



-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com

  reply	other threads:[~2022-03-04  9:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04  9:12 [PATCH v3 0/3] add TCB driver for sama5d2 Clément Léger
2022-03-04  9:12 ` [PATCH v3 1/3] timer: atmel_tcb_timer: add atmel_tcb driver Clément Léger
2022-03-04  9:12 ` [PATCH v3 2/3] ARM: dts: at91: sama5d2: add TCB node Clément Léger
2022-03-04  9:32   ` Eugen.Hristev
2022-03-04  9:35     ` Clément Léger [this message]
2022-03-04  9:12 ` [PATCH v3 3/3] configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMER Clément Léger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304103552.05abd65d@fixe.home \
    --to=clement.leger@bootlin.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.