From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A4EC433F5 for ; Fri, 4 Mar 2022 11:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239127AbiCDLQD (ORCPT ); Fri, 4 Mar 2022 06:16:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235970AbiCDLQC (ORCPT ); Fri, 4 Mar 2022 06:16:02 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 612461B0BC5 for ; Fri, 4 Mar 2022 03:15:15 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1nQ5tx-0007N8-Ro; Fri, 04 Mar 2022 12:15:13 +0100 Date: Fri, 4 Mar 2022 12:15:13 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] evaluate: init cmd pointer for new on-stack context Message-ID: <20220304111513.GA13204@breakpoint.cc> References: <20220304103634.13160-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > On Fri, Mar 04, 2022 at 11:36:34AM +0100, Florian Westphal wrote: > > else, this will segfault when trying to print the > > "table 'x' doesn't exist" error message. > > LGTM, thanks. One nitpick below: I've pushed it out with the corrected comment.