From: Christoph Hellwig <hch@lst.de>
To: Mingbao Sun <sunmingbao@tom.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
tyler.sun@dell.com, ping.gan@dell.com, yanxiu.cai@dell.com,
libin.zhang@dell.com, ao.sun@dell.com
Subject: Re: [PATCH 2/2] nvme-tcp: support specifying the congestion-control
Date: Fri, 4 Mar 2022 17:20:32 +0100 [thread overview]
Message-ID: <20220304162032.GA12250@lst.de> (raw)
In-Reply-To: <20220304092754.2721-3-sunmingbao@tom.com>
I'll let the NVMe/TCP maintainer comment on the actual functionality,
but:
> + p = match_strdup(args);
> + if (!p) {
> + ret = -ENOMEM;
> + goto out;
> + }
> +
> + key = tcp_ca_get_key_by_name(NULL, p, &ecn_ca);
> + if (key == TCP_CA_UNSPEC) {
> + pr_err("congestion control %s not found.\n",
> + p);
> + ret = -EINVAL;
> + kfree(p);
> + goto out;
> + }
We can't just call networking code from nvme-fabrics.ko
next prev parent reply other threads:[~2022-03-04 16:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 9:27 [PATCH 0/2] NVMe_over_TCP: support specifying the congestion-control Mingbao Sun
2022-03-04 9:27 ` [PATCH 1/2] nvmet-tcp: " Mingbao Sun
2022-03-04 9:27 ` [PATCH 2/2] nvme-tcp: " Mingbao Sun
2022-03-04 16:20 ` Christoph Hellwig [this message]
2022-03-05 7:09 ` Mingbao Sun
2022-03-08 7:12 ` Christoph Hellwig
2022-03-08 7:57 ` Mingbao Sun
2022-03-08 13:03 ` [PATCH 0/2] NVMe_over_TCP: " Mingbao Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304162032.GA12250@lst.de \
--to=hch@lst.de \
--cc=ao.sun@dell.com \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=libin.zhang@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ping.gan@dell.com \
--cc=sagi@grimberg.me \
--cc=sunmingbao@tom.com \
--cc=tyler.sun@dell.com \
--cc=yanxiu.cai@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.