From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, liavalb@gmail.com
Subject: Re: [PATCH v6 1/4] tests/acpi: i386: allow FACP acpi table changes
Date: Sun, 6 Mar 2022 06:19:21 -0500 [thread overview]
Message-ID: <20220306061833-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220304150722.2069132-2-ani@anisinha.ca>
On Fri, Mar 04, 2022 at 08:37:19PM +0530, Ani Sinha wrote:
> From: Liav Albani <liavalb@gmail.com>
>
> The FACP table is going to be changed for x86/q35 machines. To be sure
> the following changes are not breaking any QEMU test this change follows
> step 2 from the bios-tables-test.c guide on changes that affect ACPI
> tables.
>
> Signed-off-by: Liav Albani <liavalb@gmail.com>
> Acked-by: Ani Sinha <ani@anisinha.ca>
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index dfb8523c8b..7570e39369 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1 +1,5 @@
> /* List of comma-separated changed AML files to ignore */
> +"tests/data/acpi/q35/FACP",
> +"tests/data/acpi/q35/FACP.nosmm",
> +"tests/data/acpi/q35/FACP.slic",
> +"tests/data/acpi/q35/FACP.xapic",
For me make check fails with the changes in patch 2.
what about the rest of q35 FACP tables?
> --
> 2.25.1
next prev parent reply other threads:[~2022-03-06 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 15:07 [PATCH v6 0/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table Ani Sinha
2022-03-04 15:07 ` [PATCH v6 1/4] tests/acpi: i386: allow FACP acpi table changes Ani Sinha
2022-03-06 11:19 ` Michael S. Tsirkin [this message]
2022-03-06 14:23 ` Ani Sinha
2022-03-04 15:07 ` [PATCH v6 2/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table Ani Sinha
2022-03-04 15:07 ` [PATCH v6 3/4] tests/acpi: i386: update FACP table differences Ani Sinha
2022-03-04 15:07 ` [PATCH v6 4/4] hw/acpi/microvm: turn on 8042 bit in FADT boot architecture flags if present Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220306061833-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=liavalb@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.