From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 04/14] sd: rename the scsi_disk.dev field
Date: Sun, 6 Mar 2022 09:40:46 +0100 [thread overview]
Message-ID: <20220306084046.GA22113@lst.de> (raw)
In-Reply-To: <7ff2340d-892b-94b5-ec39-355a8f8adc73@acm.org>
On Sat, Mar 05, 2022 at 05:38:40PM -0800, Bart Van Assche wrote:
> On 3/4/22 08:03, Christoph Hellwig wrote:
>> + /*
>> + * This device is mostly just used to show a bunch of attributes in a
>> + * weird place. In doubt don't add any new users, and most importantly
>> + * don't use if for any actual refcounting.
>> + */
>> + struct device disk_dev;
>
> Isn't "weird place" subjective? How about mentioning the sysfs path
> explicitly (/sys/class/scsi_disk/H:C:I:L)? How about explaining why no new
> sysfs attributes should be added to that device instance?
Well, weird place means that all normale drivers would just use
attributes on the gendisk for it, but sd creates a completely pointless
device under the gendisk device for it. If you have a better wording
I can change it.
next prev parent reply other threads:[~2022-03-06 8:40 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 16:03 move more work to disk_release v3 Christoph Hellwig
2022-03-04 16:03 ` [PATCH 01/14] blk-mq: do not include passthrough requests in I/O accounting Christoph Hellwig
2022-03-06 1:02 ` Bart Van Assche
2022-03-07 3:12 ` Chaitanya Kulkarni
2022-03-08 3:13 ` Martin K. Petersen
2022-03-04 16:03 ` [PATCH 02/14] blk-mq: handle already freed tags gracefully in blk_mq_free_rqs Christoph Hellwig
2022-03-06 1:05 ` Bart Van Assche
2022-03-08 3:14 ` Martin K. Petersen
2022-03-04 16:03 ` [PATCH 03/14] scsi: don't use disk->private_data to find the scsi_driver Christoph Hellwig
2022-03-06 1:27 ` Bart Van Assche
2022-03-06 3:09 ` Ming Lei
2022-03-07 3:14 ` Chaitanya Kulkarni
2022-03-08 3:16 ` Martin K. Petersen
2022-03-04 16:03 ` [PATCH 04/14] sd: rename the scsi_disk.dev field Christoph Hellwig
2022-03-06 1:38 ` Bart Van Assche
2022-03-06 8:40 ` Christoph Hellwig [this message]
2022-03-06 20:34 ` Bart Van Assche
2022-03-06 3:31 ` Ming Lei
2022-03-06 8:43 ` Christoph Hellwig
2022-03-07 3:16 ` Chaitanya Kulkarni
2022-03-08 3:25 ` Martin K. Petersen
2022-03-04 16:03 ` [PATCH 05/14] sd: call sd_zbc_release_disk before releasing the scsi_device reference Christoph Hellwig
2022-03-06 1:44 ` Bart Van Assche
2022-03-06 3:33 ` Ming Lei
2022-03-08 3:25 ` Martin K. Petersen
2022-03-04 16:03 ` [PATCH 06/14] sd: delay calling free_opal_dev Christoph Hellwig
2022-03-06 1:45 ` Bart Van Assche
2022-03-06 3:41 ` Ming Lei
2022-03-07 3:17 ` Chaitanya Kulkarni
2022-03-08 3:26 ` Martin K. Petersen
2022-03-04 16:03 ` [PATCH 07/14] sd: make use of ->free_disk to simplify refcounting Christoph Hellwig
2022-03-06 2:03 ` Bart Van Assche
2022-03-06 8:46 ` Christoph Hellwig
2022-03-06 3:54 ` Ming Lei
2022-03-08 3:29 ` Martin K. Petersen
2022-03-04 16:03 ` [PATCH 08/14] sr: implement ->free_disk Christoph Hellwig
2022-03-06 4:01 ` Ming Lei
2022-03-06 21:44 ` Bart Van Assche
2022-03-08 3:31 ` Martin K. Petersen
2022-03-04 16:03 ` [PATCH 09/14] block: move blkcg initialization/destroy into disk allocation/release handler Christoph Hellwig
2022-03-07 3:18 ` Chaitanya Kulkarni
2022-03-04 16:03 ` [PATCH 10/14] block: don't remove hctx debugfs dir from blk_mq_exit_queue Christoph Hellwig
2022-03-04 16:03 ` [PATCH 11/14] block: move q_usage_counter release into blk_queue_release Christoph Hellwig
2022-03-04 16:03 ` [PATCH 12/14] block: move blk_exit_queue into disk_release Christoph Hellwig
2022-03-06 21:21 ` Bart Van Assche
2022-03-04 16:03 ` [PATCH 13/14] block: do more work in elevator_exit Christoph Hellwig
2022-03-04 16:03 ` [PATCH 14/14] block: move rq_qos_exit() into disk_release() Christoph Hellwig
2022-03-06 20:51 ` Bart Van Assche
2022-03-07 2:50 ` Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2022-03-08 5:51 move more work to disk_release v4 Christoph Hellwig
2022-03-08 5:51 ` [PATCH 04/14] sd: rename the scsi_disk.dev field Christoph Hellwig
2022-02-27 17:21 move more work to disk_release v2 Christoph Hellwig
2022-02-27 17:21 ` [PATCH 04/14] sd: rename the scsi_disk.dev field Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220306084046.GA22113@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.