All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Clément Léger" <clement.leger@bootlin.com>
To: <Claudiu.Beznea@microchip.com>
Cc: <Eugen.Hristev@microchip.com>, <Ludovic.Desroches@microchip.com>,
	<u-boot@lists.denx.de>, <Nicolas.Ferre@microchip.com>,
	<thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v5 4/4] configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMER
Date: Mon, 7 Mar 2022 12:10:51 +0100	[thread overview]
Message-ID: <20220307121051.43a23a09@fixe.home> (raw)
In-Reply-To: <beb7a226-4698-45c6-b5af-cace97beb380@microchip.com>

Le Mon, 7 Mar 2022 11:06:17 +0000,
<Claudiu.Beznea@microchip.com> a écrit :

> > diff --git a/configs/sama5d2_icp_mmc_defconfig b/configs/sama5d2_icp_mmc_defconfig
> > index 7761a57e0c..2eb2e92110 100644
> > --- a/configs/sama5d2_icp_mmc_defconfig
> > +++ b/configs/sama5d2_icp_mmc_defconfig
> > @@ -83,5 +83,6 @@ CONFIG_ATMEL_USART=y
> >  CONFIG_TIMER=y
> >  CONFIG_SPL_TIMER=y
> >  CONFIG_ATMEL_PIT_TIMER=y
> > +CONFIG_ATMEL_TCB_TIMER=y  
> 
> As far as I can tell, dm_timer_init() will probe the first available timer
> if there is no CONFIG_OF_REAL enabled + tick-timer DT entry. With this,
> having 2 timers enabled in config might not lead to using TCB all the time
> as it might be expected.

Hi Claudiu,

Hum indeed. Should I remove this commit and let the user select the TCB
when needed ?

Thanks,

> 
> Thank you,
> Claudiu Beznea


-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com

  reply	other threads:[~2022-03-07 11:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 11:05 [PATCH v5 0/4] add TCB driver for sama5d2 Clément Léger
2022-03-04 11:05 ` [PATCH v5 1/4] timer: atmel_tcb_timer: add atmel_tcb driver Clément Léger
2022-03-07 10:57   ` Claudiu.Beznea
2022-03-07 11:08     ` Clément Léger
2022-03-04 11:05 ` [PATCH v5 2/4] ARM: dts: at91: sama5d2: add AIC node Clément Léger
2022-03-04 14:33   ` Eugen.Hristev
2022-03-07 11:00   ` Claudiu.Beznea
2022-03-04 11:05 ` [PATCH v5 3/4] ARM: dts: at91: sama5d2: add TCB node Clément Léger
2022-03-04 14:31   ` Eugen.Hristev
2022-03-04 14:42     ` Clément Léger
2022-03-04 11:05 ` [PATCH v5 4/4] configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMER Clément Léger
2022-03-07 11:06   ` Claudiu.Beznea
2022-03-07 11:10     ` Clément Léger [this message]
2022-03-07 13:06       ` Claudiu.Beznea
2022-03-07 13:14         ` Eugen.Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220307121051.43a23a09@fixe.home \
    --to=clement.leger@bootlin.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.