Re: [PATCH mptcp-next v6 3/4] bpf: add skc_to_mptcp_sock helper

[Geliang Tang <geliang.tang@suse.com>]

Hi Matt,

On Mon, Mar 07, 2022 at 03:04:29PM +0100, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 06/03/2022 02:01, Geliang Tang wrote:
> > This patch implemented bpf_skc_to_mptcp_sock helper. Defined a new bpf_id
> > BTF_SOCK_TYPE_MPTCP, and added a new helper bpf_mptcp_sock_from_subflow()
> > to get struct bpf_mptcp_sock from a given subflow socket.
> 
> Thank you for the new version. It looks more like what I had in mind
> after having re-read Alexei's review!
> 
> Patches 1-3/4 looks good to me but I just have two small suggestions for
> this patch 3/4. My review for patch 4/4 will follow.
> 
> Do you mind if I re-add Nicolas' SoB as a co-developer? It is fine for
> me to change the commiter name because after the recent review
> iterations we had recently, the code has been almost fully rewritten.
> But still, I would prefer to keep him as Co-dev as a "reward" for what
> he did as a student :)
> 
> So we would have:
> 
>   Co-developed-by: Nicolas Rybowski <nicolas.rybowski@tessares.net>
>   Signed-off-by: Nicolas Rybowski <nicolas.rybowski@tessares.net>
>   Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> 
> No objection from you?

Sure! Please add Nicolas' SoB tag and your Suggested-by tag. I should
have added them. :)

> 
> (...)
> 
> > diff --git a/net/mptcp/bpf.c b/net/mptcp/bpf.c
> > new file mode 100644
> > index 000000000000..d140979181f9
> > --- /dev/null
> > +++ b/net/mptcp/bpf.c
> > @@ -0,0 +1,17 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Multipath TCP
> > + *
> > + * Copyright (c) 2022, SUSE.
> 
> I understand your modification but is it OK if I re-add the previous
> before the new one?
> 
>   Copyright (c) 2020, Tessares SA.
> 
> (I would prefer to keep it not to forget about very small companies
> contributing to the Linux kernel and I'm not sure it can be easily
> replaced :) )
> 
> I can do these modifications when applying the patches if there are no
> objections.

I agree, please re-add:

// SPDX-License-Identifier: GPL-2.0
/* Multipath TCP
 *
 * Copyright (c) 2020, Tessares SA.
 *
 * Author: Nicolas Rybowski <nicolas.rybowski@tessares.net>
 *
 */

Thanks,
-Geliang

> 
> Cheers,
> Matt
> -- 
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net
>