All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: song.bao.hua@hisilicon.com, linuxarm@openeuler.org,
	iommu@lists.linux-foundation.org,
	linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
	shuah@kernel.org, hch@lst.de
Subject: Re: [RESEND] dma-mapping: benchmark: Extract a common header file for map_benchmark definition
Date: Tue, 8 Mar 2022 08:20:02 +0100	[thread overview]
Message-ID: <20220308072002.GA24887@lst.de> (raw)
In-Reply-To: <20220308062857.45585-1-tiantao6@hisilicon.com>

On Tue, Mar 08, 2022 at 02:28:57PM +0800, Tian Tao wrote:
> kernel/dma/map_benchmark.c and selftests/dma/dma_map_benchmark.c
> have duplicate map_benchmark definitions, which tends to lead to
> inconsistent changes to map_benchmark on both sides, extract a
> common header file to avoid this problem.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Acked-by: Barry Song <song.bao.hua@hisilicon.com>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
>  kernel/dma/map_benchmark.c                    | 24 +-------------
>  kernel/dma/map_benchmark.h                    | 31 +++++++++++++++++++
>  .../testing/selftests/dma/dma_map_benchmark.c | 25 +--------------

This needs to go into include/uapi/ instead of using unmaintainable
local includes that poke into other directories.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: song.bao.hua@hisilicon.com, hch@lst.de, shuah@kernel.org,
	chenxiang66@hisilicon.com, skhan@linuxfoundation.org,
	iommu@lists.linux-foundation.org,
	linux-kselftest@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [RESEND] dma-mapping: benchmark: Extract a common header file for map_benchmark definition
Date: Tue, 8 Mar 2022 08:20:02 +0100	[thread overview]
Message-ID: <20220308072002.GA24887@lst.de> (raw)
In-Reply-To: <20220308062857.45585-1-tiantao6@hisilicon.com>

On Tue, Mar 08, 2022 at 02:28:57PM +0800, Tian Tao wrote:
> kernel/dma/map_benchmark.c and selftests/dma/dma_map_benchmark.c
> have duplicate map_benchmark definitions, which tends to lead to
> inconsistent changes to map_benchmark on both sides, extract a
> common header file to avoid this problem.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Acked-by: Barry Song <song.bao.hua@hisilicon.com>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
>  kernel/dma/map_benchmark.c                    | 24 +-------------
>  kernel/dma/map_benchmark.h                    | 31 +++++++++++++++++++
>  .../testing/selftests/dma/dma_map_benchmark.c | 25 +--------------

This needs to go into include/uapi/ instead of using unmaintainable
local includes that poke into other directories.

  reply	other threads:[~2022-03-08  7:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08  6:28 [RESEND] dma-mapping: benchmark: Extract a common header file for map_benchmark definition Tian Tao via iommu
2022-03-08  6:28 ` Tian Tao
2022-03-08  7:20 ` Christoph Hellwig [this message]
2022-03-08  7:20   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220308072002.GA24887@lst.de \
    --to=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=song.bao.hua@hisilicon.com \
    --cc=tiantao6@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.