Re: [lttng-dev] [PATCH lttng-tools] Fix: consumer-stream: use-after-free of metadata bucket - Vincent Whitchurch via lttng-dev

From: Vincent Whitchurch via lttng-dev <lttng-dev@lists.lttng.org>
To: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>, kernel <kernel@axis.com>
Subject: Re: [lttng-dev] [PATCH lttng-tools] Fix: consumer-stream: use-after-free of metadata bucket
Date: Tue, 8 Mar 2022 09:10:35 +0100	[thread overview]
Message-ID: <20220308081035.GA12065@axis.com> (raw)
In-Reply-To: <921962800.125936.1646674669086.JavaMail.zimbra@efficios.com>

On Mon, Mar 07, 2022 at 06:37:49PM +0100, Jérémie Galarneau wrote:
> I had a chance to look into this and came up with the following fix:
> https://review.lttng.org/c/lttng-tools/+/7478/4
> 
> Would you have a chance to try it on your end before I merge it?

I've tested the patch stack in patch set #5 and it does fix the problem
for me too.  Please feel free to add this if you like:

 Tested-by: Vincent Whitchurch <vincent.whitchurch@axis.com>

(By the way, I noticed that patch(1) gets confused by the reproduction
 patch which is part of the commit message.  This probably shouldn't
 matter much though, I only noticed it when I tried to revert the patch
 with git show | patch -p1 -R.)

> Thanks for the great bug report!

Thank you for the fix!
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev