From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:6512:204:0:0:0:0 with SMTP id a4csp2427607lfo; Tue, 8 Mar 2022 07:27:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzxmZvMGXdg9VxH3FSxSCPNB+aFd6olSkc6K7HuTefeQK1bMZA808ddE89S4dM8YfaVbt+V X-Received: by 2002:a25:d083:0:b0:629:254e:bd42 with SMTP id h125-20020a25d083000000b00629254ebd42mr10675142ybg.459.1646753253197; Tue, 08 Mar 2022 07:27:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646753253; cv=none; d=google.com; s=arc-20160816; b=B+PsMd4ZcoDCDtNE5ak4vw3etP/+jc5hgZ11QZibJuYp/SrgVrztOYDpGOlTOrI5XD pB16dmXckG+hmpdXkUepPdQmtkIi/16W0auUAPc/kr2ypM68Ub4CIh8Zpyt4P3vxvyPv rOxHp1vU1T03rkXWieYxTF39rZO/qK4GhEoBHhjxoOm9S4DzF6HtGSgTDoShJuRhK4WZ 6kbHfw5d1wp9s9Ucm4bb7dVYD4jL6uXDR+n2i1u4t5KN3fYCwMel2AqF74FNBm9ul2LW Hr2dWHO+SzjAfcOJDENaiIwJztkcwz0IZVKby6DBG2F0InQp7+NpaX2iwCzCHRisMBuF vMQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=NK5FwXTjSOeG1iVlCN+mXirX4i0K5bwcYnvkqJBj7jw=; b=ALx0QomyZ1w8eCkizeyxHMbAUhhk06VxcQUz2VAwPYCGQCbwP2lW3/+h0uU/X4CWoM A79hf5UG78hcerwKhiv9DoqEnL7KCKd7LXAMoL5bCg3+I8OVQUAHI+4clH3+F5hSRJPi YtCwyOcso2yBxfjIw8di6AQwErpfDfrw6BQGBb1kvJ2KGk70EfzFDWEK3pMS+fUd5WwY csWBoAOs6YbjAaIaSetVnJBekbT+llJdtvTLnvScqaqm/yfCkudag0fwes973JuVk1iu 3HWs2B2EIWj/ntXORPpaUZ+plGfURuE/DiKsWQjQWGOcfwYVQFeAeauQ5i605qHeM7d6 IjLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=VppRiwz7; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y198-20020a81a1cf000000b002dd0624e9e2si1474235ywg.298.2022.03.08.07.27.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Mar 2022 07:27:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=VppRiwz7; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1]:46418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRbkK-0004Yu-GU for alex.bennee@linaro.org; Tue, 08 Mar 2022 10:27:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRbkF-0004Ui-52; Tue, 08 Mar 2022 10:27:27 -0500 Received: from [2a00:1450:4864:20::12b] (port=36578 helo=mail-lf1-x12b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRbkD-0006QD-Mj; Tue, 08 Mar 2022 10:27:26 -0500 Received: by mail-lf1-x12b.google.com with SMTP id bt26so13102310lfb.3; Tue, 08 Mar 2022 07:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NK5FwXTjSOeG1iVlCN+mXirX4i0K5bwcYnvkqJBj7jw=; b=VppRiwz7iBao4xgxiDgCyEtVHaYhaPfw4EY/4AYahzhcUka5YSP9osUTmkxmnlXRfx Jfdiw1nQa5zkwb5pCjPrFoZxedvamD/hZzP5XpeF1mVXRgo/kSUjsLrwB9vNySnOEgx5 sfCkwv8/7BZIs8vYSpzd6slwA02im5KmGbW4yo78YalJXQDLkTkECD40/hxz4aCzUJrD gsCnbcqa/VCiIAmsQ9+OxXf3rfF9DIaGZJJ8PUSzYlqyQG5mzDxbrd/xlBZixQwPxH8e 421rK/0WccOGzhQeOgAexFJItn+jrw4fkWTPVSwqm85wDCeNcWO5px8xvr7Uiyei475t cXbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NK5FwXTjSOeG1iVlCN+mXirX4i0K5bwcYnvkqJBj7jw=; b=Dfvwl2Y34ohaq29xOG/e3ESU+Ryr6Jqhy0mPwWnL8IRZFCPUtyT+rCOPqsjyRKUdcx 4Mhh16WBaB/pkRM19Njiisl10sakkdjOeDEpkIaSdduV2oXuIz8iG7SdJ2uGcV6Tw2vV HZI//u2JbLqZjHrOnWsgVth+HOzIfZY9FaERVxEKNkLh3d8/gZr19SdmoVfq0UAVgIvJ w7PdO+UmN0FeYhX5qLyFv1Xwxadw2uaQvkeD96LhBxAQhmgaKbKvbRTBBcZSmL0WJGwT Hoxub6CtJ3KBfaxBPtKyxRIsp1m8/lgptLMhbHrhV8jt3x3RIkr3GDv3yyWYxZ1c1SSN M6WA== X-Gm-Message-State: AOAM532w/MNtjuGXBSCunI4PqAKl7fC/7gLaYdtCpKDrFzOs0lBfCdCQ cLMIEq627XkpsFJDPkDe3OM= X-Received: by 2002:a05:6512:4cf:b0:448:4bbd:3762 with SMTP id w15-20020a05651204cf00b004484bbd3762mr585369lfq.441.1646753242453; Tue, 08 Mar 2022 07:27:22 -0800 (PST) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id h12-20020a0565123c8c00b0044826d6ba04sm2051621lfv.208.2022.03.08.07.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 07:27:21 -0800 (PST) Date: Tue, 8 Mar 2022 16:27:21 +0100 From: "Edgar E. Iglesias" To: Peter Maydell Subject: Re: [PATCH] hw/dma/xlnx_csu_dma: Set TYPE_XLNX_CSU_DMA class_size Message-ID: <20220308152721.GU3586016@toto> References: <20220308150207.2546272-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308150207.2546272-1-peter.maydell@linaro.org> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::12b (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=edgar.iglesias@gmail.com; helo=mail-lf1-x12b.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francisco Iglesias , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Alistair Francis Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: +2wnNIqANRFc On Tue, Mar 08, 2022 at 03:02:07PM +0000, Peter Maydell wrote: > In commit 00f05c02f9e7342f we gave the TYPE_XLNX_CSU_DMA object its > own class struct, but forgot to update the TypeInfo::class_size > accordingly. This meant that not enough memory was allocated for the > class struct, and the initialization of xcdc->read in the class init > function wrote off the end of the memory. Add the missing line. > > Found by running 'check-qtest-aarch64' with a clang > address-sanitizer build, which complains: Reviewed-by: Edgar E. Iglesias