Re: [PATCH RFC v2] mm: Add f_ops->populate()

[kernel test robot <lkp@intel.com>]

Hi Jarkko,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on hnaz-mm/master]

url:    https://github.com/0day-ci/linux/commits/Jarkko-Sakkinen/mm-Add-f_ops-populate/20220307-150639
base:   https://github.com/hnaz/linux-mm master
config: riscv-randconfig-r042-20220307 (https://download.01.org/0day-ci/archive/20220308/202203081636.B87sz0BM-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/a051c250930ed53847224b09aaa43927a25e6c63
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jarkko-Sakkinen/mm-Add-f_ops-populate/20220307-150639
        git checkout a051c250930ed53847224b09aaa43927a25e6c63
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> ipc/shm.c:590:34: error: use of undeclared identifier 'do_populate'; did you mean 'mm_populate'?
           ret = call_mmap(sfd->file, vma, do_populate);
                                           ^~~~~~~~~~~
                                           mm_populate
   include/linux/mm.h:2698:20: note: 'mm_populate' declared here
   static inline void mm_populate(unsigned long addr, unsigned long len)
                      ^
>> ipc/shm.c:590:34: warning: address of function 'mm_populate' will always evaluate to 'true' [-Wpointer-bool-conversion]
           ret = call_mmap(sfd->file, vma, do_populate);
                 ~~~~~~~~~                 ^~~~~~~~~~~
   ipc/shm.c:590:34: note: prefix with the address-of operator to silence this warning
           ret = call_mmap(sfd->file, vma, do_populate);
                                           ^
                                           &
   1 warning and 1 error generated.


vim +590 ipc/shm.c

   575	
   576	static int shm_mmap(struct file *file, struct vm_area_struct *vma)
   577	{
   578		struct shm_file_data *sfd = shm_file_data(file);
   579		int ret;
   580	
   581		/*
   582		 * In case of remap_file_pages() emulation, the file can represent an
   583		 * IPC ID that was removed, and possibly even reused by another shm
   584		 * segment already.  Propagate this case as an error to caller.
   585		 */
   586		ret = __shm_open(vma);
   587		if (ret)
   588			return ret;
   589	
 > 590		ret = call_mmap(sfd->file, vma, do_populate);
   591		if (ret) {
   592			shm_close(vma);
   593			return ret;
   594		}
   595		sfd->vm_ops = vma->vm_ops;
   596	#ifdef CONFIG_MMU
   597		WARN_ON(!sfd->vm_ops->fault);
   598	#endif
   599		vma->vm_ops = &shm_vm_ops;
   600		return 0;
   601	}
   602	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org