All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Cong Wang <cong.wang@bytedance.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [congwang:net-next 3/6] net/core/skmsg.c:1159:17: error: 'desc' undeclared
Date: Tue, 8 Mar 2022 20:23:47 +0800	[thread overview]
Message-ID: <202203082002.YjBSPpOd-lkp@intel.com> (raw)

tree:   https://github.com/congwang/linux.git net-next
head:   22f7ed3aeaffba31c10ca78b26baf372f54e347b
commit: 2781a9702395d5b43d15c9becfd2901eaa501dd4 [3/6] tcp: introduce ->read_sock()
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220308/202203082002.YjBSPpOd-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/congwang/linux/commit/2781a9702395d5b43d15c9becfd2901eaa501dd4
        git remote add congwang https://github.com/congwang/linux.git
        git fetch --no-tags congwang net-next
        git checkout 2781a9702395d5b43d15c9becfd2901eaa501dd4
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash net/core/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

Note: the congwang/net-next HEAD 22f7ed3aeaffba31c10ca78b26baf372f54e347b builds fine.
      It only hurts bisectability.

All errors (new ones prefixed by >>):

   net/core/skmsg.c: In function 'sk_psock_verdict_recv':
>> net/core/skmsg.c:1159:17: error: 'desc' undeclared (first use in this function)
    1159 |                 desc->error = -ENOMEM;
         |                 ^~~~
   net/core/skmsg.c:1159:17: note: each undeclared identifier is reported only once for each function it appears in


vim +/desc +1159 net/core/skmsg.c

887596095ec2a9e Cong Wang      2021-02-23  1148  
2781a9702395d5b Cong Wang      2022-03-07  1149  static int sk_psock_verdict_recv(struct sock *sk, struct sk_buff *skb)
ef5659280eb13e8 John Fastabend 2020-10-10  1150  {
ef5659280eb13e8 John Fastabend 2020-10-10  1151  	struct sk_psock *psock;
ef5659280eb13e8 John Fastabend 2020-10-10  1152  	struct bpf_prog *prog;
ef5659280eb13e8 John Fastabend 2020-10-10  1153  	int ret = __SK_DROP;
2781a9702395d5b Cong Wang      2022-03-07  1154  	int len = skb->len;
ef5659280eb13e8 John Fastabend 2020-10-10  1155  
ef5659280eb13e8 John Fastabend 2020-10-10  1156  	/* clone here so sk_eat_skb() in tcp_read_sock does not drop our data */
ef5659280eb13e8 John Fastabend 2020-10-10  1157  	skb = skb_clone(skb, GFP_ATOMIC);
ef5659280eb13e8 John Fastabend 2020-10-10  1158  	if (!skb) {
ef5659280eb13e8 John Fastabend 2020-10-10 @1159  		desc->error = -ENOMEM;
ef5659280eb13e8 John Fastabend 2020-10-10  1160  		return 0;
ef5659280eb13e8 John Fastabend 2020-10-10  1161  	}
ef5659280eb13e8 John Fastabend 2020-10-10  1162  
ef5659280eb13e8 John Fastabend 2020-10-10  1163  	rcu_read_lock();
ef5659280eb13e8 John Fastabend 2020-10-10  1164  	psock = sk_psock(sk);
ef5659280eb13e8 John Fastabend 2020-10-10  1165  	if (unlikely(!psock)) {
ef5659280eb13e8 John Fastabend 2020-10-10  1166  		len = 0;
781dd0431eb549f Cong Wang      2021-06-14  1167  		sock_drop(sk, skb);
ef5659280eb13e8 John Fastabend 2020-10-10  1168  		goto out;
ef5659280eb13e8 John Fastabend 2020-10-10  1169  	}
ae8b8332fbb512f Cong Wang      2021-02-23  1170  	prog = READ_ONCE(psock->progs.stream_verdict);
a7ba4558e69a3c2 Cong Wang      2021-03-30  1171  	if (!prog)
a7ba4558e69a3c2 Cong Wang      2021-03-30  1172  		prog = READ_ONCE(psock->progs.skb_verdict);
ef5659280eb13e8 John Fastabend 2020-10-10  1173  	if (likely(prog)) {
144748eb0c44509 John Fastabend 2021-04-01  1174  		skb->sk = sk;
e3526bb92a2084c Cong Wang      2021-02-23  1175  		skb_dst_drop(skb);
e3526bb92a2084c Cong Wang      2021-02-23  1176  		skb_bpf_redirect_clear(skb);
533342322276b06 Cong Wang      2021-02-23  1177  		ret = bpf_prog_run_pin_on_cpu(prog, skb);
e3526bb92a2084c Cong Wang      2021-02-23  1178  		ret = sk_psock_map_verd(ret, skb_bpf_redirect_fetch(skb));
144748eb0c44509 John Fastabend 2021-04-01  1179  		skb->sk = NULL;
ef5659280eb13e8 John Fastabend 2020-10-10  1180  	}
1581a6c1c3291a8 Cong Wang      2021-06-14  1181  	if (sk_psock_verdict_apply(psock, skb, ret) < 0)
1581a6c1c3291a8 Cong Wang      2021-06-14  1182  		len = 0;
ef5659280eb13e8 John Fastabend 2020-10-10  1183  out:
ef5659280eb13e8 John Fastabend 2020-10-10  1184  	rcu_read_unlock();
ef5659280eb13e8 John Fastabend 2020-10-10  1185  	return len;
ef5659280eb13e8 John Fastabend 2020-10-10  1186  }
ef5659280eb13e8 John Fastabend 2020-10-10  1187  

:::::: The code at line 1159 was first introduced by commit
:::::: ef5659280eb13e8ac31c296f58cfdfa1684ac06b bpf, sockmap: Allow skipping sk_skb parser program

:::::: TO: John Fastabend <john.fastabend@gmail.com>
:::::: CC: Alexei Starovoitov <ast@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

                 reply	other threads:[~2022-03-08 12:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202203082002.YjBSPpOd-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cong.wang@bytedance.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.