From: Nathan Chancellor <nathan@kernel.org>
To: Gonglei <arei.gonglei@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>
Cc: zhenwei pi <pizhenwei@bytedance.com>,
lei he <helei.sig11@bytedance.com>,
virtualization@lists.linux-foundation.org,
linux-crypto@vger.kernel.org, patches@lists.linux.dev,
Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH -next] crypto: virtio - Select new dependencies
Date: Tue, 8 Mar 2022 13:53:09 -0700 [thread overview]
Message-ID: <20220308205309.2192502-1-nathan@kernel.org> (raw)
With ARCH=riscv defconfig, there are errors at link time:
virtio_crypto_akcipher_algs.c:(.text+0x3ea): undefined reference to `mpi_free'
virtio_crypto_akcipher_algs.c:(.text+0x48a): undefined reference to `rsa_parse_priv_key'
virtio_crypto_akcipher_algs.c:(.text+0x4bc): undefined reference to `rsa_parse_pub_key'
virtio_crypto_akcipher_algs.c:(.text+0x4d0): undefined reference to `mpi_read_raw_data'
virtio_crypto_akcipher_algs.c:(.text+0x960): undefined reference to `crypto_register_akcipher'
virtio_crypto_akcipher_algs.c:(.text+0xa3a): undefined reference to `crypto_unregister_akcipher'
The virtio crypto driver started making use of certain libraries and
algorithms without selecting them. Do so to fix these errors.
Fixes: 8a75f36b5d7a ("virtio-crypto: implement RSA algorithm")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/crypto/virtio/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig
index b894e3a8be4f..5f8915f4a9ff 100644
--- a/drivers/crypto/virtio/Kconfig
+++ b/drivers/crypto/virtio/Kconfig
@@ -3,8 +3,11 @@ config CRYPTO_DEV_VIRTIO
tristate "VirtIO crypto driver"
depends on VIRTIO
select CRYPTO_AEAD
+ select CRYPTO_AKCIPHER2
select CRYPTO_SKCIPHER
select CRYPTO_ENGINE
+ select CRYPTO_RSA
+ select MPILIB
help
This driver provides support for virtio crypto device. If you
choose 'M' here, this module will be called virtio_crypto.
base-commit: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b
--
2.35.1
next reply other threads:[~2022-03-08 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 20:53 Nathan Chancellor [this message]
2022-03-08 21:12 ` [PATCH -next] crypto: virtio - Select new dependencies Michael S. Tsirkin
2022-03-08 21:12 ` Michael S. Tsirkin
2022-03-09 1:55 ` zhenwei pi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308205309.2192502-1-nathan@kernel.org \
--to=nathan@kernel.org \
--cc=arei.gonglei@huawei.com \
--cc=helei.sig11@bytedance.com \
--cc=jasowang@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=mst@redhat.com \
--cc=patches@lists.linux.dev \
--cc=pizhenwei@bytedance.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.