From: Mingbao Sun <sunmingbao@tom.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: tyler.sun@dell.com, ping.gan@dell.com, yanxiu.cai@dell.com,
libin.zhang@dell.com, ao.sun@dell.com
Subject: Re: [PATCH v2 2/2] nvme-tcp: support specifying the congestion-control
Date: Tue, 8 Mar 2022 23:36:27 +0800 [thread overview]
Message-ID: <20220308233627.0000727d@tom.com> (raw)
In-Reply-To: <20220308151606.2563-1-sunmingbao@tom.com>
Per the comments from Christoph Hellwig, the calls to networking APIs
in nvme-fabrics.ko were deleted.
Since the tcp_congestion passed in from the user-space could also get
checked later within sock_common_setsockopt in nvme_tcp_alloc_queue.
So this deletion brings no downside to command 'nvme connect'.
next prev parent reply other threads:[~2022-03-08 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 15:16 [PATCH v2 2/2] nvme-tcp: support specifying the congestion-control Mingbao Sun
2022-03-08 15:36 ` Mingbao Sun [this message]
2022-03-09 6:14 ` Christoph Hellwig
2022-03-09 7:32 ` Mingbao Sun
2022-03-09 13:41 ` Mingbao Sun
2022-03-10 8:19 ` Christoph Hellwig
2022-03-10 8:31 ` Mingbao Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308233627.0000727d@tom.com \
--to=sunmingbao@tom.com \
--cc=ao.sun@dell.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=libin.zhang@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ping.gan@dell.com \
--cc=sagi@grimberg.me \
--cc=tyler.sun@dell.com \
--cc=yanxiu.cai@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.