From: Mingbao Sun <sunmingbao@tom.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: tyler.sun@dell.com, ping.gan@dell.com, yanxiu.cai@dell.com,
libin.zhang@dell.com, ao.sun@dell.com
Subject: Re: [PATCH v2 1/2] nvmet-tcp: support specifying the congestion-control
Date: Wed, 9 Mar 2022 14:02:30 +0800 [thread overview]
Message-ID: <20220309140230.00000e5e@tom.com> (raw)
In-Reply-To: <20220309053711.2561-1-sunmingbao@tom.com>
The patch v1 for target side also inserted some calls to
networking APIs in the generic part (configfs.c) for validating
the congestion-control specified by the user.
Per the comments from Christoph Hellwig on
‘[PATCH 2/2] nvme-tcp: support specifying the congestion-control’
(the patch for the host side), here delete these calls.
Since the tcp_congestion specified by the user could also get
checked later within sock_common_setsockopt in nvmet_tcp_add_port.
So this deletion brings little downside.
next prev parent reply other threads:[~2022-03-09 6:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 5:37 [PATCH v2 1/2] nvmet-tcp: support specifying the congestion-control Mingbao Sun
2022-03-09 6:02 ` Mingbao Sun [this message]
2022-03-09 6:15 ` Christoph Hellwig
2022-03-09 9:52 ` Mingbao Sun
2022-03-10 8:38 ` Christoph Hellwig
2022-03-10 11:06 ` Mingbao Sun
2022-03-10 11:35 ` Mingbao Sun
2022-03-10 14:20 ` Christoph Hellwig
2022-03-10 15:13 ` Mingbao Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309140230.00000e5e@tom.com \
--to=sunmingbao@tom.com \
--cc=ao.sun@dell.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=libin.zhang@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ping.gan@dell.com \
--cc=sagi@grimberg.me \
--cc=tyler.sun@dell.com \
--cc=yanxiu.cai@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.