All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - pvscan: don't use udev for external device info
Date: Wed,  9 Mar 2022 17:56:34 +0000 (GMT)	[thread overview]
Message-ID: <20220309175634.B491B3858C74@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=c7a5b5cca067496f5912bf992dcfedb6771dd083
Commit:        c7a5b5cca067496f5912bf992dcfedb6771dd083
Parent:        bef1363c0064f42e8063571143a428ad163d1bd9
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Wed Mar 9 11:54:59 2022 -0600
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Wed Mar 9 11:54:59 2022 -0600

pvscan: don't use udev for external device info

pvscan is used to populate udev info, so it can't expect
to use that udev info.
---
 tools/pvscan.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tools/pvscan.c b/tools/pvscan.c
index dcf183a46..db6709a5a 100644
--- a/tools/pvscan.c
+++ b/tools/pvscan.c
@@ -1710,13 +1710,11 @@ int pvscan_cache_cmd(struct cmd_context *cmd, int argc, char **argv)
 	}
 
 	/*
-	 * If obtain_device_list_from_udev was set to 1, force it to 0.
-	 * Don't ask udev for info since pvscan is running from udev.
-	 * If a pvscan attempts to get dev info from udev, udev can
-	 * repeatedly return errors about the dev not being initialized
-	 * which will stall the pvscan.
+	 * Do not use udev for device listing or device info because pvscan
+	 * is used to populate udev info.
 	 */
 	init_obtain_device_list_from_udev(0);
+	init_external_device_info_source(DEV_EXT_NONE);
 
 	if (arg_is_set(cmd, major_ARG) + arg_is_set(cmd, minor_ARG))
 		devno_args = 1;


                 reply	other threads:[~2022-03-09 17:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220309175634.B491B3858C74@sourceware.org \
    --to=teigland@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.