diff for duplicates of <202203092354.8QMmp2o7-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 7d043d2..45eb427 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,6 @@ -CC: kbuild-all(a)lists.01.org -BCC: lkp(a)intel.com -CC: linux-kernel(a)vger.kernel.org -TO: "Íñigo Huguet" <ihuguet@redhat.com> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 330f4c53d3c2d8b11d86ec03a964b86dc81452f5 commit: 52bfcdd87e83d9e69d22da5f26b1512ffc81deed net:CXGB4: fix leak if sk_buff is not used -date: 10 months ago -:::::: branch date: 18 hours ago -:::::: commit date: 10 months ago config: microblaze-randconfig-m031-20220308 (https://download.01.org/0day-ci/archive/20220309/202203092354.8QMmp2o7-lkp(a)intel.com/config) compiler: microblaze-linux-gcc (GCC) 11.2.0 @@ -19,25 +11,8 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> New smatch warnings: drivers/net/ethernet/chelsio/cxgb4/sge.c:2566 cxgb4_ethofld_send_flowc() warn: missing error code 'ret' -Old smatch warnings: -arch/microblaze/include/asm/thread_info.h:91 current_thread_info() error: uninitialized symbol 'sp'. -drivers/net/ethernet/chelsio/cxgb4/sge.c:4169 process_intrq() warn: potential spectre issue 'adap->sge.ingr_map' [w] -drivers/net/ethernet/chelsio/cxgb4/sge.c:4484 t4_sge_alloc_rxq() warn: potential spectre issue 'adap->sge.ingr_map' [w] -drivers/net/ethernet/chelsio/cxgb4/sge.c:4491 t4_sge_alloc_rxq() warn: potential spectre issue 'adap->sge.egr_map' [w] - vim +/ret +2566 drivers/net/ethernet/chelsio/cxgb4/sge.c -69422a7e5d578aa Rahul Lakkireddy 2020-04-30 2524 -0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2525 /** -0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2526 * cxgb4_ethofld_send_flowc - Send ETHOFLD flowc request to bind eotid to tc. -29bbf5d7f5efe84 Rahul Lakkireddy 2020-06-24 2527 * @dev: netdevice -29bbf5d7f5efe84 Rahul Lakkireddy 2020-06-24 2528 * @eotid: ETHOFLD tid to bind/unbind -29bbf5d7f5efe84 Rahul Lakkireddy 2020-06-24 2529 * @tc: traffic class. If set to FW_SCHED_CLS_NONE, then unbinds the @eotid -0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2530 * -0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2531 * Send a FLOWC work request to bind an ETHOFLD TID to a traffic class. -0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2532 * If @tc is set to FW_SCHED_CLS_NONE, then the @eotid is unbound from -0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2533 * a traffic class. -0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2534 */ 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2535 int cxgb4_ethofld_send_flowc(struct net_device *dev, u32 eotid, u32 tc) 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2536 { 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2537 struct port_info *pi = netdev2pinfo(dev); @@ -70,11 +45,16 @@ a422d5ff6defb1c Gustavo A. R. Silva 2020-06-19 2548 len = struct_size(flowc, 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2564 if (tc != FW_SCHED_CLS_NONE) { 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2565 if (eosw_txq->state != CXGB4_EO_STATE_CLOSED) 52bfcdd87e83d9e Íñigo Huguet 2021-05-05 @2566 goto out_free_skb; + ^^^^^^^^^^^^^^^^^^ + 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2567 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2568 next_state = CXGB4_EO_STATE_FLOWC_OPEN_SEND; 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2569 } else { 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2570 if (eosw_txq->state != CXGB4_EO_STATE_ACTIVE) 52bfcdd87e83d9e Íñigo Huguet 2021-05-05 2571 goto out_free_skb; + ^^^^^^^^^^^^^^^^^ +No error code. Are these errors? It's hard to tell from the context. + 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2572 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2573 next_state = CXGB4_EO_STATE_FLOWC_CLOSE_SEND; 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2574 } @@ -126,7 +106,6 @@ a422d5ff6defb1c Gustavo A. R. Silva 2020-06-19 2548 len = struct_size(flowc, 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2620 spin_unlock_bh(&eosw_txq->lock); 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2621 return ret; 0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2622 } -0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2623 --- 0-DAY CI Kernel Test Service, Intel Corporation diff --git a/a/content_digest b/N1/content_digest index 074d9e1..e1db968 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,20 +1,12 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0drivers/net/ethernet/chelsio/cxgb4/sge.c:2566 cxgb4_ethofld_send_flowc() warn: missing error code 'ret'\0" - "Date\0Wed, 09 Mar 2022 23:27:16 +0800\0" - "To\0kbuild@lists.01.org\0" + "Date\0Thu, 10 Mar 2022 10:49:12 +0300\0" + "To\0kbuild-all@lists.01.org\0" "\01:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "BCC: lkp(a)intel.com\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: \"\303\215\303\261igo Huguet\" <ihuguet@redhat.com>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: 330f4c53d3c2d8b11d86ec03a964b86dc81452f5\n" "commit: 52bfcdd87e83d9e69d22da5f26b1512ffc81deed net:CXGB4: fix leak if sk_buff is not used\n" - "date: 10 months ago\n" - ":::::: branch date: 18 hours ago\n" - ":::::: commit date: 10 months ago\n" "config: microblaze-randconfig-m031-20220308 (https://download.01.org/0day-ci/archive/20220309/202203092354.8QMmp2o7-lkp(a)intel.com/config)\n" "compiler: microblaze-linux-gcc (GCC) 11.2.0\n" "\n" @@ -25,25 +17,8 @@ "New smatch warnings:\n" "drivers/net/ethernet/chelsio/cxgb4/sge.c:2566 cxgb4_ethofld_send_flowc() warn: missing error code 'ret'\n" "\n" - "Old smatch warnings:\n" - "arch/microblaze/include/asm/thread_info.h:91 current_thread_info() error: uninitialized symbol 'sp'.\n" - "drivers/net/ethernet/chelsio/cxgb4/sge.c:4169 process_intrq() warn: potential spectre issue 'adap->sge.ingr_map' [w]\n" - "drivers/net/ethernet/chelsio/cxgb4/sge.c:4484 t4_sge_alloc_rxq() warn: potential spectre issue 'adap->sge.ingr_map' [w]\n" - "drivers/net/ethernet/chelsio/cxgb4/sge.c:4491 t4_sge_alloc_rxq() warn: potential spectre issue 'adap->sge.egr_map' [w]\n" - "\n" "vim +/ret +2566 drivers/net/ethernet/chelsio/cxgb4/sge.c\n" "\n" - "69422a7e5d578aa Rahul Lakkireddy 2020-04-30 2524 \n" - "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2525 /**\n" - "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2526 * cxgb4_ethofld_send_flowc - Send ETHOFLD flowc request to bind eotid to tc.\n" - "29bbf5d7f5efe84 Rahul Lakkireddy 2020-06-24 2527 * @dev: netdevice\n" - "29bbf5d7f5efe84 Rahul Lakkireddy 2020-06-24 2528 * @eotid: ETHOFLD tid to bind/unbind\n" - "29bbf5d7f5efe84 Rahul Lakkireddy 2020-06-24 2529 * @tc: traffic class. If set to FW_SCHED_CLS_NONE, then unbinds the @eotid\n" - "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2530 *\n" - "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2531 * Send a FLOWC work request to bind an ETHOFLD TID to a traffic class.\n" - "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2532 * If @tc is set to FW_SCHED_CLS_NONE, then the @eotid is unbound from\n" - "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2533 * a traffic class.\n" - "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2534 */\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2535 int cxgb4_ethofld_send_flowc(struct net_device *dev, u32 eotid, u32 tc)\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2536 {\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2537 \tstruct port_info *pi = netdev2pinfo(dev);\n" @@ -76,11 +51,16 @@ "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2564 \tif (tc != FW_SCHED_CLS_NONE) {\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2565 \t\tif (eosw_txq->state != CXGB4_EO_STATE_CLOSED)\n" "52bfcdd87e83d9e \303\215\303\261igo Huguet 2021-05-05 @2566 \t\t\tgoto out_free_skb;\n" + " ^^^^^^^^^^^^^^^^^^\n" + "\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2567 \n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2568 \t\tnext_state = CXGB4_EO_STATE_FLOWC_OPEN_SEND;\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2569 \t} else {\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2570 \t\tif (eosw_txq->state != CXGB4_EO_STATE_ACTIVE)\n" "52bfcdd87e83d9e \303\215\303\261igo Huguet 2021-05-05 2571 \t\t\tgoto out_free_skb;\n" + " ^^^^^^^^^^^^^^^^^\n" + "No error code. Are these errors? It's hard to tell from the context.\n" + "\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2572 \n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2573 \t\tnext_state = CXGB4_EO_STATE_FLOWC_CLOSE_SEND;\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2574 \t}\n" @@ -132,10 +112,9 @@ "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2620 \tspin_unlock_bh(&eosw_txq->lock);\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2621 \treturn ret;\n" "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2622 }\n" - "0e395b3cb1fb82f Rahul Lakkireddy 2019-11-07 2623 \n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -932718aa430e2be1ef5ea5c0e15f73f578511a4b215e282350efd8ed626dee33 +d03fe46eeb6084915d27cd89b0596b4223a2c10854cfabd0a9c391574c1f3f4f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.