From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, blo@iol.unh.edu, stable@dpdk.org,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] bpf: fix build with some libpcap version on FreeBSD
Date: Thu, 10 Mar 2022 10:54:58 -0800 [thread overview]
Message-ID: <20220310105458.24ee6d94@hermes.local> (raw)
In-Reply-To: <20220310183040.31724-1-david.marchand@redhat.com>
On Thu, 10 Mar 2022 19:30:40 +0100
David Marchand <david.marchand@redhat.com> wrote:
> This is something caught in UNH FreeBSD env.
>
> For some reason [1], the pcap/bpf.h header started to define _BPF_H_.
>
> It happens that the bpf_impl.h internal DPDK header uses this define as
> an internal guard.
> This triggers a build failure in bpf_convert.c which can't find
> RTE_BPF_LOG macro.
>
> Fix the include guard to use the filename and remove _.
>
> 1: https://github.com/the-tcpdump-group/libpcap/pull/1074
>
> Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2022-03-10 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 18:30 [PATCH] bpf: fix build with some libpcap version on FreeBSD David Marchand
2022-03-10 18:54 ` Stephen Hemminger [this message]
2022-03-14 10:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310105458.24ee6d94@hermes.local \
--to=stephen@networkplumber.org \
--cc=blo@iol.unh.edu \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.