All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: codrin.ciubotariu@microchip.com
Cc: alsa-devel@alsa-project.org
Subject: [bug report] ASoC: atmel: mchp-pdmc: add PDMC driver
Date: Thu, 10 Mar 2022 17:49:15 +0300	[thread overview]
Message-ID: <20220310144915.GA7354@kili> (raw)

Hello Codrin Ciubotariu,

The patch 50291652af52: "ASoC: atmel: mchp-pdmc: add PDMC driver"
from Mar 7, 2022, leads to the following Smatch static checker
warning:

	sound/soc/atmel/mchp-pdmc.c:186 mchp_pdmc_af_put()
	warn: this array is probably non-NULL. 'uvalue->value.integer.value'

sound/soc/atmel/mchp-pdmc.c
    181 static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
    182                             struct snd_ctl_elem_value *uvalue)
    183 {
    184         struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
    185         struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);
--> 186         bool af = uvalue->value.integer.value ? true : false;
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
value is an array, not a pointer.  It's always going to be non-NULL.

    187 
    188         if (dd->audio_filter_en == af)
    189                 return 0;
    190 
    191         dd->audio_filter_en = af;
    192 
    193         return 1;
    194 }

regards,
dan carpenter

             reply	other threads:[~2022-03-10 14:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 14:49 Dan Carpenter [this message]
2022-03-10 15:09 ` [bug report] ASoC: atmel: mchp-pdmc: add PDMC driver Codrin.Ciubotariu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220310144915.GA7354@kili \
    --to=dan.carpenter@oracle.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=codrin.ciubotariu@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.