From: Mathieu Mirmont via buildroot <buildroot@buildroot.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] fs/common.mk: use find instead of shell glob patterns
Date: Thu, 10 Mar 2022 16:42:09 +0100 [thread overview]
Message-ID: <20220310154209.GA32108@parad0x.org> (raw)
In-Reply-To: <2c3fb2b6d5c54261a4e0a8538ec6ea3c@AcuMS.aculab.com>
[-- Attachment #1.1: Type: text/plain, Size: 974 bytes --]
On Thu, Mar 10, 2022 at 01:47:24PM +0000, David Laight wrote:
> From: Mathieu Mirmont
> > Sent: 10 March 2022 12:11
> >
> > On Thu, Mar 10, 2022 at 11:52:08AM +0000, David Laight wrote:
> > > It is worth checking whether Debian have changed the behaviour of dash
> > > or whether they've just changed the default root shell to dash.
> >
> > They've switched to the internal fnmatch implementation of dash [1] in
> > this commit [1]. Before that they were using fnmatch(3) from the
> > glibc.
> >
> > [1] https://salsa.debian.org/debian/dash/-/commit/d7b1269eeeb5749ccc577f6e01dfccc2916b0130
>
> Hmmm:
>
> External implementations change in subtle ways, leading to hard to
> diagnose bugs. It’s better to rely on the built-in implementation
> instead.
>
> As does randomly changing the implementation!
True, however [^x] is not part of POSIX so it can't be expected to
work with /bin/sh.
--
Mathieu Mirmont <mat@parad0x.org>
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-03-10 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 10:18 [Buildroot] [PATCH 1/1] fs/common.mk: use find instead of shell glob patterns Mathieu Mirmont via buildroot
2022-03-10 10:45 ` David Laight
2022-03-10 11:33 ` Mat via buildroot
2022-03-10 11:52 ` David Laight
2022-03-10 12:11 ` Mathieu Mirmont via buildroot
2022-03-10 13:47 ` David Laight
2022-03-10 15:42 ` Mathieu Mirmont via buildroot [this message]
2022-03-10 11:22 ` Edgar Bonet
2022-03-10 11:31 ` David Laight
2022-03-10 12:02 ` [Buildroot] [PATCH v2] fs/common.mk: fix the globing pattern Mathieu Mirmont via buildroot
2022-03-12 16:19 ` Yann E. MORIN
2022-03-12 16:52 ` [Buildroot] [PATCH 1/1] fs/common.mk: use find instead of shell glob patterns Yann E. MORIN
2022-03-19 19:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310154209.GA32108@parad0x.org \
--to=buildroot@buildroot.org \
--cc=David.Laight@ACULAB.COM \
--cc=mat@parad0x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.