Re: Re: [PATCH 2/4] gpio: rockchip: get irq support for both dt and acpi

["jay.xu@rock-chips.com" <jay.xu@rock-chips.com>]

Hi Andy Shevchenko

--------------
jay.xu@rock-chips.com
>On Wed, Mar 9, 2022 at 1:06 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>>
>> Get the irq of gpio controller with fwnode apis, support for both dt
>> node and acpi.
>
>DT
>ACPI
> 
ok, i will fix it in next patchset
>...
>
>> -
>
>Stray change.
>
>> +#include <linux/acpi.h>
>
>Probably you wanted property.h. 
for this patch maybe property.h, for later acpi support, the acpi.h will be need
>
>>  #include <linux/bitops.h>
>>  #include <linux/clk.h>
>>  #include <linux/device.h>
>> @@ -639,10 +639,6 @@ static int rockchip_get_bank_data(struct rockchip_pin_bank *bank)
>>  {
>>         int id = 0;
>>
>> -       bank->irq = irq_of_parse_and_map(bank->of_node, 0);
>> -       if (!bank->irq)
>> -               return -EINVAL;
>> -
>>         bank->clk = of_clk_get(bank->of_node, 0);
>>         if (IS_ERR(bank->clk))
>>                 return PTR_ERR(bank->clk);
>> @@ -668,6 +664,24 @@ static int rockchip_get_bank_data(struct rockchip_pin_bank *bank)
>>         return 0;
>>  }
>
>...
>
>> +       if (np)
>> +               irq = irq_of_parse_and_map(np, 0);
>> +       else if (has_acpi_companion(dev))
>> +               irq = platform_get_irq_optional(to_platform_device(dev), 0);
>
>Why can't this work for the DT case? 
try to keep same for dt case, ok i will modify to common usage
>
>--
>With Best Regards,
>Andy Shevchenko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip