From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nSSL8-0005BU-PF for mharc-grub-devel@gnu.org; Thu, 10 Mar 2022 18:37:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSSL7-00058q-E2 for grub-devel@gnu.org; Thu, 10 Mar 2022 18:37:01 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:42848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSSL4-0006jb-1v for grub-devel@gnu.org; Thu, 10 Mar 2022 18:37:00 -0500 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22AMxNXY005963; Thu, 10 Mar 2022 23:36:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=CotEK8c304uD5wedn/3GAUYsyT6D7AyT+l6v4iNq8LY=; b=B3ne21lD7pISGbEc7O0Ghd/drGPNlg6niYlWKLzAb/MOXkXoP2qwSdCJt99W1JI9r5sz tOlt7qEx7iN0t1OWw4fDdP15qREbHlcJcfam7vt2WUQWjcA/p2io2CxlLKlP/FF3yAKa adrxb/Kvl+JSXSkRFPojVgIoxOfNmK+uGoLeI8FsDDK4L+Wu0yV21e072V/J0sjgUoaq o5hQT3AwoV8qrGlSaD2UYhmbKtqjRb3bCW4g8mKvkQcfCE5dsZz5TpwsrHIm24HTyd7R +CsFBI7cgSQ4/gOesk692ztt7szig3/QUaZGD66WzUYmAGJkW44vCWyPNlH3uCKWhyL1 xw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3ekyrax6d4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Mar 2022 23:36:52 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22ANRWLO183516; Thu, 10 Mar 2022 23:36:51 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by aserp3020.oracle.com with ESMTP id 3ekyp3vkb4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Mar 2022 23:36:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZRNOjLRaakXNZ5yqEqmXIzwpO0BTt3hF9hL48zYnBdj/FCt0fJhjuhvXJI4Ck0JLBe244JVtoOePQbkLe5BWkXNwOQ+fL9yJ0q2WGOAVe5ngqYpnP+dxmxekXoTAozcNRV/ykrzu0vIhFBZCrAs+S7AKeZ6rfHERyWecf2UXkemW8N/eqFTtLNbDhOZ0GOw3GbPN8tFlH0FRSkHfTWt+/wDSHxnACzgVUgvQGQqDfNmcugQgt2cDARPNVHtybiz354073Mu21PuFTOzPCdp94I4NpwssIZDKT+p3tuLcu+DgDEsrsOaf5jGIyQgHqWVdyrMPZeThuYkbFFeTW5LLNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CotEK8c304uD5wedn/3GAUYsyT6D7AyT+l6v4iNq8LY=; b=AAnieFscSC4JeM9fwkpBgldu4RZXWbX7D6ztQwJng/acIM0lZYbzpYXBxdJbLtElhltZnAhtLqvacGITpfEAGK5XtH6X39YSKJTEkCZu5VuK/X9KjvkZMLlHaRZ/HcS2ZiNxT76ZHdx43ZIgOnZoQXhDxGVFedMHA7yF+o4RCnzI8lO4PbYu0ojEZeRKq/3a5S2l7x2RRhuFFV6XEjbpi9C5zQ5FtVoNc8pkY0R9lM+mSAqGX7k0OVo6rB+huE0TF107RQZxspOr9rsWItAKCg7oQTc5jdbe709aGYKa13SpsyYXL6Bm6ZcdCThGQnSATYf6aX3tmAneiE8XvQzlXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CotEK8c304uD5wedn/3GAUYsyT6D7AyT+l6v4iNq8LY=; b=Nkdv4vAzLU1Paq33tc6AqIxLD9hFtGVxl0amoQpPUIxBwMPr3fQGOaFPpr8gYkYS4tYVIfe37nvePDxF22nkJ4cdgaTMejAA7wmkVKcN+zdoePWnCqTL1t0w/3iQagQ7x6npb0PU+obsdgCiCaL8vA4D8QSzoJdhUeVyrAeYpHE= Received: from BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) by MWHPR10MB1871.namprd10.prod.outlook.com (2603:10b6:300:10c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Thu, 10 Mar 2022 23:36:49 +0000 Received: from BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::2934:d61e:32ea:5152]) by BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::2934:d61e:32ea:5152%9]) with mapi id 15.20.5038.029; Thu, 10 Mar 2022 23:36:49 +0000 From: Daniel Kiper To: grub-devel@gnu.org Cc: development@efficientek.com, rharwood@redhat.com Subject: [PATCH 1/6] osdep/windows/platform: Disable gcc9 -Waddress-of-packed-member Date: Fri, 11 Mar 2022 00:35:55 +0100 Message-Id: <20220310233600.25910-2-daniel.kiper@oracle.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220310233600.25910-1-daniel.kiper@oracle.com> References: <20220310233600.25910-1-daniel.kiper@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6219017f-236d-413f-3065-08da02eed8fa X-MS-TrafficTypeDiagnostic: MWHPR10MB1871:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DwBPt0YCB45MNtJ+bFeZrl+8z20eSRmtzSrs1mvqxZN8BIP1bgdVNs6GVDVzav80rEF6VGTrEwYLtEbXrZKtEVYESzX1TnijARsUhtwj4QeHrUUreXga5V0KcmI1Xls0DAzVGYkz9urzOjmPC4c601cSlmerUOhr57SxjIZE2fCJvdmOEbUTGcNiD2aXf6opyNn6pwCqbX+RBwzNithATJFPzqrS8xwP3iPwYZ7gEaK97wGKuUdb7OqKiSmvyeWL9knxZNnmIwYPsA9locVPYSvyJ3kQGy/Yenb8EPApT04J9E7E5pywWUxcD+dBtyJxkZ28hq7jRfa7zeSq43nj5kOJTDk4Rac7uX9IJobB5u/K2kBhcLdkNMY4Tk5no/IHlofBCHQHm1AouqdamBlvxSERE4lW0rK0fjCifl1c0PzeNSRCrPRZg9O3xjcpx2NLfNhNdEPyOwJdKcaiYzErePcb/81pMESVOTKm4sbgyKPjxBcrMK5blJSGyuMds0GeExcZYZE1Pl3vNAYY8/GFL60IgFYTMt+4eAd2XG86bsZPJev8vpyHfTH+cMX8xSC5ugekKY9OtfJcD4AfgYLAzC35xmrWHuFusLZOVVQSyZrL8PMzO2028/VNqtZ5C1FsXZDyZcbF+Qq3eJ5i+xuUYymoZB6vOxYOhM54VDBVKRVblZEyBDolRb/AxLD5HLupwzKR1tMBVpVRygP3YGf6Eg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR10MB4822.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(1076003)(6486002)(2616005)(186003)(26005)(66476007)(508600001)(8936002)(66946007)(8676002)(66556008)(4326008)(44832011)(5660300002)(2906002)(38350700002)(38100700002)(86362001)(6916009)(6666004)(36756003)(52116002)(316002)(6506007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGwwRVhNWkxRdGEwOGN2cVhRMDNtdnJudjhpZTZ3T1RNQ2FGVGpZN29RR25F?= =?utf-8?B?Njg5MHBHRFdQS3NtMHhFclBRYWF5NWs3NWZzRnBiZHM4UGdJRmQyRmRRWlow?= =?utf-8?B?LzMzUy9sbEtvQzM5TWY4eDdMdEU5RlVMMmw5S3RKMWR6Lzg1NTVrMUNRMTNB?= =?utf-8?B?azFuNUhINFhzZUdtdXdUVWkxMk9Hc0lVZ3UwbzRCb1BVY0xPemJuZlZlVnBn?= =?utf-8?B?eklQeHFaVm5DQXlvdlA4dEVZNHZXc0JkcEp3eDFocUQyaUVtNmkxeEdZNk9n?= =?utf-8?B?VWFhS1ltdHJmWGVhTWxJRlptbjE3ZzF5a0ZvSXdubGFxRmhldmRIWE9UOWt3?= =?utf-8?B?OFM3MFA0aExCTXZEUEhYSmJNUGcrUlFEaXlmcDB0NTQ0b2sydGhENTA3Y1FS?= =?utf-8?B?YUlIeWdHQ2Z5QldpQ2RjajJoRzJGRVp5Zk9RalBQTUpUeDFrZGhsUlFjZ1dL?= =?utf-8?B?L25wV05hTkd5d2Z6TGVqM1lZNk9iczhNWWphOHZ3aXNsZzRPWEJpTTg2Zmtt?= =?utf-8?B?b2Jvb2VTellWajJobFQvK3ZDK09Pa2IrdFdzQU5XTStjTzJJbmFJWkw5RkZ2?= =?utf-8?B?d013bnVadE1zcnJWN3hDZDg1R1hZNmdramZxTGg2alBjaVBTaWRQYVcvMVkr?= =?utf-8?B?eU9uQThieEEybFVSbDlWWDhNT2kzYXFpekdYVTl5bWlXVVBFZFdEL1ZLcWlq?= =?utf-8?B?T3YrZHNrMm93STRPWEdMcVp4MllmdjlWNVhpU3lnRzFxV1U1T0FaVXE5SjBK?= =?utf-8?B?YUdjU2J4ekxGUXRVNGZ3RjVwRkxnMVU0MGtBTlA0V1BqUFlRejlYTHRVbDBW?= =?utf-8?B?WDZlTzJBeEZHOWI4Z09PZ2QyMERaSkxOb05tVFVUMXVqcjJMZlNnMEphV3Yz?= =?utf-8?B?aGVLUUNmUGdETHAwc25TQkc5QThoWnVwbE1Ia2tVajczSmxacGlJVEFpWEN0?= =?utf-8?B?eEc5NmhOYUtNSUdEcmxsSmdqQ0FPV01ndzZZOVlSNWhkL3lNaDZ4elV0NTFZ?= =?utf-8?B?UVd2YlRsdUc4UkJTMDZIZ3BWZTBNOGVhQXpLRjdOdy9wU3A2ZGNmcjRzY2gx?= =?utf-8?B?ZW9BNFE0am9QS0RmU2NsRWZpNkVOUWVQOXVzQzNJYUJJWjR3cHBHcE1HUHgz?= =?utf-8?B?YzdWYXE5cFFZb3R1MmZVT1EyTEV4eTMxRGZNSGRaYjlMS2pyeDlGT3hWN2xz?= =?utf-8?B?SzhYWnY3VzBxdjJvQ1J1enRnT0d6K3NqbnJmbG1IRmJReGsvTDUyNlg3aXht?= =?utf-8?B?Y2R6bXFyOU5TSjFmalVCcDAyM2ZHR1UxdTZWTWt4ZUdTRjNJWktFWFVTRGM2?= =?utf-8?B?Z1ZqU2Ivc1pEOEdteTVKSmdXMnpGVXQwenowbnlTZzdjbmp5dExUS0Q3SUlV?= =?utf-8?B?bTVyaXJSTnMyMkh5NUF1MFRQYnZpYWF6NzZVTEZFUHhodzMvQ1dRbk0xVlNw?= =?utf-8?B?Mkg3T1FyZmo5K1luNnFKK1ZrNUs5Skc2a0RrQW1sYUUyZXhsNjMySzVGaStR?= =?utf-8?B?VDh2ZXlxZXYvMno3RVZiM2lhVEtONGxkUVlVVTh0dmUvcUphK0VEcm9NUGxG?= =?utf-8?B?Tk9YL2ZEUlFwcHorZ2FFMm02RjRRVUJsQ054SEYrUWJ2SHhGN0dmSXF3bGlu?= =?utf-8?B?SiszZzNuM20yNFgxV2pISEMwMUVKZEJFVlhSakRPSUNla003dTFKZ1VZdHkx?= =?utf-8?B?U2VvbjVSUkQ2TXdGSS9DMlMybFdGN1ArOWtvcUY1eU1RRytGbUZVRTlqcWJZ?= =?utf-8?B?ek9Kem5TSkl4ZEVWUWMzVlorRmVOOXgydVM4OWVsTUtlQWhSTFU0SnVkQnNX?= =?utf-8?B?azNxWDNVaGRqaUR0cnpXcFBLUnQ0QjFHcVdwN09weU1IdXVuZ2MxYzNSN1Z5?= =?utf-8?B?U1lZYjJWeVlSVXNsMzVlYTVueW1rZzZSdW1zc3hiZ3BGOEY4M2F0MG82c1RS?= =?utf-8?B?Z05BNEN3NkRQWG1PU2pZbnpWbHFCSytuR0J5SklLbjF0ZWIyZHBEcnRnTmE4?= =?utf-8?B?b1lrQ1Nra2lRMTlMNDNpUEVBZEZYVUFxVmwvV0V3QVh0anFYcVBQSktIMmg5?= =?utf-8?B?OWgrdjY4QjJYeUVJR1Z5U0Z2NHBxWFprMTNkVDdYYWozQjgwQmlQMkFCamxo?= =?utf-8?B?SFlYSlF6WTNYeU5sd0ZvaDJBRDUzbGRLTFp5emVCcHVWRXIzU2QxM0JYc2Uw?= =?utf-8?Q?P1Qg82K0FGW70+boXc+3uh4=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6219017f-236d-413f-3065-08da02eed8fa X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4822.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 23:36:49.3811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MpHCEzQaoonqugejLAnVfixCagll3QMFfSrXEUl6g2JS4oHprPd3FIbvoX/Yya4tm07LXN/sQg0zkiSkjAUUZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1871 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10282 signatures=692556 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203100117 X-Proofpoint-GUID: D5vOIfGSOh4SVyYZCxrzf6oRxq1NhVjf X-Proofpoint-ORIG-GUID: D5vOIfGSOh4SVyYZCxrzf6oRxq1NhVjf Received-SPF: pass client-ip=205.220.165.32; envelope-from=daniel.kiper@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 23:37:01 -0000 $ ./configure --target=x86_64-w64-mingw32 --with-platform=efi --host=x86_64-w64-mingw32 $ make [...] In file included from grub-core/osdep/platform.c:4: grub-core/osdep/windows/platform.c: In function ‘grub_install_register_efi’: grub-core/osdep/windows/platform.c:382:41: error: taking address of packed member of ‘struct grub_efi_file_path_device_path’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 382 | path16_len = grub_utf8_to_utf16 (filep->path_name, | ~~~~~^~~~~~~~~~~ Disable the -Wadress-of-packaed-member diagnostic for grub_utf8_to_utf16() call which contains filep->path_name reference. It seems safe because the structure is defined according to the UEFI spec and we hope authors did not make any mistake... :-) This fix is similar to the fix in the commit 8e8723a6b (f2fs: Disable gcc9 -Waddress-of-packed-member). Signed-off-by: Daniel Kiper --- grub-core/osdep/windows/platform.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/grub-core/osdep/windows/platform.c b/grub-core/osdep/windows/platform.c index 253f8d101..075776d50 100644 --- a/grub-core/osdep/windows/platform.c +++ b/grub-core/osdep/windows/platform.c @@ -379,10 +379,20 @@ grub_install_register_efi (grub_device_t efidir_grub_dev, filep->header.type = GRUB_EFI_MEDIA_DEVICE_PATH_TYPE; filep->header.subtype = GRUB_EFI_FILE_PATH_DEVICE_PATH_SUBTYPE; +#if __GNUC__ >= 9 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Waddress-of-packed-member" +#endif + path16_len = grub_utf8_to_utf16 (filep->path_name, path8_len * GRUB_MAX_UTF16_PER_UTF8, (const grub_uint8_t *) efifile_path, path8_len, 0); + +#if __GNUC__ >= 9 +#pragma GCC diagnostic pop +#endif + filep->path_name[path16_len] = 0; filep->header.length = sizeof (*filep) + (path16_len + 1) * sizeof (grub_uint16_t); pathptr = &filep->path_name[path16_len + 1]; -- 2.11.0