From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nSSL8-0005Ah-Im for mharc-grub-devel@gnu.org; Thu, 10 Mar 2022 18:37:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSSL7-00058r-A3 for grub-devel@gnu.org; Thu, 10 Mar 2022 18:37:01 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:42846) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSSL4-0006ja-1t for grub-devel@gnu.org; Thu, 10 Mar 2022 18:37:00 -0500 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22AMxOkH005988; Thu, 10 Mar 2022 23:36:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=aciQbkmg+xTL5xhbLPkZSgXIO8X4vBIy1aBiNzscrO4=; b=UU2yruSlZnFAAxCt5Bet45UNMH8YBYlIyPX95GqJ9Jts+l54b7htOKXEXyXHg4AbZzWw DC0JH76VmtHEfj22wxq3pzVNMKTEB+Pelgh0lHr3MOnWRhLFD0ce8g65yhXyJeSDSwQz m3Br0hPFED/yVhF3qc1sLxRfKVxsYQuBBG45RykXLxbhfR55TsUxpDPo4rjqK+Zza9wD 5dwWKaOOsXrCdTRi6fWwUEjyVjV0BcqCVSGmBssQSOZGV4fJsWsD+o2qGj6OKNb714S/ 71ZMgjv+c4SuMIycP7BV/3EyFfLQp96xGMYBusUX6GiDi4KyALB6s6xtfdnwLutuajTX jw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3ekyrax6d5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Mar 2022 23:36:53 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22ANRWLP183516; Thu, 10 Mar 2022 23:36:52 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by aserp3020.oracle.com with ESMTP id 3ekyp3vkb4-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Mar 2022 23:36:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gbbSFv1iY+ABnCbzE+QBpiFUDzwK6jiW8SeQKW+mR/JMBVyrYs/PN9ApPd3pvUzZWlYybp1xU9QeZZmgBT1PX/ETw6EPHjnBtdDenwxQjF6wwJQHsLjC/xDp3YM5B10H61yEz6w/c3RLmqSMMzWHcaQvJxP6bYHRwQHVOaapWs0qIo/GJbwa0JRQTf49MikBux6vRn7uz/Wbphh+N7H5L/rN/lxXsB23zONovi/cbwCBypDxCEQZk0ujUf01Q7wdG+nVUqhHf/wRyBRbmysYs94LBLz0nrWGKatWCN6zSnKTK4FNSWwiiDoWywWUbX8opaYP40zeCzsW+ZapFh7WGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aciQbkmg+xTL5xhbLPkZSgXIO8X4vBIy1aBiNzscrO4=; b=fKUrCsbe5UiHjIoz4UpNrr3/F/WViuVg6J4tmxkXEpwyWw/D4AZFQryvXdYf394MQ0OAG09OxxEqofFjZSbxspaI5n2cCdQK1YOFIjgq/7ZjQK8MbKfj9dqp1NdwEzgHwTs4kZSgCTEc+lMQ06BMyih+fhvR+MqiEZlHeUBQ4aTWUiS06NjDcKGRM986g/yp8T80nn5qIMaAKu+SCzhBJMJpo1DokuKZykDiDLWCLnOB1+Sl13aY9n0tf0pQT6e8/wd6vC296vqsfSHw1XrF1mDnODQ+aSTUid5brPu2f+og/eKAjSP5VMOC4q2mLGBILQDPvTFN1MQ8XBe5oVAg7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aciQbkmg+xTL5xhbLPkZSgXIO8X4vBIy1aBiNzscrO4=; b=dh6oV3Y88pIdGClTUHjzr7Y3cJ49k7IyhTCp97+j26tiAkGroKhtBZELYJtWop+mCwHLC0KlFkpLS4UZItMi4xgj9XferHSqh3Yjk4IWMYP+Y/BsTxJXPQY67qCKU5O+EUTykXWL3dMiYnEw3jKgke/2joaqcdC6EzDX0IGoJyY= Received: from BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) by MWHPR10MB1871.namprd10.prod.outlook.com (2603:10b6:300:10c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Thu, 10 Mar 2022 23:36:50 +0000 Received: from BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::2934:d61e:32ea:5152]) by BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::2934:d61e:32ea:5152%9]) with mapi id 15.20.5038.029; Thu, 10 Mar 2022 23:36:50 +0000 From: Daniel Kiper To: grub-devel@gnu.org Cc: development@efficientek.com, rharwood@redhat.com Subject: [PATCH 2/6] loader/i386/bsd: Initialize ptr variable in grub_bsd_add_meta() Date: Fri, 11 Mar 2022 00:35:56 +0100 Message-Id: <20220310233600.25910-3-daniel.kiper@oracle.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220310233600.25910-1-daniel.kiper@oracle.com> References: <20220310233600.25910-1-daniel.kiper@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f23f795-2697-4d0d-aac0-08da02eed99e X-MS-TrafficTypeDiagnostic: MWHPR10MB1871:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1ogOPCt6yKscJYX9bRjdmUpjgc++bMjmy/nOsTbm9+n9x/sjcuaomAhDh3toXgi9YBxPNwB3cRO4n9Pn6Be26Wxhsn2cFl094KRUbhMbrGs2krkJajp42D8opEf3+FDtQonUmMESExscZPqveHJL84J8hrrfVJEUmYvhuI4biZdHHVV0VUX3HAXRLwYTCwg/f6c1DlLL6+yL7GcFR5zAjsjRce38fwpj6jnYHALy69m73IKV0Ce4l9aoX5eq0cSaDHHtWUM6hxr8TAv6nG8RlQQj3BLe0OW3M83LvtswGmAdIuqiV7gfq2fmb4m1LFbIeR2tXcQCQy5OTYr1HmBGu1jijo5FGT4fNefCWjkizn4dFTaNSQzCZLec0cZYnGI1vxbbS15kF8UXOCF5esBAAYVEo1gyM24R/i5HDPlI4rgonXsmufAAkDlS6kkjV5ZqDEoJTxpPWeYQzMj85dgNnknbjAoGMsuY/aXf4he8rVlHtwa7dTirBK5ldIWhNcteE7qHM/+lacWEDzvQ1qPl0shHu6ZmjYjeRPEHxOEMdw6UohnGchF14wXX9F/90L2mwOLs6gQDhrppkUhKiPuB68dkCfy3Pdxi32MrvMtp7QJMLT3ILnuuFKTsEe+eSabUNGTIeENuyc65WaqwqY36f3imhcG5Ydl3bSYEHe1QE6GbSfck09tO1GZjHGcyNwZmopnZtrMoLFOEP1rp2PzmjQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR10MB4822.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(1076003)(83380400001)(6486002)(2616005)(186003)(26005)(66476007)(508600001)(8936002)(66946007)(8676002)(66556008)(4326008)(44832011)(5660300002)(2906002)(38350700002)(38100700002)(86362001)(6916009)(36756003)(52116002)(316002)(6506007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anY3V1dBMFpCSEtvcWd3K2lCLy9RVTBkeHdpVlNheHdDb1htWDlLSmVtOUpo?= =?utf-8?B?OUVDVHF2cWJ5aGxyZzBQUTF3Qml0M2N2K0Y4V2ViTDlSRVZVZmxpSmpwWVpa?= =?utf-8?B?UVBKSlJWK1ZiMVp0dzM4VjJxUm1EOUN4U0RGV202RzduUFdsRk94TEZLR1Jv?= =?utf-8?B?bThhbEVZOE1IQmdGbkFDRXZPVDJOV0oyTkxmVGlZUDVYRW92emJxeUZLMDRN?= =?utf-8?B?dm1YTFk3Y3Fjanh2dElobW1hWFR2Yjl6ZEg2a24yU0ZJSHpDZm9JMGFhSG1P?= =?utf-8?B?ZWd3TTc4bWRUUVFjNnB6bDhzaTZKMWl2Y3NucXdhNmJpZ05TcW4xZ2VXSWZi?= =?utf-8?B?L3lyVjRyMHdUWVVUY2N0bklVUU15VVpxVCtZZzdYWHlXT2tBYWdJYnd6djBD?= =?utf-8?B?bzlaUElON0d3MXJRRmNpajBNY3YvNG44cjVEOGxPMlYvcVphQ09GYWNxVk5L?= =?utf-8?B?c1B5cWJZNXpkRDFQWFhMOHdGY0tZOEtGYmI0VzNJbFVEV3NBRDNra2gxMFBE?= =?utf-8?B?YWI0ZExWTkYrdHY0TCtnU244TXpXN3NPUWdRRVdKbFM1ZWttS0ZaSkxQNEcx?= =?utf-8?B?Ry9scEFtOFk0b0tyM1d1ZmxKTWtZbjVqVE0yQWFicVArR24ydEhKMHRvYXNj?= =?utf-8?B?Y1VtdXBJSGlsbnB6YXd3ekx0a1k4dUJyOTQrd3BaT201dlBQbnhPMHpma1NX?= =?utf-8?B?UTIxNnY1R0YxUnZrYVZrZmhiUTNUcURRbEU1UlY3bHIwTzgwOFFuNFk4TGZo?= =?utf-8?B?T2VYMXo2dnRQbnlXVitYT3BKQkdrUkxJbUFZakcrWFBVSGtZWHF3V0hOSzNW?= =?utf-8?B?di9PcjE1am1uOGY3UEFBemNFTWljK3VNZ29wMDRrYlBINURDV1FBWlZYQ1Ju?= =?utf-8?B?bWJOMUZLWmFudjFLNGlmUVYwOU9XTzU3OFltODJzOG5aQ0c3Z01uVWUzOVhr?= =?utf-8?B?RENVTWJHSVJ0bG8zM0IyVFh4U25mWGQ5ZXFJRXU2QWM0bCtqVUxmRUxtemV6?= =?utf-8?B?NlZSckJXbVhRUGl5bEZranlvaWxrQm13UU5WMnFOelB0bmdQMEwzTElFVitv?= =?utf-8?B?cGU0V2J1cTFlcTFKQkNTMnJ1cFdYRHNLNS84NjRnMGtIOEJkTXk2aEF4WHJV?= =?utf-8?B?bWRqTnlPS0ZFS1ZCT3hpL0E1VFM5aEhDcnQrcGFpaWpBbFVVRWcxeU1ROGgx?= =?utf-8?B?NkdPYnZlZVJSSFJ5dG9jU3ZsMzBiMWVRVFQrcjlUaVdLalZQM1lzMURob1NB?= =?utf-8?B?SW9weXFTaWx5U3NZL0Y5VDcxbitZYjY0ZmY0RUlsekEwc3JYemhQYTNwVlp2?= =?utf-8?B?NnI0UzlsZEtrbjVLUDl2UEs1WGdEelFxd1M2MVRtUWF1dzFOZ0pNMjFOMm85?= =?utf-8?B?UFhQczI4UkZsOVhGNHhJUlRzNTRRZFg1L0dNSzBZekppZ2RYVEx0RXBJZnB3?= =?utf-8?B?ZWhpamN2Uk1ZTEwrYW94VDViUXpkSHpwRXArb0VydmxpcWhCRGxtQmsrMVgx?= =?utf-8?B?UDdBZENDaHRGVi9YcWtickJZcXQraW9PN2s4SWVKT0hTOERLS1ZOVW9jVGt2?= =?utf-8?B?STdwekZKS01rYXBPKzJZTHpuT2pWbXRpWmpIKzJ5OW5iUGV2SzIyYnlYWGp2?= =?utf-8?B?eTVVenNSaHZkbDB5WHQ0eGpuV0xTMTB0NU5HTVJ6MUpCTFFwTXNvQ0dKMkFj?= =?utf-8?B?QU14dWpBenA3d0pFZjBTVit1RDM5N1YycmpZVFVVZW9nZnJ6RUVaZnBNMXhl?= =?utf-8?B?cG5rT1A4NUovK0krTlZNZ2tFRjhsNmJuMUVCSmREcXJickRqQ25XYUpKRXA2?= =?utf-8?B?Nk1ndWZOOEk3bkViVmMrUGxPUXB6VnhGZFpTQUFxSWNNQWp4WGpvRFpBc1l3?= =?utf-8?B?OFVQYjhJL0FYeXUzMzdyc0ZINWV4SElWbWhMVC9KMmM0S3BadEswQ1NNelZo?= =?utf-8?B?ditadmRvMGdXeW50cDJSNGdwVlNjZ1NtamRvdUlabkI0MHRhemZJZG9mWmxv?= =?utf-8?B?cG9Sak1QL3pPaldCM2ppQ0d1T0RjRW1tbTB0YTUwSXVKQlFIMTltd3ZqZEZ0?= =?utf-8?B?REZlWU1vb2tMU3p0S2RUTUJ3RXc4OGszRiswRDNDQ3ZrZnJtNG5XczB1ZHI3?= =?utf-8?B?NkpaajZIeHJDSitNSVJ2bEZMSUdhamNBRU1JV1kxczlpOTBGRC96eGlCUWJ5?= =?utf-8?Q?BBh1id9LK4EGS1uTnD/K1ow=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f23f795-2697-4d0d-aac0-08da02eed99e X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4822.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 23:36:50.5528 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pP9xoThySXGYUmENioSH8WbinpXfsxGv55nUFOD+6FnI2Bb7Glq+KCQEFMDhBbPLQYTrY+xAqIc7LVSu8pF2CA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1871 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10282 signatures=692556 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203100117 X-Proofpoint-GUID: VF73PID-tQTFo4JD8Rfew9oZ2CI4yQSC X-Proofpoint-ORIG-GUID: VF73PID-tQTFo4JD8Rfew9oZ2CI4yQSC Received-SPF: pass client-ip=205.220.165.32; envelope-from=daniel.kiper@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 23:37:01 -0000 Latest GCC may complain in that way: In file included from ../include/grub/disk.h:31, from ../include/grub/file.h:26, from ../include/grub/loader.h:23, from loader/i386/bsd.c:19: loader/i386/bsd.c: In function ‘grub_cmd_openbsd’: ../include/grub/misc.h:71:10: error: ‘ptr’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 71 | return grub_memmove (dest, src, n); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ loader/i386/bsd.c:266:9: note: ‘ptr’ was declared here 266 | void *ptr; | ^~~ So, let's fix it by assigning NULL to ptr in grub_bsd_add_meta(). Signed-off-by: Daniel Kiper --- grub-core/loader/i386/bsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/loader/i386/bsd.c b/grub-core/loader/i386/bsd.c index 5f3290ce1..346c4f14a 100644 --- a/grub-core/loader/i386/bsd.c +++ b/grub-core/loader/i386/bsd.c @@ -263,7 +263,7 @@ grub_err_t grub_bsd_add_meta (grub_uint32_t type, const void *data, grub_uint32_t len) { grub_err_t err; - void *ptr; + void *ptr = NULL; err = grub_bsd_add_meta_ptr (type, &ptr, len); if (err) -- 2.11.0