From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nSSL8-0005AC-CG for mharc-grub-devel@gnu.org; Thu, 10 Mar 2022 18:37:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSSL7-00058w-9I for grub-devel@gnu.org; Thu, 10 Mar 2022 18:37:01 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:46422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSSL4-0006ju-96 for grub-devel@gnu.org; Thu, 10 Mar 2022 18:37:01 -0500 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22AMxEQY004102; Thu, 10 Mar 2022 23:36:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=xGkEvmrkET6TcuwybFbU5p7aqEjrgkv4FhuD336hU+Y=; b=VGIhjyP9Itf2uy2OZXdqCGeGcKdY/pCyFHot2fleHU0yfMJijHeFzn9YBi/UtNBtNdPE 7hRMrc+ahg3Dm4w5oBT/Zb3NRvS9v+xHFIPQPtNjG/oLx2hBiuvun/YNVjrj5NoaHzx6 E/oO8zJRX+rUU7iAo0yk7nsQHePJpl3VpcXLH1HQcEyNZIQ3xq4lH413XQ4xRqU+Iv5H ydUmIyZPFWr9ZSbkJSX0z2HMo1SlrEKXkg7a2PgM2t/E2wMpYOEogJgu7+HIxpPrnF/f i89I0vUoprGwHTV/9E82qfWb3B4S0q1zv9vjK+G8P35F+Nav6G1abhJXWs4srfPJJR+H qA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3em0du6y4r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Mar 2022 23:36:55 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22ANQ0KZ073447; Thu, 10 Mar 2022 23:36:53 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2172.outbound.protection.outlook.com [104.47.57.172]) by aserp3030.oracle.com with ESMTP id 3ekwwdqhyp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Mar 2022 23:36:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RpnAHJCJB/TZnFSZLaYYbN76SfTB1u9HRGMpq/M2sQPjdi0GdZUqSFkc6j5iQwagHNdEVTBqv1C5MDSJVGvmuMnAOHo97tSqSTJjTPWkrTGYiRbN5szKnvWOHXqHOmn6FH1ZJ3RUn0ShIlUM1t8y7sePt7DDcUUlyezZ0tTbvHG8Sbfo/urlcscdYOUCFEjOIoUetMA4MqCxU69HRv3XLg9bLq+QkHyvH3RAj4m7xQQZxMUmjkQOV026pVTDB3rSD7iZ+YFRMJyPfjYAHnHNE55ejo/HOUz+JopKBQgFq6ZF6B1t6D9/Fg9tc+DQ+QngicMtYX8q2VcghRBeH13Z2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xGkEvmrkET6TcuwybFbU5p7aqEjrgkv4FhuD336hU+Y=; b=jLqda5POyelnA8FHhlfW0OfGu02gIw23VlSVJZu3U6J3zzQ+19Ebk6bh7LL8P6pJ2U2+NINmcjZtKk9Rfv/CXx2z3oWuJTRKir9H4FLsejnuEJ0TAG+KD8156ky2bn2rjAZxGxiGqBTiqa2j8Wl4YXmEoIWbTnPz5dQ0AEwdX81YYrPfKoWWADZEuTWhC2yNFDBRpDgIDkdJ5iiDb1iWzdYMXCSp34Hn6VizejxIPy0/h1hALzyb/YPQpUG5oWLhrEXRY24+AIpILBJWs2+tl3e0hEXFFvMi/EkF/xDzV/jy8vkE7VRSeO7kOjhD+aFERVijAgCWfjrDEOEnkNO2JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xGkEvmrkET6TcuwybFbU5p7aqEjrgkv4FhuD336hU+Y=; b=rnAQbXK0y+ZUGhQoC3FdWW/ho0phq9gqzpINisPiNHXTUz3YqVqZz+EDcjSEEZ7BaWAXuAXZzNUImM6oSJuBZWsv4D4+CKhLKXr2fsEhqrQZ5o9BRSW6FFPQb4KW69ocnbNBfzES7XrrV58wJgVMHtI6bMjlujhSqh621fgJ9y4= Received: from BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) by MWHPR10MB1871.namprd10.prod.outlook.com (2603:10b6:300:10c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Thu, 10 Mar 2022 23:36:51 +0000 Received: from BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::2934:d61e:32ea:5152]) by BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::2934:d61e:32ea:5152%9]) with mapi id 15.20.5038.029; Thu, 10 Mar 2022 23:36:51 +0000 From: Daniel Kiper To: grub-devel@gnu.org Cc: development@efficientek.com, rharwood@redhat.com Subject: [PATCH 3/6] commands/i386/pc/sendkey: Fix "writing 1 byte into a region of size 0" build error Date: Fri, 11 Mar 2022 00:35:57 +0100 Message-Id: <20220310233600.25910-4-daniel.kiper@oracle.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220310233600.25910-1-daniel.kiper@oracle.com> References: <20220310233600.25910-1-daniel.kiper@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09266d7b-6e43-4227-d4e1-08da02eeda56 X-MS-TrafficTypeDiagnostic: MWHPR10MB1871:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rsc9OrIvyxWLIS3FzMqHp8pxcEo1mnIchZK4bFpL/HFfY9KyV50JRHdeSiWvsje4D/kFazMQ14koP1SxVPsutdYa3+OurKHkOtEj3Xsti1EvynpVlDZ0yECK3pD/GV79roAt0GHvIGLhjujqJydyw3Lxu1gkXG791XnCKDgP1TjL8hFC2qxLgSHjKtIYnyHmnh8UBR7N+GXfZkVJ4P7+j3xby5DK0tre+U3WmsNSbh5au7Fyhu8MHNVZscMDy801lcfEe/274inQkB3gF5bRxAkpa50r0qbTogZBvnzfOTEBoQKLYP2YX0RTtLurqcDe8aWhLRBqYODQvCOxDkStbHYznsa5WZF+UgCJPdg0RmqbRYZpKw7cs6f0AEXt/lAW0xNR35oSojd6qQBirSBk4dRW467iFUClJI+To4bEBjDgwHbkHRR4BYukYImcp8DSBi6YSAtRYq94TvB8FVfS9IWuFGhiAOIHl/vad9t2kB/wDk2vxvOS65YaM6rQcWd/BlDI6jZYxfwJamW0HEsO8jTrob6OPDcb1I7tYeTewA2AwTA6Ty5/pLd4cNd4eK9AHzEufED3q2xJJ9nS+CCbx032mkAsoenthlsXR6nl6kHTgA6s63BfTk7VlZ6fPibDjHWLzDxLCBH4fSjO8hjQONWZzNvuwcIgpvb6A42mBUE2PkGoDFJw+hQTarduHxiD20MoBPCEXd5tlRC5mmhwSw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR10MB4822.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(1076003)(83380400001)(6486002)(2616005)(186003)(26005)(66476007)(508600001)(8936002)(66946007)(8676002)(66556008)(4326008)(44832011)(5660300002)(2906002)(38350700002)(38100700002)(86362001)(6916009)(36756003)(52116002)(316002)(6506007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjF2TFVyYk53eGkwZXVnMlNCYUtCZ0pFdjRuQjdENGxiaEo2Slc1dVUrdnB5?= =?utf-8?B?b2dTNkRzeXh5REhxWjM2M09SS2RDa2VNcXVGbWx2bU96TFdjWjI5Y2tVNm9P?= =?utf-8?B?OWlma3dJOHBNNEU1WTNIM0IrbmM3dGx6dXRHbUpGVklrK2F1SWlxMVVHcWYr?= =?utf-8?B?SWNBUll6Y2xaczAvNG5VNGlqRVRvQXlvblhCQjVNNHU4OHkxREFHek1qTEwz?= =?utf-8?B?NmtJNHRwd0krcTBKVnJhUzJrNk9XeWlMd3FicnR1NjFSY2dyazlNcjlZWU1Y?= =?utf-8?B?UGlDaTBFSHlFQ0Q3Z0h3S21MK0RRRnM1MHhVam5PdWFhYXpiRVF1eU9yTGpo?= =?utf-8?B?MkV6ZHFWeER4YStMV25nL25sMmlyV0U3TFkyMktkN1BNS2Z3cXljeHlhRmhz?= =?utf-8?B?K0hsTUxpcXpzaFd0T25PZ1RmeFlCSmVucFV6ZlRsRHQwNFhCOW53TmZDUHNz?= =?utf-8?B?SWdHZ3pUQi95a3Y4WXpNRXFBcWEvTjlUMXpwS2lkY2ZiNll0Y25reUR0anZE?= =?utf-8?B?QjRZd1o5UUZENG1icmZ4ZDlzWkZ5aHJXSkQxY2N0bnYwVnprMGJRU29UYWhT?= =?utf-8?B?WmdnTlo0K3k0R0pDT3ZYZVdQMGp3M25KSXhaNUhBRnd6QjFjVytjQVJucFJJ?= =?utf-8?B?aUhsdFgreFNCU2svT1RIbVRQRDd3UGYvWHdJc2R5UmJ6TjFaYXNuZE50MUFy?= =?utf-8?B?VlljZ2cvcWhHWlgyQ3J6ajdEeEdSNit1UEJlWGk4QldUQ0dLVmJTZkxkaXd4?= =?utf-8?B?VUtpQVNXeWhmL1dpbEZWQ2hiWHU1UnpGQm10b24vc25WZWdxYXpXN0kzZGlN?= =?utf-8?B?V0VWOForbW9nU0N1UlBoVGVXOWNhbUpubWpJRUgyWGVRdUc0SWRqclBnZnZu?= =?utf-8?B?aUdQby83azRxcEdGY1NwdHIxMUVIVFk4UURuMis3MjY0T3RJVG9HTEtQcEtR?= =?utf-8?B?cG9zS0g0M1hHQU5rTDUvY1B0ZTFMWXVWNG1taHRBNHNiNDVaNUNiWDY2Y01T?= =?utf-8?B?M29LM2o1aklQMTVqa1p2REdlYzNPSmhPTzBQcVR4bXYyb0R4TXd3ZlZiRVRi?= =?utf-8?B?VU9raXlNNytNN0VDcEpyeHpwMmpFMWdzc1BLZ1czRUVRUDV2NldPejFRZVAy?= =?utf-8?B?ZjVHMGZxdnFhVm5wTFROclZFbmRZVW1PejJ3QXV4QWZGdWdLaXlsdUxFS1Jr?= =?utf-8?B?c0ZKS0FGMFhUQStwaldNZ0RwZHROc0hFanR0aXlldDF1elJSUVVXaHpmOFVr?= =?utf-8?B?L0NKRGJFR2t1K2UzZUJ2ZFFmZXFSRUpjN0wrMXhRWVpML05lSHZKNk5meUVx?= =?utf-8?B?TTZCOThOUnI3MUV2UllKa3VrdTFDVTlzandDWksrNnhPeVMrWUZXUXVhdkJl?= =?utf-8?B?Z2MzbHVnajJ1ODVSTGk1MS83ZExYSnlDR295bWI1VkIxSnF4YWVmQk5XNTVs?= =?utf-8?B?c0Y3RU45TU1qRURIT0FyTTJwZWFvaUZCelV6dmQ1NkFrQytYNkQ2anNmM25K?= =?utf-8?B?MXByV1FqWEhvMUlBM29iSUdNVTdyRHRrQUx5cmRLZ1dabHA0bktnbDZ3dFBx?= =?utf-8?B?THMybUZra1RhN2RPaTAwb3NobXFQcFJRMDd5OG9uU3dpMkxScXMzNHQ3OFlN?= =?utf-8?B?TGgyOHREU0hGVldqTk5ySEIvZEM1bC9GV1Qvb0VRRUwvS003aGp2QmtNSTc0?= =?utf-8?B?aENacTJJeFZGeUxIdU5yRGtUVmVKeXd3Mi9JMWFDTXNNZ1lrS2l3YkxRRmRm?= =?utf-8?B?N21GYmhrR2k0QlB2dC9CT0dKb2dZYlpCV09UNnpGUkVTUFFrKzMzTjVFVTdk?= =?utf-8?B?NHpvM0Q5aWdqQVN2ZlJlRC9jWjJnWWZrNU5Ld2JBblc2VmNqZG9naWk0M21n?= =?utf-8?B?bndMVkxrTmR1a29nRzJsdlMvSm52SmRFNkdLMXBNbUI0bE15OUZUZ0RYVFRq?= =?utf-8?B?Z2diTk9FSFVOS0hYajNCanNxZ20vWmcrMHE0UUNWWVdQMUsvTHgzTjlXRjBL?= =?utf-8?B?UHZrR2RTamNtTDZZV2wvYzN3d1EvZllxaXdEdmdNNWh0UkpxS09SQVd1SDRq?= =?utf-8?B?amxXenVJMmphL0hTMFMwSDhVQWFSSXkxaHpLTjhnTGhVdG5HU2pTaklNUEF5?= =?utf-8?B?bk1ReDNGN3VTbU9hSUFQcGw5dXdrbmRwaTFVVS9qTWhoOFBack9BUTgrWXNn?= =?utf-8?Q?j7zOOWUC12XjG3H+lLjAuZw=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09266d7b-6e43-4227-d4e1-08da02eeda56 X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4822.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 23:36:51.6301 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W/KUPlzL1WlS40cOKcK+Utc0RujyrGdebtOMu/BdB5i3RISNZsBI4GWW9ELAR8d5qtbSlONYsnTzfLVxHizf6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1871 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10282 signatures=692556 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203100117 X-Proofpoint-ORIG-GUID: gRBoeyz31Vm17DWJubWwmKGW9uCeBSw- X-Proofpoint-GUID: gRBoeyz31Vm17DWJubWwmKGW9uCeBSw- Received-SPF: pass client-ip=205.220.165.32; envelope-from=daniel.kiper@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 23:37:01 -0000 Latest GCC may complain in that way: commands/i386/pc/sendkey.c: In function ‘grub_sendkey_postboot’: commands/i386/pc/sendkey.c:223:21: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=] 223 | *((char *) 0x41a) = 0x1e; | ~~~~~~~~~~~~~~~~~~^~~~~~ The volatile keyword addition helps and additionally assures us the compiler will not optimize out fixed assignments. Signed-off-by: Daniel Kiper --- grub-core/commands/i386/pc/sendkey.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/grub-core/commands/i386/pc/sendkey.c b/grub-core/commands/i386/pc/sendkey.c index 26d9acd3d..ab4bca9e9 100644 --- a/grub-core/commands/i386/pc/sendkey.c +++ b/grub-core/commands/i386/pc/sendkey.c @@ -220,8 +220,8 @@ grub_sendkey_postboot (void) *flags = oldflags; - *((char *) 0x41a) = 0x1e; - *((char *) 0x41c) = 0x1e; + *((volatile char *) 0x41a) = 0x1e; + *((volatile char *) 0x41c) = 0x1e; return GRUB_ERR_NONE; } @@ -236,8 +236,8 @@ grub_sendkey_preboot (int noret __attribute__ ((unused))) oldflags = *flags; /* Set the sendkey. */ - *((char *) 0x41a) = 0x1e; - *((char *) 0x41c) = keylen + 0x1e; + *((volatile char *) 0x41a) = 0x1e; + *((volatile char *) 0x41c) = keylen + 0x1e; grub_memcpy ((char *) 0x41e, sendkey, 0x20); /* Transform "any ctrl" to "right ctrl" flag. */ -- 2.11.0