All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Mingbao Sun <sunmingbao@tom.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Eric Dumazet <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, tyler.sun@dell.com, ping.gan@dell.com,
	yanxiu.cai@dell.com, libin.zhang@dell.com, ao.sun@dell.com
Subject: Re: [PATCH 1/3] tcp: export symbol tcp_set_congestion_control
Date: Fri, 11 Mar 2022 08:13:19 +0100	[thread overview]
Message-ID: <20220311071319.GA18222@lst.de> (raw)
In-Reply-To: <20220311030113.73384-2-sunmingbao@tom.com>

Maybe add a kerneldoc comment now that this is an exported API?

Otherwise this looks fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>


  reply	other threads:[~2022-03-11  7:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  3:01 [PATCH 0/3] NVMe/TCP: support specifying the congestion-control Mingbao Sun
2022-03-11  3:01 ` [PATCH 1/3] tcp: export symbol tcp_set_congestion_control Mingbao Sun
2022-03-11  7:13   ` Christoph Hellwig [this message]
2022-03-11  8:39     ` Mingbao Sun
2022-03-11  3:01 ` [PATCH 2/3] nvme-tcp: support specifying the congestion-control Mingbao Sun
2022-03-11  7:15   ` Christoph Hellwig
2022-03-11  8:47     ` Mingbao Sun
2022-03-11  3:01 ` [PATCH 3/3] nvmet-tcp: " Mingbao Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220311071319.GA18222@lst.de \
    --to=hch@lst.de \
    --cc=ao.sun@dell.com \
    --cc=axboe@fb.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=libin.zhang@dell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=ping.gan@dell.com \
    --cc=sagi@grimberg.me \
    --cc=sunmingbao@tom.com \
    --cc=tyler.sun@dell.com \
    --cc=yanxiu.cai@dell.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.