From: Luben Tuikov <luben.tuikov@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Alex Deucher <Alexander.Deucher@amd.com>,
Tom StDenis <tom.stdenis@amd.com>,
Luben Tuikov <luben.tuikov@amd.com>
Subject: [PATCH v1 1/4] umr: Print errors to stderr
Date: Fri, 11 Mar 2022 19:52:03 -0500 [thread overview]
Message-ID: <20220312005206.26588-1-luben.tuikov@amd.com> (raw)
Print the following error message,
Invalid gca config data header
to stderr, since printing it to stdout,
confuses parser scripts.
Also modify this message to be clearer. For instance,
Invalid or unknown GCA config data header version:4
Cc: Alex Deucher <Alexander.Deucher@amd.com>
Cc: Tom StDenis <tom.stdenis@amd.com>
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
Reviewed-by: Tom StDenis <tom.stdenis@amd.com>
---
src/lib/scan_config.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/lib/scan_config.c b/src/lib/scan_config.c
index c7f4e9d3c69faa..6dd752a1149754 100644
--- a/src/lib/scan_config.c
+++ b/src/lib/scan_config.c
@@ -122,7 +122,7 @@ static uint64_t read_int_drm(int cardno, char *fname)
}
/**
- * umr_scan_config - Scan the debugfs confiruration data
+ * umr_scan_config - Scan the debugfs configuration data
*/
int umr_scan_config(struct umr_asic *asic, int xgmi_scan)
{
@@ -246,7 +246,8 @@ gca_config:
case 4: parse_rev4(asic, data, &r);
break;
default:
- printf("Invalid gca config data header\n");
+ asic->err_msg("Invalid or unknown GCA config data header version:%d\n",
+ data[0]);
return -1;
}
base-commit: 818bb1e8f1b5a26fda0e3d7abfc1e68605ebad28
--
2.35.1.291.gdab1b7905d
next reply other threads:[~2022-03-12 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 0:52 Luben Tuikov [this message]
2022-03-12 0:52 ` [PATCH v1 2/4] umr: Fix ring-stream segmentation fault Luben Tuikov
2022-03-12 0:52 ` [PATCH v1 3/4] umr: Consistent indentation in switch Luben Tuikov
2022-03-12 0:52 ` [PATCH v1 4/4] umr: Fix unhandled enumeration value " Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220312005206.26588-1-luben.tuikov@amd.com \
--to=luben.tuikov@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=tom.stdenis@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.