All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adham Masarwah <adham@nvidia.com>
To: <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <talshn@nvidia.com>, <tamerh@nvidia.com>,
	<idanhac@nvidia.com>, <dmitry.kozliuk@gmail.com>,
	<stable@dpdk.org>
Subject: [PATCH v3] app/testpmd: fix show RSS RETA on Windows
Date: Sun, 13 Mar 2022 14:57:02 +0200	[thread overview]
Message-ID: <20220313125702.11884-1-adham@nvidia.com> (raw)
In-Reply-To: <20220310175023.2552-1-adham@nvidia.com>

Replaced using strtoul with strtoull when converting to
64-bit mask field.
In Windows strtoul returns 32-bit values which cause an
issue with show RSS RETA.

Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table")
Cc: stable@dpdk.org

Signed-off-by: Adham Masarwah <adham@nvidia.com>
Acked-by: Aman Singh <aman.deep.singh@intel.com>
--
v2: Change commit message
v3: Added Acked-by
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b4ba8da2b0..efa02bd301 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3127,7 +3127,7 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf,
 		return -1;
 	}
 	for (i = 0; i < ret; i++)
-		conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0);
+		conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0);
 
 	return 0;
 }
-- 
2.16.1.windows.4


  parent reply	other threads:[~2022-03-13 12:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 17:50 [PATCH] app/testpmd: fixed using strtoull with 64-bit variables Adham Masarwah
2022-03-10 17:50 ` Adham Masarwah
2022-03-11  9:40   ` Singh, Aman Deep
2022-03-14 20:25     ` Thomas Monjalon
2022-03-13 12:45 ` [PATCH v2] app/testpmd: fix show RSS RETA on Windows Adham Masarwah
2022-03-13 12:57 ` Adham Masarwah [this message]
2022-03-13 13:21   ` [PATCH v3] " Tal Shnaiderman
2022-03-14 20:27     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220313125702.11884-1-adham@nvidia.com \
    --to=adham@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=idanhac@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=talshn@nvidia.com \
    --cc=tamerh@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.