Re: [PATCH 3/3] firmware: stratix10-svc: add new FCS commands

[kernel test robot <lkp@intel.com>]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.17-rc8]
[cannot apply to next-20220310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/tien-sung-ang-intel-com/firmware-stratix10-svc-Add-new-FCS-support/20220314-102938
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2c271fe77d52a0555161926c232cd5bc07178b39
config: h8300-allyesconfig (https://download.01.org/0day-ci/archive/20220314/202203141217.H2LzQEuO-lkp@intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/21427534c2a95b30f967d178ee997d8ca94b34e6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review tien-sung-ang-intel-com/firmware-stratix10-svc-Add-new-FCS-support/20220314-102938
        git checkout 21427534c2a95b30f967d178ee997d8ca94b34e6
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/net/ethernet/stmicro/stmmac/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/mfd/altera-sysmgr.h:13,
                    from drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:7:
   include/linux/firmware/intel/stratix10-smc.h:406:12: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'INTEL_SIP_SMC_SERVICE_COMPLETED'
     406 |  * Request INTEL_SIP_SMC_SERVICE_COMPLETED
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/firmware/intel/stratix10-smc.h:406:12: error: unknown type name 'INTEL_SIP_SMC_SERVICE_COMPLETED'
   In file included from drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:7:
>> include/linux/mfd/altera-sysmgr.h:22:45: warning: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration
      22 | altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np,
         |                                             ^~~~~~~~~~~
   In file included from include/linux/err.h:5,
                    from include/linux/mfd/altera-sysmgr.h:11,
                    from drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:7:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   include/asm-generic/page.h:89:51: warning: ordered comparison of pointer with null pointer [-Wextra]
      89 | #define virt_addr_valid(kaddr)  (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                   ^~
   include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
      78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   include/linux/scatterlist.h:160:9: note: in expansion of macro 'BUG_ON'
     160 |         BUG_ON(!virt_addr_valid(buf));
         |         ^~~~~~
   include/linux/scatterlist.h:160:17: note: in expansion of macro 'virt_addr_valid'
     160 |         BUG_ON(!virt_addr_valid(buf));
         |                 ^~~~~~~~~~~~~~~
   drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c: In function 'socfpga_dwmac_parse_data':
   drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:113:54: error: passing argument 1 of 'altr_sysmgr_regmap_lookup_by_phandle' from incompatible pointer type [-Werror=incompatible-pointer-types]
     113 |                 altr_sysmgr_regmap_lookup_by_phandle(np, "altr,sysmgr-syscon");
         |                                                      ^~
         |                                                      |
         |                                                      struct device_node *
   In file included from drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:7:
   include/linux/mfd/altera-sysmgr.h:22:58: note: expected 'struct device_node *' but argument is of type 'struct device_node *'
      22 | altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np,
         |                                      ~~~~~~~~~~~~~~~~~~~~^~
   cc1: some warnings being treated as errors


vim +22 include/linux/mfd/altera-sysmgr.h

f36e789a1f8d0b Thor Thayer 2019-03-11  10  
f36e789a1f8d0b Thor Thayer 2019-03-11  11  #include <linux/err.h>
f36e789a1f8d0b Thor Thayer 2019-03-11  12  #include <linux/errno.h>
f36e789a1f8d0b Thor Thayer 2019-03-11 @13  #include <linux/firmware/intel/stratix10-smc.h>
f36e789a1f8d0b Thor Thayer 2019-03-11  14  
f36e789a1f8d0b Thor Thayer 2019-03-11  15  struct device_node;
f36e789a1f8d0b Thor Thayer 2019-03-11  16  
f36e789a1f8d0b Thor Thayer 2019-03-11  17  #ifdef CONFIG_MFD_ALTERA_SYSMGR
f36e789a1f8d0b Thor Thayer 2019-03-11  18  struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np,
f36e789a1f8d0b Thor Thayer 2019-03-11  19  						    const char *property);
f36e789a1f8d0b Thor Thayer 2019-03-11  20  #else
f36e789a1f8d0b Thor Thayer 2019-03-11  21  static inline struct regmap *
f36e789a1f8d0b Thor Thayer 2019-03-11 @22  altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np,
f36e789a1f8d0b Thor Thayer 2019-03-11  23  				     const char *property)
f36e789a1f8d0b Thor Thayer 2019-03-11  24  {
f36e789a1f8d0b Thor Thayer 2019-03-11  25  	return ERR_PTR(-ENOTSUPP);
f36e789a1f8d0b Thor Thayer 2019-03-11  26  }
f36e789a1f8d0b Thor Thayer 2019-03-11  27  #endif
f36e789a1f8d0b Thor Thayer 2019-03-11  28  

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org