All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [toke:xdp-queueing-03 7/9] net/core/filter.c:9794:0: warning: Invalid number of character '(' when no macros are defined. [syntaxError]
Date: Mon, 14 Mar 2022 12:12:15 +0800	[thread overview]
Message-ID: <202203141234.HSgcZuUe-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 10317 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Kumar Kartikeya Dwivedi <memxor@gmail.com>
CC: "Toke Høiland-Jørgensen" <toke@redhat.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git xdp-queueing-03
head:   fc2f0f778f386a279e545a0fd75649f84b53a870
commit: bcfe29d7ce34000d68e17c027cda99aab5d96e44 [7/9] bpf: Enable direct packet access for dequeue packets
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
compiler: microblaze-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when no macros are defined. [syntaxError]
   
   ^
>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when these macros are defined: 'CONFIG_CGROUPS'. [syntaxError]
   
   ^
>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when these macros are defined: 'CONFIG_CGROUP_NET_CLASSID'. [syntaxError]
   
   ^
>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when these macros are defined: 'CONFIG_NET_CLS_ACT'. [syntaxError]
   
   ^
>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when these macros are defined: 'CONFIG_NET_RX_BUSY_POLL'. [syntaxError]
   
   ^
>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when these macros are defined: 'CONFIG_NET_SCHED'. [syntaxError]
   
   ^
>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when these macros are defined: 'CONFIG_SOCK_CGROUP_DATA'. [syntaxError]
   
   ^
>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when these macros are defined: 'CONFIG_SOCK_RX_QUEUE_MAPPING'. [syntaxError]
   
   ^
>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when these macros are defined: 'CONFIG_XFRM'. [syntaxError]
   
   ^
>> net/core/filter.c:9794:0: warning: Invalid number of character '(' when these macros are defined: 'NET_SKBUFF_DATA_USES_OFFSET'. [syntaxError]
   
   ^

vim +9794 net/core/filter.c

bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9757  
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9758  static u32
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9759  dequeue_convert_xdp_md_access(enum bpf_access_type type,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9760  			      const struct bpf_insn *si, struct bpf_insn *insn_buf,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9761  			      struct bpf_prog *prog, u32 *target_size)
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9762  {
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9763  	struct bpf_insn *insn = insn_buf;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9764  	int src_reg;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9765  
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9766  	switch (si->off) {
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9767  	case offsetof(struct xdp_md, data):
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9768  		/* dst_reg = *(src_reg + off(xdp_frame, data)) */
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9769  		*insn++ = BPF_LDX_MEM(BPF_FIELD_SIZEOF(struct xdp_frame, data),
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9770  				      si->dst_reg, si->src_reg,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9771  				      offsetof(struct xdp_frame, data));
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9772  		break;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9773  	case offsetof(struct xdp_md, data_meta):
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9774  		if (si->dst_reg == si->src_reg) {
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9775  			src_reg = BPF_REG_9;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9776  			if (si->dst_reg == src_reg)
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9777  				src_reg--;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9778  			*insn++ = BPF_STX_MEM(BPF_DW, si->src_reg, src_reg,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9779  					      offsetof(struct xdp_frame, next));
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9780  			*insn++ = BPF_MOV64_REG(src_reg, si->src_reg);
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9781  		} else {
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9782  			src_reg = si->src_reg;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9783  		}
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9784  		/* AX = src_reg
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9785                  * dst_reg = *(src_reg + off(xdp_frame, data))
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9786                  * src_reg = *(src_reg + off(xdp_frame, metasize))
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9787                  * dst_reg -= src_reg
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9788                  * src_reg = AX
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9789                  */
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9790  		*insn++ = BPF_MOV64_REG(BPF_REG_AX, src_reg);
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9791  		*insn++ = BPF_LDX_MEM(BPF_FIELD_SIZEOF(struct xdp_frame, data),
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9792  				      si->dst_reg, src_reg,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9793  				      offsetof(struct xdp_frame, data));
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14 @9794  		*insn++ = BPF_LDX_MEM(BPF_B, /* metasize == 8 bits */
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9795  				      src_reg, src_reg,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9796  		// FIXME: Add BUILD_BUG_ON/make this more generic
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9797  #if defined(__LITTLE_ENDIAN_BITFIELD)
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9798  				      offsetofend(struct xdp_frame, headroom) + 3);
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9799  #elif defined(__BIG_ENDIAN_BITFIELD)
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9800  				      offsetofend(struct xdp_frame, headroom));
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9801  #endif
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9802  		*insn++ = BPF_ALU64_REG(BPF_SUB, si->dst_reg, src_reg);
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9803  		*insn++ = BPF_MOV64_REG(src_reg, BPF_REG_AX);
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9804  		if (si->dst_reg == si->src_reg)
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9805  			*insn++ = BPF_LDX_MEM(BPF_DW, src_reg, si->src_reg,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9806  					      offsetof(struct xdp_frame, next));
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9807  		break;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9808  	case offsetof(struct xdp_md, data_end):
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9809  		if (si->dst_reg == si->src_reg) {
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9810  			src_reg = BPF_REG_9;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9811  			if (si->dst_reg == src_reg)
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9812  				src_reg--;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9813  			*insn++ = BPF_STX_MEM(BPF_DW, si->src_reg, src_reg,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9814  					      offsetof(struct xdp_frame, next));
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9815  			*insn++ = BPF_MOV64_REG(src_reg, si->src_reg);
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9816  		} else {
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9817  			src_reg = si->src_reg;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9818  		}
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9819  		/* AX = src_reg
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9820                  * dst_reg = *(src_reg + off(xdp_frame, data))
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9821                  * src_reg = *(src_reg + off(xdp_frame, len))
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9822                  * dst_reg += src_reg
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9823                  * src_reg = AX
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9824                  */
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9825  		*insn++ = BPF_MOV64_REG(BPF_REG_AX, src_reg);
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9826  		*insn++ = BPF_LDX_MEM(BPF_FIELD_SIZEOF(struct xdp_frame, data),
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9827  				      si->dst_reg, src_reg,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9828  				      offsetof(struct xdp_frame, data));
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9829  		// FIXME: Add BUILD_BUG_ON/make this more generic
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9830  		*insn++ = BPF_LDX_MEM(BPF_H, src_reg, src_reg,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9831  				      offsetof(struct xdp_frame, len));
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9832  		*insn++ = BPF_ALU64_REG(BPF_ADD, si->dst_reg, src_reg);
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9833  		*insn++ = BPF_MOV64_REG(src_reg, BPF_REG_AX);
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9834  		if (si->dst_reg == si->src_reg)
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9835  			*insn++ = BPF_LDX_MEM(BPF_DW, src_reg, si->src_reg,
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9836  					      offsetof(struct xdp_frame, next));
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9837  		break;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9838  	}
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9839  	return insn - insn_buf;
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9840  }
bcfe29d7ce3400 Kumar Kartikeya Dwivedi 2022-02-14  9841  

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

                 reply	other threads:[~2022-03-14  4:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202203141234.HSgcZuUe-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.