From: Tom Rini <trini@konsulko.com>
To: Sean Anderson <sean.anderson@seco.com>
Cc: Simon Glass <sjg@chromium.org>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Oleh Kravchenko <oleg@kaa.org.ua>
Subject: Re: [PATCH 2/2] Add option to use -Og
Date: Mon, 14 Mar 2022 11:46:56 -0400 [thread overview]
Message-ID: <20220314154656.GA9986@bill-the-cat> (raw)
In-Reply-To: <ef7f27e8-2a68-6135-2675-539630296b89@seco.com>
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On Mon, Mar 14, 2022 at 11:36:54AM -0400, Sean Anderson wrote:
>
>
> On 3/11/22 9:25 PM, Simon Glass wrote:
> > On Tue, 22 Feb 2022 at 10:20, Sean Anderson <sean.anderson@seco.com> wrote:
> >>
> >> This adds support for using -Og when building U-Boot. According to the
> >> gcc man page:
> >>
> >> > -Og should be the optimization level of choice for the standard
> >> > edit-compile-debug cycle, offering a reasonable level of optimization
> >> > while maintaining fast compilation and a good debugging experience.
> >>
> >> This optimization level is roughly -O1 minus a few additional
> >> optimizations. It provides a noticably better debugging experience, with
> >> many fewer variables <optimized out>.
> >>
> >> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> >> ---
> >>
> >> Kconfig | 6 ++++++
> >> Makefile | 4 ++++
> >> 2 files changed, 10 insertions(+)
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> > But how about an update in doc/ ?
>
> What should be updated? As far as I can tell, optimization level is not
> otherwise documented. IMO the Kconfig does a reasonable job of
> documentation.
A follow-up to note somewhere under doc/ about this would be good. I'll
pick up the series for next soon.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-03-14 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 17:19 [PATCH 1/2] Split CONFIG_CC_OPTIMIZE_FOR_SIZE into two configs Sean Anderson
2022-02-22 17:19 ` [PATCH 2/2] Add option to use -Og Sean Anderson
2022-03-12 2:25 ` Simon Glass
2022-03-14 15:36 ` Sean Anderson
2022-03-14 15:46 ` Tom Rini [this message]
2022-03-26 2:46 ` Tom Rini
2022-03-12 2:25 ` [PATCH 1/2] Split CONFIG_CC_OPTIMIZE_FOR_SIZE into two configs Simon Glass
2022-03-26 2:46 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314154656.GA9986@bill-the-cat \
--to=trini@konsulko.com \
--cc=oleg@kaa.org.ua \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.