From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DC5AC433EF for ; Mon, 14 Mar 2022 18:31:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6EFF383282; Mon, 14 Mar 2022 19:31:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Oofg+UWc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 59F3183B63; Mon, 14 Mar 2022 19:31:51 +0100 (CET) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 45B3483282 for ; Mon, 14 Mar 2022 19:31:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id q194so13547012qke.5 for ; Mon, 14 Mar 2022 11:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bbsHXZqvSi7yO7uPcXEVu6iIF11LGqe5mgGk04i9uBU=; b=Oofg+UWcFWFATinvuP23XUuGqHVU9LEGcyEAMi70jSoa3ELIeHgjmjkYvRZEUf5/JE 0By4IHZMckDDlMnlFJ1kLB7mhJ4Gw+0Es88G9MvSPonMyXFplM1OI9H4395Tzq0KWLoA BmBIpBV9s6xoZzba7TOUlMf6S3E8VyZFplDrU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bbsHXZqvSi7yO7uPcXEVu6iIF11LGqe5mgGk04i9uBU=; b=qGY46UuzgNyKa2ft1h88KcjejHkWaI+y/tfpbPcu2zOM9/cATiwN43OltmRNA6akOe C+uGpold8ZG6KJKr1YpRNSfeNqeo9R2h3sO5pHMQbpbDb3d5eBBWYNtV/A7t/m0+/NxY B5RRtdqmkslrORLvoGce11qwvUE8lqNmkUQwU3XCTSqlZXlB/2XdQ74iJLdkiJkKGwYR wKUelVanQIDhTcnTVoc/9TcVAx/FwVfZ1Rvo+vSEWtJ0fJkrBpi9bSlyHqqL1uQN4T5F oO0fLCIKI7hMMFN0oyUvvw9BPGfWtsoD3Rx5bvKvh/LsGy9H4v+hsjfFiIaC1JWDkC/o F+nA== X-Gm-Message-State: AOAM530jptGwPlrtWvxtKVUVHq7vsb5Moz50gqjIX8McXVsghjPXwL+B h5xegT/oDmpOhdGL2IoeHJUxZQ== X-Google-Smtp-Source: ABdhPJzgDZQ1ziLl2TJBLlSgctL11vPx7iElGZC4Ps4DNVwhkjthWbSkucJeEL6++fV4dlnnIcvG5w== X-Received: by 2002:a37:485:0:b0:67b:3bd:e14d with SMTP id 127-20020a370485000000b0067b03bde14dmr15462663qke.645.1647282706076; Mon, 14 Mar 2022 11:31:46 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id v9-20020a05620a0a8900b0067db9cc46a9sm2518989qkg.62.2022.03.14.11.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 11:31:45 -0700 (PDT) Date: Mon, 14 Mar 2022 14:31:43 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , AKASHI Takahiro , Heinrich Schuchardt , Patrick Delaunay , Wolfgang Denk Subject: Re: [PATCH 1/5] disk: Add an option for partitions in SPL Message-ID: <20220314183143.GM9986@bill-the-cat> References: <20220311191005.364540-1-sjg@chromium.org> <20220311191005.364540-2-sjg@chromium.org> <20220314124944.GD9986@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="796bG6sDp7z5YuPV" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --796bG6sDp7z5YuPV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 14, 2022 at 12:24:41PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 14 Mar 2022 at 06:49, Tom Rini wrote: > > > > On Fri, Mar 11, 2022 at 12:10:01PM -0700, Simon Glass wrote: > > > > > In some cases we do not want to enable partition support in SPL. Add = an > > > option to allow this. > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > disk/Kconfig | 24 ++++++++++++++++++++---- > > > disk/Makefile | 6 +++--- > > > drivers/block/blk-uclass.c | 2 +- > > > 3 files changed, 24 insertions(+), 8 deletions(-) > > > > I'm not sure this makes sense? I thought when I looked in to this last > > the only place where we had partition code being linked and not > > discarded in the case of SPL and no devices that would have partitions > > on them was one xilinx platform. How do we get to bringing in partition > > code and not having something that uses it? >=20 > The problem is that drivers are not discarded and Takahiro's series > adds a driver for partitions. >=20 > So yes, we were able to get away with this before, but cannot now. Things which aren't needed / used need to be discarded. So we might have use cases for this, yes (I was thinking after I sent that OK, yes, imx probably tends to not need partition support since we read at raw offsets, outside from maybe falcon mode using targets). But we shouldn't generally be now pulling in drivers that aren't functionally used. --=20 Tom --796bG6sDp7z5YuPV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIvig8ACgkQFHw5/5Y0 tyxXpAv/V9XP39dW04JGy+iFuDCMVgBXSwTXpYyFjbY0uhSWLrlX4SYuVWfMYuy9 AjJ2c4+L/vl7b3rosSJIbGxrinJB/xhA6UxFjDUUbJcpiLpYBLMebNA3u2AOiLz1 oM3F8PVq96ho7NJwJ35RyTVKgeMs/rgO1iOXRUAVkIj7uvzY/CBohEmcDugRaUP7 I2SSkkDIjqOaX9JxmYwJ0NNIAnoixutmDwrNAt/ZmhZEsqTRohqk1omHTXqZcAfy adkM/Ep6yo+GLupUa/6v38OKAjJQ7UeSp8ApzpPFF22cGI1NYD2dyWzr3XkVXa8Z 6qmLIntcImjvlqA4f0IszowCkOKUDT+Lghs4lFDJeOmofYB30Q3ifZNJDb3E1Imf uAssDODR0+RF7TcIQf7/DQ/jaGpI4ecVMdDWnj5oLoUXSwHZFc+M1CmYUnnZbj0I r97rypUNbQCbqRzuaUwky3/W2WQJMDM/1wGKbF4yKJI0Iebn9WhkwlYV7jW6JWYm UkTnX1ie =qBtV -----END PGP SIGNATURE----- --796bG6sDp7z5YuPV--