From: Jason Gunthorpe <jgg@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mustafa Ismail <mustafa.ismail@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/irdma: prevent some integer underflows
Date: Mon, 14 Mar 2022 20:44:00 -0300 [thread overview]
Message-ID: <20220314234400.GA172564@nvidia.com> (raw)
In-Reply-To: <20220307125928.GE16710@kili>
On Mon, Mar 07, 2022 at 03:59:28PM +0300, Dan Carpenter wrote:
> My static checker complains that:
>
> drivers/infiniband/hw/irdma/ctrl.c:3605 irdma_sc_ceq_init()
> warn: can subtract underflow 'info->dev->hmc_fpm_misc.max_ceqs'?
>
> It appears that "info->dev->hmc_fpm_misc.max_ceqs" comes from the
> firmware in irdma_sc_parse_fpm_query_buf() so, yes, there is a chance
> that it could be zero. Even if we trust the firmware, it's easy enough
> to change the condition just as a hardenning measure.
>
> Fixes: 3f49d6842569 ("RDMA/irdma: Implement HW Admin Queue OPs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/irdma/ctrl.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2022-03-14 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 12:59 [PATCH] RDMA/irdma: prevent some integer underflows Dan Carpenter
2022-03-08 16:45 ` Saleem, Shiraz
2022-03-14 23:44 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314234400.GA172564@nvidia.com \
--to=jgg@nvidia.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.