From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 967ADC433F5 for ; Tue, 15 Mar 2022 05:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232198AbiCOGA5 (ORCPT ); Tue, 15 Mar 2022 02:00:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239667AbiCOGA5 (ORCPT ); Tue, 15 Mar 2022 02:00:57 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05B9E47383 for ; Mon, 14 Mar 2022 22:59:46 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nU0DY-0003jT-7Y; Tue, 15 Mar 2022 06:59:36 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nU0DX-00084U-A8; Tue, 15 Mar 2022 06:59:35 +0100 Date: Tue, 15 Mar 2022 06:59:35 +0100 From: Oleksij Rempel To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Ian Dannapel , linux@rempel-privat.de, Erik.Schumacher@iris-sensing.com, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, Michael.Glembotzki@iris-sensing.com, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH] i2c: imx: remove unnecessary delay at startup Message-ID: <20220315055935.GB14588@pengutronix.de> References: <20220314095918.50014-1-iansdannapel@gmail.com> <20220314101337.4x2cu3nvg2vg7ulh@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220314101337.4x2cu3nvg2vg7ulh@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 06:57:18 up 94 days, 14:42, 65 users, load average: 0.06, 0.09, 0.09 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i2c@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, Mar 14, 2022 at 11:13:37AM +0100, Uwe Kleine-König wrote: > Hello, > > On Mon, Mar 14, 2022 at 10:59:18AM +0100, Ian Dannapel wrote: > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > > index 3576b63a6c03..019dda5301df 100644 > > --- a/drivers/i2c/busses/i2c-imx.c > > +++ b/drivers/i2c/busses/i2c-imx.c > > @@ -602,12 +602,6 @@ static int i2c_imx_start(struct imx_i2c_struct *i2c_imx, bool atomic) > > imx_i2c_write_reg(i2c_imx->hwdata->i2sr_clr_opcode, i2c_imx, IMX_I2C_I2SR); > > imx_i2c_write_reg(i2c_imx->hwdata->i2cr_ien_opcode, i2c_imx, IMX_I2C_I2CR); > > > > - /* Wait controller to be stable */ > > - if (atomic) > > - udelay(50); > > - else > > - usleep_range(50, 150); > > - > > /* Start I2C transaction */ > > temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR); > > temp |= I2CR_MSTA; > > This contradicts statements made in > 43309f3b521302bb66c4c9e66704dd3675e4d725. > > Maybe the sleep/delay should be done conditionally on the busy bit? Maybe. I do not see what exact problem is this sleep addressing. How exact the can get stable? Is it addressing some clock issue or wading until something happening on the bus? Regards, Oleskij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C29EFC433EF for ; Tue, 15 Mar 2022 06:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6cpcb+Rb+0Y0wTCvZkokWHK5hA01pFr5h+NxcExPn9s=; b=xIunFKlngdWsvl H2OIFsxb+lA2PDQkYY4GpWRKg7WGy80LmMVttS5MYjCdyUKFRPhq4s2Dt166zme3sdGszCIlOQ5q2 Zbev3RJnYyu40qbBuwFm/05YotH/mCCDPn/hZ7UdLirQZRKeKhQX0w2CHVgU+Jinl2MOTQLcCpX6j lADtXOJV7TeADFWqU/j7j8SFUf04Xt1yghHWawpUGhDeGCwAx7maJYAko0dQoz7XHqwxDdq2HkcG+ mB3VnA8SGSUuvY+ngBZ8JtUbvHMByZUlyvNYLJQ/05gziQs5XaodS3oJi73wM3HP/CuALRADrSh2c lkMbXAl+g41veLNzLMfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU0Dj-007tBP-9b; Tue, 15 Mar 2022 05:59:47 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU0Df-007tAS-Po for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 05:59:45 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nU0DY-0003jT-7Y; Tue, 15 Mar 2022 06:59:36 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nU0DX-00084U-A8; Tue, 15 Mar 2022 06:59:35 +0100 Date: Tue, 15 Mar 2022 06:59:35 +0100 From: Oleksij Rempel To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Ian Dannapel , linux@rempel-privat.de, Erik.Schumacher@iris-sensing.com, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, Michael.Glembotzki@iris-sensing.com, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH] i2c: imx: remove unnecessary delay at startup Message-ID: <20220315055935.GB14588@pengutronix.de> References: <20220314095918.50014-1-iansdannapel@gmail.com> <20220314101337.4x2cu3nvg2vg7ulh@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220314101337.4x2cu3nvg2vg7ulh@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 06:57:18 up 94 days, 14:42, 65 users, load average: 0.06, 0.09, 0.09 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220314_225943_878293_0BEB77EC X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMTQsIDIwMjIgYXQgMTE6MTM6MzdBTSArMDEwMCwgVXdlIEtsZWluZS1Lw7Zu aWcgd3JvdGU6Cj4gSGVsbG8sCj4gCj4gT24gTW9uLCBNYXIgMTQsIDIwMjIgYXQgMTA6NTk6MThB TSArMDEwMCwgSWFuIERhbm5hcGVsIHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaTJj L2J1c3Nlcy9pMmMtaW14LmMgYi9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWlteC5jCj4gPiBpbmRl eCAzNTc2YjYzYTZjMDMuLjAxOWRkYTUzMDFkZiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvaTJj L2J1c3Nlcy9pMmMtaW14LmMKPiA+ICsrKyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtaW14LmMK PiA+IEBAIC02MDIsMTIgKzYwMiw2IEBAIHN0YXRpYyBpbnQgaTJjX2lteF9zdGFydChzdHJ1Y3Qg aW14X2kyY19zdHJ1Y3QgKmkyY19pbXgsIGJvb2wgYXRvbWljKQo+ID4gIAlpbXhfaTJjX3dyaXRl X3JlZyhpMmNfaW14LT5od2RhdGEtPmkyc3JfY2xyX29wY29kZSwgaTJjX2lteCwgSU1YX0kyQ19J MlNSKTsKPiA+ICAJaW14X2kyY193cml0ZV9yZWcoaTJjX2lteC0+aHdkYXRhLT5pMmNyX2llbl9v cGNvZGUsIGkyY19pbXgsIElNWF9JMkNfSTJDUik7Cj4gPiAgCj4gPiAtCS8qIFdhaXQgY29udHJv bGxlciB0byBiZSBzdGFibGUgKi8KPiA+IC0JaWYgKGF0b21pYykKPiA+IC0JCXVkZWxheSg1MCk7 Cj4gPiAtCWVsc2UKPiA+IC0JCXVzbGVlcF9yYW5nZSg1MCwgMTUwKTsKPiA+IC0KPiA+ICAJLyog U3RhcnQgSTJDIHRyYW5zYWN0aW9uICovCj4gPiAgCXRlbXAgPSBpbXhfaTJjX3JlYWRfcmVnKGky Y19pbXgsIElNWF9JMkNfSTJDUik7Cj4gPiAgCXRlbXAgfD0gSTJDUl9NU1RBOwo+IAo+IFRoaXMg Y29udHJhZGljdHMgc3RhdGVtZW50cyBtYWRlIGluCj4gNDMzMDlmM2I1MjEzMDJiYjY2YzRjOWU2 NjcwNGRkMzY3NWU0ZDcyNS4KPiAKPiBNYXliZSB0aGUgc2xlZXAvZGVsYXkgc2hvdWxkIGJlIGRv bmUgY29uZGl0aW9uYWxseSBvbiB0aGUgYnVzeSBiaXQ/CgpNYXliZS4gSSBkbyBub3Qgc2VlIHdo YXQgZXhhY3QgcHJvYmxlbSBpcyB0aGlzIHNsZWVwIGFkZHJlc3NpbmcuIEhvdwpleGFjdCB0aGUg Y2FuIGdldCBzdGFibGU/IElzIGl0IGFkZHJlc3Npbmcgc29tZSBjbG9jayBpc3N1ZSBvciB3YWRp bmcKdW50aWwgc29tZXRoaW5nIGhhcHBlbmluZyBvbiB0aGUgYnVzPwoKUmVnYXJkcywKT2xlc2tp agotLSAKUGVuZ3V0cm9uaXggZS5LLiAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwKU3RldWVyd2FsZGVyIFN0ci4gMjEgICAgICAgICAgICAg ICAgICAgICAgIHwgaHR0cDovL3d3dy5wZW5ndXRyb25peC5kZS8gIHwKMzExMzcgSGlsZGVzaGVp bSwgR2VybWFueSAgICAgICAgICAgICAgICAgIHwgUGhvbmU6ICs0OS01MTIxLTIwNjkxNy0wICAg IHwKQW10c2dlcmljaHQgSGlsZGVzaGVpbSwgSFJBIDI2ODYgICAgICAgICAgIHwgRmF4OiAgICs0 OS01MTIxLTIwNjkxNy01NTU1IHwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK