From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4266700736507522621==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: misc: fix minmax.cocci warnings Date: Tue, 15 Mar 2022 17:06:06 +0800 Message-ID: <20220315090606.GA18422@1dfdb75c0ac8> In-Reply-To: <202203151730.fICoWvQR-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4266700736507522621== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org BCC: lkp(a)intel.com CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: Alasdair Kergon CC: Mike Snitzer CC: dm-devel(a)redhat.com CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/md/dm-raid.c:3218:44-45: WARNING opportunity for min() Check for opencoded min(), max() implementations. Generated patches sometimes require adding a cast to fix compile warning. Warnings/patches scope intentionally limited to a function body. Generated by: scripts/coccinelle/misc/minmax.cocci CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 09688c0166e76ce2fb85e86b9d99be8b0084cdf9 commit: 5f66f73b9ff4dcabd4e2405ba9c32e80e02f9408 coccinelle: misc: add minm= ax script :::::: branch date: 2 days ago :::::: commit date: 11 months ago Please take the patch only if it's a positive warning. Thanks! drivers/md/dm-raid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -3215,7 +3215,8 @@ size_check: if (r) goto bad; = - rs_setup_recovery(rs, rs->md.recovery_cp < rs->md.dev_sectors ? rs->md.= recovery_cp : rs->md.dev_sectors); + rs_setup_recovery(rs, + min(rs->md.recovery_cp, rs->md.dev_sectors)); } else { /* This is no size change or it is shrinking, update size and record in= superblocks */ r =3D rs_set_dev_and_array_sectors(rs, rs->ti->len, false); --===============4266700736507522621==--