All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Xiao Yang <yangx.jy@fujitsu.com>
Cc: linux-rdma@vger.kernel.org, yanjun.zhu@linux.dev,
	rpearsonhpe@gmail.com, y-goto@fujitsu.com, lizhijian@fujitsu.com,
	tomasz.gromadzki@intel.com, tom@talpey.com, ira.weiny@intel.com
Subject: Re: [PATCH v3 3/3] RDMA/rxe: Add RDMA Atomic Write attribute for rxe device
Date: Tue, 15 Mar 2022 15:53:30 -0300	[thread overview]
Message-ID: <20220315185330.GA241071@nvidia.com> (raw)
In-Reply-To: <20220311115247.23521-4-yangx.jy@fujitsu.com>

On Fri, Mar 11, 2022 at 07:52:47PM +0800, Xiao Yang wrote:

> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index abd1c5d3dc66..580b5cacec09 100644
> +++ b/include/rdma/ib_verbs.h
> @@ -291,6 +291,8 @@ enum ib_device_cap_flags {
>  	/* The device supports padding incoming writes to cacheline. */
>  	IB_DEVICE_PCI_WRITE_END_PADDING		= (1ULL << 36),
>  	IB_DEVICE_ALLOW_USER_UNREG		= (1ULL << 37),
> +	/* Atomic write attributes */
> +	IB_DEVICE_ATOMIC_WRITE			= (1ULL << 40),
>  };

Can you make a patch to clean this up too? The right parts of it need
to get moved to the uapi header and it should work similarly to the
ib_uverbs_wr_opcode / ib_wr_opcode thing.

You'll also need to do something about the 32 bit compatability that
kbuild detected - I suppose this can't work on 32 bit platforms? So
IS_ENABLED() it off or something?

Jason

  reply	other threads:[~2022-03-15 18:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11 11:52 [PATCH v3 0/3] RDMA/rxe: Add RDMA Atomic Write operation Xiao Yang
2022-03-11 11:52 ` [PATCH v3 1/3] RDMA/rxe: Rename send_atomic_ack() and atomic member of struct resp_res Xiao Yang
2022-03-11 11:52 ` [PATCH v3 2/3] RDMA/rxe: Support RDMA Atomic Write operation Xiao Yang
2022-03-11 23:56   ` kernel test robot
2022-03-11 11:52 ` [PATCH v3 3/3] RDMA/rxe: Add RDMA Atomic Write attribute for rxe device Xiao Yang
2022-03-15 18:53   ` Jason Gunthorpe [this message]
2022-03-17  5:58     ` yangx.jy
2022-03-21  3:55     ` yangx.jy
2022-03-21 15:32       ` Jason Gunthorpe
2022-03-25 11:44         ` yangx.jy
2022-03-25 13:22           ` Jason Gunthorpe
2022-03-28 10:07             ` yangx.jy
2022-03-28 11:39               ` Jason Gunthorpe
2022-03-29  2:36                 ` yangx.jy
2022-03-29  2:39                   ` yangx.jy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220315185330.GA241071@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=rpearsonhpe@gmail.com \
    --cc=tom@talpey.com \
    --cc=tomasz.gromadzki@intel.com \
    --cc=y-goto@fujitsu.com \
    --cc=yangx.jy@fujitsu.com \
    --cc=yanjun.zhu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.