From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79937C433EF for ; Tue, 15 Mar 2022 20:01:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 19FE883AC5; Tue, 15 Mar 2022 21:01:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="V7iHuw2T"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 713D583ABE; Tue, 15 Mar 2022 21:01:21 +0100 (CET) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1C19283ABE for ; Tue, 15 Mar 2022 21:01:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82b.google.com with SMTP id 10so147195qtz.11 for ; Tue, 15 Mar 2022 13:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+Q6GuuLW9Z0eLjrr2bbI8BgXg+X36wcAD0jvE9Tl410=; b=V7iHuw2TJISAUCnzZodLvZe83SYOQ8zWTHDTKjZ4Ry6jJLjd1JkH5k70WVm1yibygq C8S178U9kfI0/hoqN7RCGEvuqDgA0ACNLMLU/Gy9aaSBGESzEPITkEYOczJPJC5op2yy Q/rrZOTFZ5zK5vR+myHPOdiNUYW9uiHMwhaW8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+Q6GuuLW9Z0eLjrr2bbI8BgXg+X36wcAD0jvE9Tl410=; b=ADVjnttFhJgmEtGgdxD2e/PiV/rfdGu1053//Ga/EJXs6llgOLTwscamFJIqUuyN4j 0l/0M2EwOgZ9cK8FWymzdjX2y5/qswXaGNE1+jLK71PQGINQfGv0mkjD3XIOXIhzOwvS B17+iwbZ9J8ZxY0sL57nzjupl3oAsIF6rAf4lIDd1cnQTc/asyJRWgoVrHTmgIn81gFz loaDfZBpUYrC1b6iqLGX715L8O6/m+JMPS9r3xKZq6VLWSuoyQ+wGCdjePfP02A1i1Ow a9R1ZqOSqisbYRx9jZODSw4uaJegoSHgVz0inx4i83odn6h7U2E3eeTHzzInZFhru+qh R7bA== X-Gm-Message-State: AOAM5302aWJKOD/IRuETGtp/uEckUyVocVeY9cU361Cyu0rQkpYIo19n jFWPl20YERxc56FUJIMciLLXHw== X-Google-Smtp-Source: ABdhPJzbK4oy+H5hbrm0p0ipRQY4UC2DNYryqG+kkqUoV5dpYPpFhZ69LUQi7zmbL1KaP6VfhEzdAg== X-Received: by 2002:ac8:5787:0:b0:2e1:c837:64ed with SMTP id v7-20020ac85787000000b002e1c83764edmr14134622qta.98.1647374476546; Tue, 15 Mar 2022 13:01:16 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id s7-20020ac85cc7000000b002e1b34b30c9sm11794399qta.75.2022.03.15.13.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 13:01:15 -0700 (PDT) Date: Tue, 15 Mar 2022 16:01:14 -0400 From: Tom Rini To: Troy Kisky Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH v1 0/5] Move board specific files to board directory Message-ID: <20220315200114.GA577378@bill-the-cat> References: <20211217230131.2715940-1-troy.kisky@boundarydevices.com> <20211228131115.GZ2773246@bill-the-cat> <20220107151250.GK2773246@bill-the-cat> <20220208143016.GN7515@bill-the-cat> <15ff0408-7b2f-c892-9239-ed923c835365@boundarydevices.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: <15ff0408-7b2f-c892-9239-ed923c835365@boundarydevices.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 15, 2022 at 12:08:02PM -0700, Troy Kisky wrote: > On 2/8/2022 6:30 AM, Tom Rini wrote: > > On Fri, Jan 07, 2022 at 10:33:34AM -0800, Troy Kisky wrote: > >> On 1/7/2022 7:12 AM, Tom Rini wrote: > >>> On Thu, Jan 06, 2022 at 01:14:40PM -0800, Troy Kisky wrote: > >>>> On 12/28/2021 5:11 AM, Tom Rini wrote: > >>>>> On Tue, Dec 28, 2021 at 01:33:05AM -0700, Simon Glass wrote: > >>>>>> Hi Troy, > >>>>>> > >>>>>> On Fri, 17 Dec 2021 at 16:02, Troy Kisky wrote: > >>>>>>> > >>>>>>> This series intends to let board specific files live in the boards > >>>>>>> directory. The last patch moves files for nitrogen6x. > >>>>>>> I have tested it with buildman > >>>>>>> > >>>>>>> ./tools/buildman/buildman boundary -b denx_master > >>>>>>> > >>>>>>> But it is likely the more scripts then just tools/genboardscfg.py= would > >>>>>>> need to be updated. > >>>>>>> > >>>>>>> Troy Kisky (5): > >>>>>>> kconfig: allow defconfigs to live in board directory > >>>>>>> dts: allow dts files in board directory > >>>>>>> scripts: Makefile.autoconf: allow CONFIG_SYS_CONFIG_NAME file t= o live > >>>>>>> in board directory > >>>>>>> genboardcfg: allow defconfigs in board directory > >>>>>>> nitrogen6x: move board specific files to nitrogen6x directory > >>>>>>> > >>>>>>> arch/arm/dts/Makefile | 3 -- > >>>>>>> board/boundary/nitrogen6x/MAINTAINERS | 13 ------- > >>>>>>> board/boundary/nitrogen6x/Makefile | 13 +++++++ > >>>>>>> .../nitrogen6x}/imx6dl-nitrogen6x.dts | 0 > >>>>>>> .../boundary/nitrogen6x}/imx6q-nitrogen6x.dts | 0 > >>>>>>> .../boundary/nitrogen6x}/imx6q-sabrelite.dts | 0 > >>>>>>> .../nitrogen6x}/imx6qdl-nitrogen6x.dtsi | 0 > >>>>>>> .../nitrogen6x}/imx6qdl-sabrelite.dtsi | 0 > >>>>>>> .../nitrogen6x}/mx6qsabrelite_defconfig | 0 > >>>>>>> .../nitrogen6x}/nitrogen6dl2g_defconfig | 0 > >>>>>>> .../nitrogen6x}/nitrogen6dl_defconfig | 0 > >>>>>>> .../nitrogen6x}/nitrogen6q2g_defconfig | 0 > >>>>>>> .../boundary/nitrogen6x}/nitrogen6q_defconfig | 0 > >>>>>>> .../nitrogen6x}/nitrogen6s1g_defconfig | 0 > >>>>>>> .../boundary/nitrogen6x}/nitrogen6s_defconfig | 0 > >>>>>>> .../boundary/nitrogen6x}/nitrogen6x.h | 2 +- > >>>>>>> dts/Makefile | 11 +++++- > >>>>>>> scripts/Makefile.autoconf | 9 ++++- > >>>>>>> scripts/Makefile.lib | 1 + > >>>>>>> scripts/kconfig/Makefile | 9 ++++- > >>>>>>> tools/genboardscfg.py | 37 +++++++++++++= +++++- > >>>>>>> 21 files changed, 75 insertions(+), 23 deletions(-) > >>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6dl-nitr= ogen6x.dts (100%) > >>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-nitro= gen6x.dts (100%) > >>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-sabre= lite.dts (100%) > >>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-nit= rogen6x.dtsi (100%) > >>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-sab= relite.dtsi (100%) > >>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/mx6qsabrelite_de= fconfig (100%) > >>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl2g_de= fconfig (100%) > >>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl_defc= onfig (100%) > >>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q2g_def= config (100%) > >>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q_defco= nfig (100%) > >>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s1g_def= config (100%) > >>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s_defco= nfig (100%) > >>>>>>> rename {include/configs =3D> board/boundary/nitrogen6x}/nitrogen= 6x.h (98%) I'm not about the goal. > >>>>>> > >>>>>> Can you please add a few notes about the motivation for this chang= e? > >>>>> > >>>>> Sorry for the delayed reply here. I'm also not entirely sure this = is a > >>>>> good idea. Moving the defconfig files? Maybe. It does make check= ing > >>>>> all configs a bit more tricky, but indeed the configs directory is > >>>>> unwieldy. Moving the dts files? Those should be a direct cp from = the > >>>>> kernel, so that makes things less clear to me. Especially since it= will > >>>>> need other common files that will still be elsewhere. > >>>>> > >>>> > >>>> They will still be a direct copy. Notice the 100% rename. Common fil= es still living in the dts > >>>> directory is less clear. I can try to address the "piecemeal buildin= g of .dts files" if this > >>>> still has a chance of being accepted. > >>> > >>> So, here's my worry. Today, in an ideal world that we're not yet at,= I > >>> could do: > >>> 1. cd ~/src/linux; git checkout v5.16 > >>> 2. cd ~/src/u-boot; for DTS in arch/arm/dts/*.dts*; do \ > >>> [ -f ~/src/linux/$DTS ] && cp ~/src/linux/$DTS $DTS; done >=20 > Perhaps we can mimic Linux's arm/arm64 dts split and make the above work = better? Along with making the distinction between what we're mirroring and what we're adding more clear yes, that would be viable I think. --=20 Tom --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIw8IMACgkQFHw5/5Y0 tyyUIQv/frme9648a6Syu2bU+TWxFasD/I+OzwdxyNvJkwazBCIA01IFD8pgpzTv EpNU4QU41OmWWno3nCAhKnJWirscDRQPC/En6tsjPfuR58X02JBhCG48wiEHPI1d YgDbzEKoZLvuYRhiMNy1l5bOroDbMeEZYRnXNNwsueXqGV8UeTakw6IYt7KYPXnH Ywu2iZ3egry34bACrsuuJ6cVZnamefoHiS9YJHtxvG4uJTslUJAW+K+1bpPJzaE+ Rgoq8KD6uA2iswFwpP8Zwl5uAbSI2Z1qsdlYuwSquyZIxMAgaLCQFkQ+Lnxplsxd NdDvzxK4mmsXIAo+hOJWoScBXqUjiq/APrOVpQC90Q31NtWkgDzssJiar4FCboMh 41Z/IIaaKJvIJTE9kKJQXXnrhtOI7VPhPw7lM4OX4BPJl8v96wYzSTau57YtCAIt aCB3h/M9gfv+8Iph4QwsoS3woO0ymp+TbSATmcXE/nSvUO/ykbAECk5326H7zRLI l4VQV0wX =UCqk -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd--