From: Stephen Boyd <sboyd@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rafael J. Wysocki <rafael@kernel.org>
Cc: linux-hyperv@vger.kernel.org, Stuart Yoder <stuyoder@gmail.com>,
"Michael S.Tsirkin" <mst@redhat.com>,
linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org,
alsa-devel@alsa-project.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Jason Wang <"jasow ang"@redhat.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
"K.Y.Srinivasan" <kys@microsoft.com>,
Fabio Estevam <festevam@gmail.com>,
linux-clk@vger.kernel.org, linux-s390@vger.kernel.org,
Wei Liu <wei.liu@kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
Abel Vesa <abel.vesa@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Dexuan Cui <decui@microsoft.com>, Andy Gross <agross@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-arm-msm@vger.kernel.org,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Bjorn Helgaas <bhelgaas@google.com>,
virtualization@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
Sven Schnelle <svens@linux.ibm.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v4 09/11] clk: imx: scu: Fix kfree() of static memory on setting driver_override
Date: Tue, 15 Mar 2022 13:13:19 -0700 [thread overview]
Message-ID: <20220315201321.8AADBC340E8@smtp.kernel.org> (raw)
In-Reply-To: <20220312132856.65163-10-krzysztof.kozlowski@canonical.com>
Quoting Krzysztof Kozlowski (2022-03-12 05:28:54)
> The driver_override field from platform driver should not be initialized
> from static memory (string literal) because the core later kfree() it,
> for example when driver_override is set via sysfs.
>
> Use dedicated helper to set driver_override properly.
>
> Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
next prev parent reply other threads:[~2022-03-17 7:01 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 13:28 [PATCH v4 00/11] Fix broken usage of driver_override (and kfree of static memory) Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` [PATCH v4 01/11] driver: platform: Add helper for safer setting of driver_override Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-15 17:59 ` Andy Shevchenko
2022-03-15 17:59 ` Andy Shevchenko
2022-03-15 17:59 ` Andy Shevchenko
2022-03-15 17:59 ` Andy Shevchenko
2022-03-16 12:13 ` Krzysztof Kozlowski
2022-03-16 12:13 ` Krzysztof Kozlowski
2022-03-16 12:13 ` Krzysztof Kozlowski
2022-03-12 13:28 ` [PATCH v4 02/11] amba: Use driver_set_override() instead of open-coding Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` [PATCH v4 03/11] fsl-mc: " Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` [PATCH v4 04/11] hv: " Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` [PATCH v4 05/11] PCI: " Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-15 18:01 ` Andy Shevchenko
2022-03-15 18:01 ` Andy Shevchenko
2022-03-15 18:01 ` Andy Shevchenko
2022-03-15 18:01 ` Andy Shevchenko
2022-03-12 13:28 ` [PATCH v4 06/11] s390/cio: " Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` [PATCH v4 07/11] spi: Use helper for safer setting of driver_override Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` [PATCH v4 08/11] vdpa: " Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-13 0:18 ` Michael S. Tsirkin
2022-03-13 0:18 ` Michael S. Tsirkin
2022-03-13 0:18 ` Michael S. Tsirkin
2022-03-13 0:18 ` Michael S. Tsirkin
2022-03-16 8:56 ` Michael S. Tsirkin
2022-03-16 8:56 ` Michael S. Tsirkin
2022-03-16 8:56 ` Michael S. Tsirkin
2022-03-16 8:56 ` Michael S. Tsirkin
2022-03-12 13:28 ` [PATCH v4 09/11] clk: imx: scu: Fix kfree() of static memory on setting driver_override Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-15 20:13 ` Stephen Boyd [this message]
2022-03-12 13:28 ` [PATCH v4 10/11] slimbus: qcom-ngd: " Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` [PATCH v4 11/11] rpmsg: " Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-12 13:28 ` Krzysztof Kozlowski
2022-03-13 16:35 ` Bjorn Andersson
2022-03-13 16:35 ` Bjorn Andersson
2022-03-13 16:35 ` Bjorn Andersson
2022-03-13 16:35 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315201321.8AADBC340E8@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc="jasow ang"@redhat.com \
--cc=abel.vesa@nxp.com \
--cc=agordeev@linux.ibm.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=broonie@kernel.org \
--cc=decui@microsoft.com \
--cc=festevam@gmail.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hca@linux.ibm.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kys@microsoft.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=oberpar@linux.ibm.com \
--cc=rafael@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=stuyoder@gmail.com \
--cc=svens@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=vneethv@linux.ibm.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.