All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: "Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Taniya Das" <tdas@codeaurora.org>
Cc: Prasad Malisetty <quic_pmaliset@quicinc.com>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [RFC PATCH 3/5] clk: qcom: gcc-sc7280: use new clk_regmap_mux_safe_ops for PCIe pipe clocks
Date: Tue, 15 Mar 2022 17:07:51 -0700	[thread overview]
Message-ID: <20220316000753.120E1C340E8@smtp.kernel.org> (raw)
In-Reply-To: <20220313000824.229405-4-dmitry.baryshkov@linaro.org>

Quoting Dmitry Baryshkov (2022-03-12 16:08:22)
> Use newly defined clk_regmap_mux_safe_ops for PCIe pipe clocks to let
> the clock framework automatically park the clock when the clock is
> switched off and restore the parent when the clock is switched on.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  drivers/clk/qcom/gcc-sc7280.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c
> index 423627d49719..69887e45d02f 100644
> --- a/drivers/clk/qcom/gcc-sc7280.c
> +++ b/drivers/clk/qcom/gcc-sc7280.c
> @@ -373,13 +373,14 @@ static struct clk_regmap_mux gcc_pcie_0_pipe_clk_src = {
>         .reg = 0x6b054,
>         .shift = 0,
>         .width = 2,
> +       .safe_src_index = 2,

Can this be

	.safe_src_index = gcc_parent_map_6[1].cfg

or something that indicates that this is a value inside the parent map
and not an array index?

  parent reply	other threads:[~2022-03-16  0:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-13  0:08 [RFC PATCH 0/5] PCI: qcom: rework pipe_clk/pipe_clk_src handling Dmitry Baryshkov
2022-03-13  0:08 ` [RFC PATCH 1/5] clk: qcom: regmap-mux: add pipe clk implementation Dmitry Baryshkov
2022-03-13 17:14   ` Bjorn Andersson
2022-03-13  0:08 ` [RFC PATCH 2/5] clk: qcom: gcc-sm8450: use new clk_regmap_mux_safe_ops for PCIe pipe clocks Dmitry Baryshkov
2022-03-13 17:08   ` Bjorn Andersson
2022-03-13  0:08 ` [RFC PATCH 3/5] clk: qcom: gcc-sc7280: " Dmitry Baryshkov
2022-03-13 17:08   ` Bjorn Andersson
2022-03-16  0:07   ` Stephen Boyd [this message]
2022-03-13  0:08 ` [RFC PATCH 4/5] PCI: qcom: Remove unnecessary pipe_clk handling Dmitry Baryshkov
2022-03-13 17:06   ` Bjorn Andersson
2022-03-13  0:08 ` [RFC PATCH 5/5] PCI: qcom: Drop manual pipe_clk_src handling Dmitry Baryshkov
2022-03-13 17:07   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220316000753.120E1C340E8@smtp.kernel.org \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=quic_pmaliset@quicinc.com \
    --cc=tdas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.