Re: [PATCH RFC 2/2] libata: Use scsi cmnd budget token for qc tag for SAS host

[kernel test robot <lkp@intel.com>]

Hi John,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on jejb-scsi/for-next linus/master v5.17-rc8 next-20220315]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/John-Garry/scsi-libata-A-potential-tagging-fix-and-improvement/20220315-185159
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: arm-cns3420vb_defconfig (https://download.01.org/0day-ci/archive/20220316/202203160450.G7KPHd4L-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a6b2f50fb47da3baeee10b1906da6e30ac5d26ec)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/c0fc60bbc4ec38b12bba06e9ee97cd8bd10f72ca
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review John-Garry/scsi-libata-A-potential-tagging-fix-and-improvement/20220315-185159
        git checkout c0fc60bbc4ec38b12bba06e9ee97cd8bd10f72ca
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/ata/libata-core.c:4578:34: error: too many arguments to function call, expected single argument 'ap', have 2 arguments
                   tag = ata_sas_allocate_tag(ap, scmd);
                         ~~~~~~~~~~~~~~~~~~~~     ^~~~
   drivers/ata/libata.h:99:19: note: 'ata_sas_allocate_tag' declared here
   static inline int ata_sas_allocate_tag(struct ata_port *ap)
                     ^
   1 error generated.


vim +/ap +4578 drivers/ata/libata-core.c

  4556	
  4557	/**
  4558	 *	ata_qc_new_init - Request an available ATA command, and initialize it
  4559	 *	@dev: Device from whom we request an available command structure
  4560	 *	@tag: tag
  4561	 *
  4562	 *	LOCKING:
  4563	 *	None.
  4564	 */
  4565	
  4566	struct ata_queued_cmd *ata_qc_new_init(struct ata_device *dev, struct scsi_cmnd *scmd)
  4567	{
  4568		int tag = scsi_cmd_to_rq(scmd)->tag;
  4569		struct ata_port *ap = dev->link->ap;
  4570		struct ata_queued_cmd *qc;
  4571	
  4572		/* no command while frozen */
  4573		if (unlikely(ap->pflags & ATA_PFLAG_FROZEN))
  4574			return NULL;
  4575	
  4576		/* libsas case */
  4577		if (ap->flags & ATA_FLAG_SAS_HOST) {
> 4578			tag = ata_sas_allocate_tag(ap, scmd);
  4579			if (tag < 0)
  4580				return NULL;
  4581		}
  4582	
  4583		qc = __ata_qc_from_tag(ap, tag);
  4584		qc->tag = qc->hw_tag = tag;
  4585		qc->scsicmd = NULL;
  4586		qc->ap = ap;
  4587		qc->dev = dev;
  4588	
  4589		ata_qc_reinit(qc);
  4590	
  4591		return qc;
  4592	}
  4593	

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org