From: Christoph Hellwig <hch@lst.de>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
syzbot <syzbot+6479585dfd4dedd3f7e1@syzkaller.appspotmail.com>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH v2] loop: don't hold lo->lo_mutex from lo_open() and lo_release()
Date: Wed, 16 Mar 2022 09:44:29 +0100 [thread overview]
Message-ID: <20220316084429.GA6858@lst.de> (raw)
In-Reply-To: <134d1b65-f7c0-b8b3-d6c9-4a5e1d807afd@I-love.SAKURA.ne.jp>
On Tue, Mar 15, 2022 at 07:57:25PM +0900, Tetsuo Handa wrote:
> On 2022/03/15 17:44, Christoph Hellwig wrote:
> > On Mon, Mar 14, 2022 at 04:23:18PM +0100, Jan Kara wrote:
> >> Honestly, the anon inode trick makes the code pretty much unreadable. As
> >> far as I remember Christoph was not pricipially against using task_work. He
> >> just wanted the task_work API to be improved so that it is easier to use.
> >
> > This whole patch is awful. And no, I don't think task_work_add really has
> > any business here. We need to properly unwind the mess instead of piling
> > things higher and higher.
>
> How do you plan to unwind the mess?
Yes. I'll send another resping of the previous approach we had last
time..
next prev parent reply other threads:[~2022-03-16 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 16:25 [syzbot] possible deadlock in blkdev_put (3) syzbot
2022-03-12 17:08 ` Tetsuo Handa
2022-03-13 15:15 ` [PATCH v2] loop: don't hold lo->lo_mutex from lo_open() and lo_release() Tetsuo Handa
2022-03-14 15:23 ` Jan Kara
2022-03-15 8:44 ` Christoph Hellwig
2022-03-15 10:57 ` Tetsuo Handa
2022-03-16 8:44 ` Christoph Hellwig [this message]
2022-03-16 12:26 ` Jan Kara
2022-03-16 14:29 ` Tetsuo Handa
2022-03-14 4:45 ` [syzbot] possible deadlock in blkdev_put (3) syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316084429.GA6858@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=syzbot+6479585dfd4dedd3f7e1@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.