From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F33FC433EF for ; Wed, 16 Mar 2022 14:49:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1B6AA83BAE; Wed, 16 Mar 2022 15:49:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fbZRolKc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 394A683C06; Wed, 16 Mar 2022 15:48:57 +0100 (CET) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CE9ED83975 for ; Wed, 16 Mar 2022 15:48:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id q194so2020791qke.5 for ; Wed, 16 Mar 2022 07:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=k5gPuzcu1IF6cQS46+Ne1oZRRp+M9Op3NMU9ZTUiJxM=; b=fbZRolKc2WGTiAUNCvBdXT+XSpAqCj4n7zMcE51c+n/b8K4G2ybx0d1uWPHAP5vZOg WnlT6oX+xkPpltlzUInaHDIUmVm6btmuoXyZyVJ1H78LL2iXLvzcmOh5GbhYdgS72mQk bGInWkI0tnkd/ENsIpIcpYNBXy2c2N2y/zXFk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=k5gPuzcu1IF6cQS46+Ne1oZRRp+M9Op3NMU9ZTUiJxM=; b=xKlBGW7Z5Erv/VOESnVkTJjHaMEqRO1LwXknvtjwn+xxN/WjGBIph1VLKKbTHlX9B4 AOFXkE6TE8mCIwP+rCLMZJlyOsOJvkEH7Q39/X2nk2Tw4M3agm0XwQaCPWALWTArf/zG 6TDHq3diZd+eUj2EyFvGyOJ1wPg2Rme9iHk1gxLyR+oMyqFJVLKDYuu8MOm7TSPBP0mT 37HjKmH6n/FNtLIWlarlgLs4TBaxisXaHZq5JpWuytwCo0z792YxF+RwckYMsVY3b1tD /SV2+y+9puhq65l3JA50u6XNOszfVoBJzhFSH5jxloqKn1EOxy+YE/tW80SFYievPx+p iWeA== X-Gm-Message-State: AOAM530wZlfBWtG4FRXhCcVAYv9BN/2zWGeFxN7s5JH5+ysFgMB5cMGG KwJ5o84v4TiFeKpo91+5hu+N7w== X-Google-Smtp-Source: ABdhPJwmntpWtEiVTi+SwiNoIjjC5uqGbGEA1m4Nw+4nQDwuHnWldJ2/bq6dVsD5NT7Zmbq88+FjSQ== X-Received: by 2002:a05:620a:4542:b0:67d:c128:7158 with SMTP id u2-20020a05620a454200b0067dc1287158mr174263qkp.278.1647442125438; Wed, 16 Mar 2022 07:48:45 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id u17-20020ac858d1000000b002e1cdbb50besm1417097qta.78.2022.03.16.07.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 07:48:44 -0700 (PDT) Date: Wed, 16 Mar 2022 10:48:42 -0400 From: Tom Rini To: Troy Kisky Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH v1 0/5] Move board specific files to board directory Message-ID: <20220316144842.GQ577378@bill-the-cat> References: <20211217230131.2715940-1-troy.kisky@boundarydevices.com> <20211228131115.GZ2773246@bill-the-cat> <20220107151250.GK2773246@bill-the-cat> <20220208143016.GN7515@bill-the-cat> <15ff0408-7b2f-c892-9239-ed923c835365@boundarydevices.com> <20220315200114.GA577378@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="E50aLcSU4JxQSj/B" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --E50aLcSU4JxQSj/B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 15, 2022 at 01:23:42PM -0700, Troy Kisky wrote: > On 3/15/2022 1:01 PM, Tom Rini wrote: > > On Tue, Mar 15, 2022 at 12:08:02PM -0700, Troy Kisky wrote: > >> On 2/8/2022 6:30 AM, Tom Rini wrote: > >>> On Fri, Jan 07, 2022 at 10:33:34AM -0800, Troy Kisky wrote: > >>>> On 1/7/2022 7:12 AM, Tom Rini wrote: > >>>>> On Thu, Jan 06, 2022 at 01:14:40PM -0800, Troy Kisky wrote: > >>>>>> On 12/28/2021 5:11 AM, Tom Rini wrote: > >>>>>>> On Tue, Dec 28, 2021 at 01:33:05AM -0700, Simon Glass wrote: > >>>>>>>> Hi Troy, > >>>>>>>> > >>>>>>>> On Fri, 17 Dec 2021 at 16:02, Troy Kisky wrote: > >>>>>>>>> > >>>>>>>>> This series intends to let board specific files live in the boa= rds > >>>>>>>>> directory. The last patch moves files for nitrogen6x. > >>>>>>>>> I have tested it with buildman > >>>>>>>>> > >>>>>>>>> ./tools/buildman/buildman boundary -b denx_master > >>>>>>>>> > >>>>>>>>> But it is likely the more scripts then just tools/genboardscfg.= py would > >>>>>>>>> need to be updated. > >>>>>>>>> > >>>>>>>>> Troy Kisky (5): > >>>>>>>>> kconfig: allow defconfigs to live in board directory > >>>>>>>>> dts: allow dts files in board directory > >>>>>>>>> scripts: Makefile.autoconf: allow CONFIG_SYS_CONFIG_NAME file= to live > >>>>>>>>> in board directory > >>>>>>>>> genboardcfg: allow defconfigs in board directory > >>>>>>>>> nitrogen6x: move board specific files to nitrogen6x directory > >>>>>>>>> > >>>>>>>>> arch/arm/dts/Makefile | 3 -- > >>>>>>>>> board/boundary/nitrogen6x/MAINTAINERS | 13 ------- > >>>>>>>>> board/boundary/nitrogen6x/Makefile | 13 +++++++ > >>>>>>>>> .../nitrogen6x}/imx6dl-nitrogen6x.dts | 0 > >>>>>>>>> .../boundary/nitrogen6x}/imx6q-nitrogen6x.dts | 0 > >>>>>>>>> .../boundary/nitrogen6x}/imx6q-sabrelite.dts | 0 > >>>>>>>>> .../nitrogen6x}/imx6qdl-nitrogen6x.dtsi | 0 > >>>>>>>>> .../nitrogen6x}/imx6qdl-sabrelite.dtsi | 0 > >>>>>>>>> .../nitrogen6x}/mx6qsabrelite_defconfig | 0 > >>>>>>>>> .../nitrogen6x}/nitrogen6dl2g_defconfig | 0 > >>>>>>>>> .../nitrogen6x}/nitrogen6dl_defconfig | 0 > >>>>>>>>> .../nitrogen6x}/nitrogen6q2g_defconfig | 0 > >>>>>>>>> .../boundary/nitrogen6x}/nitrogen6q_defconfig | 0 > >>>>>>>>> .../nitrogen6x}/nitrogen6s1g_defconfig | 0 > >>>>>>>>> .../boundary/nitrogen6x}/nitrogen6s_defconfig | 0 > >>>>>>>>> .../boundary/nitrogen6x}/nitrogen6x.h | 2 +- > >>>>>>>>> dts/Makefile | 11 +++++- > >>>>>>>>> scripts/Makefile.autoconf | 9 ++++- > >>>>>>>>> scripts/Makefile.lib | 1 + > >>>>>>>>> scripts/kconfig/Makefile | 9 ++++- > >>>>>>>>> tools/genboardscfg.py | 37 +++++++++++= +++++++- > >>>>>>>>> 21 files changed, 75 insertions(+), 23 deletions(-) > >>>>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6dl-ni= trogen6x.dts (100%) > >>>>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-nit= rogen6x.dts (100%) > >>>>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-sab= relite.dts (100%) > >>>>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-n= itrogen6x.dtsi (100%) > >>>>>>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-s= abrelite.dtsi (100%) > >>>>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/mx6qsabrelite_= defconfig (100%) > >>>>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl2g_= defconfig (100%) > >>>>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl_de= fconfig (100%) > >>>>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q2g_d= efconfig (100%) > >>>>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q_def= config (100%) > >>>>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s1g_d= efconfig (100%) > >>>>>>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s_def= config (100%) > >>>>>>>>> rename {include/configs =3D> board/boundary/nitrogen6x}/nitrog= en6x.h (98%) I'm not about the goal. > >>>>>>>> > >>>>>>>> Can you please add a few notes about the motivation for this cha= nge? > >>>>>>> > >>>>>>> Sorry for the delayed reply here. I'm also not entirely sure thi= s is a > >>>>>>> good idea. Moving the defconfig files? Maybe. It does make che= cking > >>>>>>> all configs a bit more tricky, but indeed the configs directory is > >>>>>>> unwieldy. Moving the dts files? Those should be a direct cp fro= m the > >>>>>>> kernel, so that makes things less clear to me. Especially since = it will > >>>>>>> need other common files that will still be elsewhere. > >>>>>>> > >>>>>> > >>>>>> They will still be a direct copy. Notice the 100% rename. Common f= iles still living in the dts > >>>>>> directory is less clear. I can try to address the "piecemeal build= ing of .dts files" if this > >>>>>> still has a chance of being accepted. > >>>>> > >>>>> So, here's my worry. Today, in an ideal world that we're not yet a= t, I > >>>>> could do: > >>>>> 1. cd ~/src/linux; git checkout v5.16 > >>>>> 2. cd ~/src/u-boot; for DTS in arch/arm/dts/*.dts*; do \ > >>>>> [ -f ~/src/linux/$DTS ] && cp ~/src/linux/$DTS $DTS; done > >> > >> Perhaps we can mimic Linux's arm/arm64 dts split and make the above wo= rk better? > >=20 > > Along with making the distinction between what we're mirroring and what > > we're adding more clear yes, that would be viable I think. > >=20 >=20 > Do you envision the *u-boot.dts not moving with the other files ? Or movi= ng to a directory with a > different name? i.e. arm-u-boot, arm64-u-boot, with the same sub-director= y structure. I'd like to see our -u-boot.dtsi stuff separate, to help with enforcing the notion that dts files go upstream and come back to us unmodified. Then we have our own files to update them as needed, but the core dtses aren't to be changed. Directory structure really comes down to how to easily implement the build rules I guess, so likely needing to follow arm64/dts, etc. --=20 Tom --E50aLcSU4JxQSj/B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIx+MoACgkQFHw5/5Y0 tywPpgv/SfOsm0udtakXkY1od8/uLfpOGCsfsAj1mwkNUPvGfp9Jr1T5K7223vOy vwwI5chYhLNzwLgxCLBtuTkZhQ8dNIYFmv4CtLL/quIh6idC7oDKzCbn9CKWlRFM JgBcNj/VsBZxBr4DQb0uw6ooBpVMiaozshueKL6O3pYpsryxW/Lbo0gZsQ6bzdlg nziJEamdF8mL3vVfniXEeiQ4GF+lu9fxE+gxkNvBavHvV2cFXyDNqQHojVREVquR EqneOE1kDNy6mg0EVjdzm9qtgzjpP79eg4rzXnMrLHWhQ207rInkNkdlcVvfVpTd KLNCq1SMGuRW8ghmJeIidqheUxSCywKgHVjssEn1/0Nn4Z/KpOJv9UcxBrbuyi63 KQct7VsTZ9jmsltyCB8mWv4d2nD0i672XZ1t3h9GeYbippzvVn4tCz2gJ1CxbkQx NQNPuMWFg21uWs+/WLpIlwsCYkk2wmZJ0VrWmuHSBY2PRFUO9rnwL+XtY8L9JugG NbOBBPe1 =GjlM -----END PGP SIGNATURE----- --E50aLcSU4JxQSj/B--