From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nUjrr-0004CJ-Vc for mharc-grub-devel@gnu.org; Thu, 17 Mar 2022 02:44:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUjrp-00048I-1Y for grub-devel@gnu.org; Thu, 17 Mar 2022 02:44:13 -0400 Received: from de-smtp-delivery-102.mimecast.com ([194.104.109.102]:56527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUjrn-0007z1-F0 for grub-devel@gnu.org; Thu, 17 Mar 2022 02:44:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1647499450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ytcm11vcdXSfjNdJyCfh94U8zSkefYUNiI4QZ63bNso=; b=LgV4UyHuGjraRm4w27ooN8p783/u9SHJHYeo33ru26EbnRYOagKE5gWNL/8cDkRk2fSgi2 +L+K3tguoOj6OlW4kJKB4YkdotUvgi1OolfQR1cL097WCKdWvmSmE9VrFtdQNqOORIKmrK G+rSqbJzeAZpC0aJV7wbYCSO83E8WNg= Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-Dy5L3_OCOtOhXqNw4F9Npw-1; Thu, 17 Mar 2022 07:44:09 +0100 X-MC-Unique: Dy5L3_OCOtOhXqNw4F9Npw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+KrGcOh2bID+W3Bnupj/w4Db55x+sqoWJ5BAM9F2ulHXKKhSuDJ1XnbI/sZdikkwsegj2nu8s8f9yVx8RAJDHW+eOPnQ404Yp9WA9ILpMU1CPCXlARdpprOcGecK70kPAV3HcU6sWMo5aEqcT3EmkFOEthHyiEemGSvJrdJYBU2WGCrwCxfzyESFJ8TqefPqMvo5UjBq5ng/b8jXt5sMO/TvATAuCkKAycDU/Zbiq5mQ2KJgMiBLouPzTzavN4yZRuGbkKsc+eg9Q/p33JHFKK7QXIjCO+ry1LSWjCGcLM27g0YnPUGB9xC7So6ONHFw8WanujeAKdPJOpeL1rSKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VRloictm56XruuxFNV80CveWI9KEwrYOynydhHe7pq8=; b=n/f1ExwZFVO+YCBUiXKJRVyh7qH/dsxfvC5a/QVaVFz/w0syYHHiUCpuH6B3uVY6/4ScR6F88fHq83s5SW9/FQFthM/hbHYRisz/meKsniRoP1fvVLv2SxaapKfoM2LOVeFaMIYEXZ4GWV5aGS67E3aItnFmXHVESNeNUP0zEqjvJyCDiiOFBc+IXUnz4QYsvUU0SUFqHa4/4LqQzc1ccQtwcN1RwdKGxX9dPFjhz7Yb5w8zHWACiZp+P1QRTh1RfvHPAz3M/eQW5HDs+cI3qvZskq9TeyAECulN/oM/dOZl4cKASPcTGbPjAy7cVB4KSgrNysCqxQhqvxllzrKeQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) by AM6PR0402MB3606.eurprd04.prod.outlook.com (2603:10a6:209:8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.28; Thu, 17 Mar 2022 06:44:08 +0000 Received: from DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::2d29:445:cc37:a97f]) by DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::2d29:445:cc37:a97f%5]) with mapi id 15.20.5061.022; Thu, 17 Mar 2022 06:44:08 +0000 From: Michael Chang To: grub-devel@gnu.org Subject: [PATCH 3/3] reed_solomon: Fix array subscript 0 is outside array bounds Date: Thu, 17 Mar 2022 14:43:42 +0800 Message-ID: <20220317064342.25671-4-mchang@suse.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220317064342.25671-1-mchang@suse.com> References: <20220317064342.25671-1-mchang@suse.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-ClientProxiedBy: HK2PR02CA0187.apcprd02.prod.outlook.com (2603:1096:201:21::23) To DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86159f4e-dd6b-4351-9d36-08da07e1896d X-MS-TrafficTypeDiagnostic: AM6PR0402MB3606:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +vhoiaFbVAwBEYup88qS3EdRU13uurhbAFZeuShlwem9vhptPI4iVyHCZO8yZJpYd2g9SX5/k2ABRZSmP+/7pkld/vMpOoD9T39UICCMdCgs/1aczIpA7bzs1oJ+XdqqVB/SpxdzwBynvbd7h8Et2PfSvL/r3kSqB9QOkys7zAvwZ1ktbz/y2jWsbqJjTXTYQM5dJcjUKAbJdkHLF/b4dS2wm5920k9enmbvTjOxWsIao326wYqV35W/T3Y3SlChCavDtmG9qC3XGi8zOu2ws6n2L24qbeTCjZ0u71sfRUx0BYfhV90OceYx9lq8yRc6vEOZKTDtdGpVFR2zy4VZEJjPkx+USgRQR3kewLZLLMNLQtgnjhi3sbN9+ef4gYJerWUQ5NQZCkI8sj299H6WvZBE2Ql1VvvRTkK7B91ddxsd0MNo1UZeheD7qHuvXDmaHNTl7rzOA0TkdiwDxOCMsxEzv968iLwWBYZ5Bu5IoTOjSLhbqr9b8VyuVx4qt7xv1txTN+Fc8dzgwue0NRQrgV/PY+Xlmt/Tqo1WOnyP+CHoWVGc9QBVYCdzDo1eb1lPe3JNygC8mniSq7bNPYUD74ly6OLFz9dFU7Ousg9+4ZRjAInIHOfjiGM1p8jFQ6a/LK2CYrC5+YE4gIs33pIYzQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB9081.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6916009)(316002)(36756003)(508600001)(8936002)(66476007)(6486002)(5660300002)(2906002)(66946007)(38100700002)(8676002)(66556008)(86362001)(2616005)(6666004)(1076003)(6512007)(6506007)(83380400001)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QX4gx0AhtzRy6pynNpOpWBrVPXWyB2dPVnBXYm3luxKi1qnzMNiWaacqj738?= =?us-ascii?Q?+FMMym83vyhf3wfA9E7CV9o9p71RPMy8F170L6gSZjB7IfOVvfKZzxPEgilJ?= =?us-ascii?Q?8y6849VstRxOvyokAWQwAvHMHR/UX59kw9mgfQLdsoXBdqqYiNT102wJ5iaL?= =?us-ascii?Q?ka2kP79y7gLs6DRM1beXAr7a2hJ2QGKZYO/U70pINPouFE4BVTDz4KFGIdcW?= =?us-ascii?Q?sbxxfElbi/6ApqwYagtAIhPilzGJPjDRVS5e5pnNMZ2Sqx+Mq62fR3uaFYpv?= =?us-ascii?Q?T3PREYk7+7btEvlq/p39LnVnV09eVRwaufXjbk9pJuv1AhwcM2ApBSJHUZpP?= =?us-ascii?Q?ZhK5CrZafx3R+sutkz4wsJjsctHas6kyHKknJ8ZyICv4xOY1uhD917s8kPt+?= =?us-ascii?Q?P4wjyOUF50uUP8VKI0qmYbdlrvzc/JyQpxyicgLLtxW8o/wqXzyxkTddsKzR?= =?us-ascii?Q?oAg/li5FZ502oN5w6dFlTFZ5uWMnXPwyInv1oT9DIdPKakiPZEDyMQln4ZWE?= =?us-ascii?Q?WEvRtd0SQY476veIkCKT0PCm6RpGPeZ4NO17OOfultNPOUprF+XiyPDLQOB/?= =?us-ascii?Q?SCSXzI4YylN3i7xN63ShzxLJBI6nxMhnjZud46JcPJ1IT1Y0mO27cEHPbbG+?= =?us-ascii?Q?tTSOqEfQE2U9ddSbc1vC3oFKahEtmz4KIkUiPj62hBLa6IBg1lb0X2GiI4rr?= =?us-ascii?Q?ePfN4TFnntjXUJJjPup220nu0VRgjCZNH/VbOiel6VkMjdM9CeR4FlXzL7Co?= =?us-ascii?Q?zZ+xAYosdWGLqY1p2oXORcxDBUiS2R9qr3/Cf5XRC9qZHtWLVQX4Yh1nxTuR?= =?us-ascii?Q?LlWwtU5w7dWmz2XmCKELRYKRXNrxRvmsbC2Ec5CUQdawGpYNUvbyshWA8mtT?= =?us-ascii?Q?0aM4qUzTjBnMqK/OZV/WaATfwEYUB5wXVa8xg2I2ht/ZunWDRYiVytEemOOC?= =?us-ascii?Q?GTt/7u9RzOMV2W15aRCJhUu8JiSNv6ivebln3zTbbzvmj+79mmUWOYpa++hD?= =?us-ascii?Q?q9zbZ5vPjIIy/TsQeMJy0y33TS9TCJQ19ZSclXQW96X7hx3sNM6UZZlO5hpw?= =?us-ascii?Q?cChi1cyRqYarEKH+M/wbtNBBkP6kCCcx44HHiMahzKZsj5rm875MmlmG7vSn?= =?us-ascii?Q?yWp7S4+DXgiJS/F1QowOJJLcjbD6Me+1RZra7P7T+my4GfKdj2SOWe3t9NgI?= =?us-ascii?Q?LxjgN/bGcEQKnPlYC64As+1a5M2RZN3jd38rl27G5GdJ/EU5zCu0J/Gf5iwO?= =?us-ascii?Q?8p3XMvEWD/cUUMyPJjF5kP9j6F6yfBSlq5BnaWclrx1ILBFzEzhmW+Jym/21?= =?us-ascii?Q?UmA9ah3Y2JmbduZL/5HA5rxT9L5Mb/imaQOHvoV+E5vQid8p5mI5rojHo6zt?= =?us-ascii?Q?iW3nKJc9I5A1iHW1QEeAy+lqPc/ZsLLJijVAhfzWf9Pq5IPPeytLO2LGwOfA?= =?us-ascii?Q?Eh9p+jeShoe1KsyQr+YHnvdRxi4MTnmnY7TwNYh86KXT/tEkGMYYQe4iVYSU?= =?us-ascii?Q?cMTbkW47F7mFSNAARY0heI5i50mBMlkpKu0E?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86159f4e-dd6b-4351-9d36-08da07e1896d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9081.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 06:44:08.2607 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xoNAzajASy77u5ammILDdvzzxsrFVD3toNcNqf4vCCq+4h7NUOYGWkjSVs5RGHWQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3606 Received-SPF: pass client-ip=194.104.109.102; envelope-from=mchang@suse.com; helo=de-smtp-delivery-102.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 06:44:13 -0000 The grub_absolute_pointer() is a compound expression that can only work within a function. We are out of luck here when the pointer variables require global definition due to ATTRIBUTE_TEXT that have to use fully initialized global definition because of the way linkers work. static gf_single_t * const gf_powx ATTRIBUTE_TEXT =3D (void *) 0x100000; For the reason given above, use gcc diagnostic pragmas to suppress the array-bounds warning. Signed-off-by: Michael Chang --- grub-core/lib/reed_solomon.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/grub-core/lib/reed_solomon.c b/grub-core/lib/reed_solomon.c index 82779a296b..562bd2e3e3 100644 --- a/grub-core/lib/reed_solomon.c +++ b/grub-core/lib/reed_solomon.c @@ -102,6 +102,11 @@ static gf_single_t errvals[256]; static gf_single_t eqstat[65536 + 256]; #endif =20 +#if __GNUC__ =3D=3D 12 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Warray-bounds" +#endif + static gf_single_t gf_mul (gf_single_t a, gf_single_t b) { @@ -319,6 +324,10 @@ decode_block (gf_single_t *ptr, grub_size_t s, } } =20 +#if __GNUC__ =3D=3D 12 +#pragma GCC diagnostic pop +#endif + #if !defined (STANDALONE) static void encode_block (gf_single_t *ptr, grub_size_t s, --=20 2.34.1