From: Heiko Thiery <heiko.thiery@gmail.com>
To: u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>, Michale Walle <michael@walle.cc>,
Angus Ainslie <angus@akkea.ca>,
Angus Ainslie <angus.ainslie@puri.sm>,
lukma@denx.de, seanga2@gmail.com, sbabic@denx.de,
festevam@gmail.com, uboot-imx@nxp.com, peng.fan@nxp.com,
Heiko Thiery <heiko.thiery@gmail.com>
Subject: [RFC] serial: mxc: get the clock frequency from the used clock for the device
Date: Thu, 17 Mar 2022 13:41:28 +0100 [thread overview]
Message-ID: <20220317124127.1783768-1-heiko.thiery@gmail.com> (raw)
With the clock driver enabled for the imx8mq, it was noticed that the
frequency used to calculate the baud rate is always taken from the root
clock of UART1. This can cause problems if UART1 is not used as console
and the settings are different from UART1. The result is that the console
output is garbage. To do this correctly the UART frequency is taken from
the used device. For the implementations that don't have the igp clock
frequency written or can't return it the old way is tried.
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
drivers/serial/serial_mxc.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c
index e4970a169b..6fdb2b2397 100644
--- a/drivers/serial/serial_mxc.c
+++ b/drivers/serial/serial_mxc.c
@@ -3,6 +3,7 @@
* (c) 2007 Sascha Hauer <s.hauer@pengutronix.de>
*/
+#include <clk.h>
#include <common.h>
#include <dm.h>
#include <errno.h>
@@ -266,9 +267,19 @@ __weak struct serial_device *default_serial_console(void)
int mxc_serial_setbrg(struct udevice *dev, int baudrate)
{
struct mxc_serial_plat *plat = dev_get_plat(dev);
- u32 clk = imx_get_uartclk();
+ u32 rate = 0;
+
+ if (IS_ENABLED(CONFIG_CLK)) {
+ struct clk clk;
+ if(!clk_get_by_name(dev, "ipg", &clk))
+ rate = clk_get_rate(&clk);
+ }
+
+ /* as fallback we try to get the clk rate that way */
+ if (rate == 0)
+ rate = imx_get_uartclk();
- _mxc_serial_setbrg(plat->reg, clk, baudrate, plat->use_dte);
+ _mxc_serial_setbrg(plat->reg, rate, baudrate, plat->use_dte);
return 0;
}
--
2.30.2
next reply other threads:[~2022-03-17 12:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 12:41 Heiko Thiery [this message]
2022-03-17 13:19 ` [RFC] serial: mxc: get the clock frequency from the used clock for the device Angus Ainslie
2022-03-18 19:06 ` Heiko Thiery
2022-03-19 14:32 ` Angus Ainslie
2022-03-21 13:50 ` Heiko Thiery
2022-03-22 12:47 ` Angus Ainslie
2022-03-24 2:08 ` Adam Ford
2022-03-24 9:58 ` Heiko Thiery
2022-03-24 10:57 ` Adam Ford
2022-03-17 14:38 ` Sean Anderson
2022-03-17 14:47 ` Michael Walle
2022-03-18 2:15 ` Sean Anderson
2022-03-17 16:31 ` Lukasz Majewski
2022-03-17 19:14 ` Heiko Thiery
2022-03-18 2:19 ` Sean Anderson
2022-03-18 8:05 ` Heiko Thiery
2022-03-18 13:26 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317124127.1783768-1-heiko.thiery@gmail.com \
--to=heiko.thiery@gmail.com \
--cc=angus.ainslie@puri.sm \
--cc=angus@akkea.ca \
--cc=festevam@gmail.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=michael@walle.cc \
--cc=peng.fan@nxp.com \
--cc=sbabic@denx.de \
--cc=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.