From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EE09C433FE for ; Thu, 17 Mar 2022 14:42:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 256991910; Thu, 17 Mar 2022 15:41:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 256991910 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647528124; bh=hxdofN2BPr2wGB36uoStlDdxkKMsJNBlXp5qDw4a4/8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=a7MS2gV2HbNhlj3qGgRsJesXivp2Seope41xdC2DQqhILP6TLnIP8pz3HDNEScGNh NG+MVGuy3DXn+B4XXn92Hpn62PYGdyL/ztR0n2715I7pL4N3B88v3bEM/Lcw8oARe6 YnSyu3anwLDPBu+/7ImuYTuSBqW7sSiY8y8xXKt0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A9E9AF80132; Thu, 17 Mar 2022 15:41:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8FBCFF8013F; Thu, 17 Mar 2022 15:41:12 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 11643F80125 for ; Thu, 17 Mar 2022 15:41:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 11643F80125 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUrJI-0002Oy-MK; Thu, 17 Mar 2022 15:41:04 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nUrJH-0001RD-3X; Thu, 17 Mar 2022 15:41:03 +0100 Date: Thu, 17 Mar 2022 15:41:03 +0100 From: Sascha Hauer To: Shengjiu Wang Subject: Re: [PATCH 10/19] dma: imx-sdma: Add multi fifo support Message-ID: <20220317144103.GV405@pengutronix.de> References: <20220317082818.503143-1-s.hauer@pengutronix.de> <20220317082818.503143-11-s.hauer@pengutronix.de> <20220317101950.GU405@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:38:07 up 96 days, 23:23, 78 users, load average: 0.12, 0.16, 0.19 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Cc: alsa-devel@alsa-project.org, Xiubo Li , Vinod Koul , NXP Linux Team , Sascha Hauer , dmaengine@vger.kernel.org, Fabio Estevam , joy.zou@nxp.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Mar 17, 2022 at 08:20:22PM +0800, Shengjiu Wang wrote: > Hi > On Thu, Mar 17, 2022 at 6:19 PM Sascha Hauer <[1]s.hauer@pengutronix.de> > wrote: > > On Thu, Mar 17, 2022 at 05:08:55PM +0800, Shengjiu Wang wrote: > >    On Thu, Mar 17, 2022 at 4:28 PM Sascha Hauer > <[1][2]s.hauer@pengutronix.de> > >    wrote: > > > >      +struct sdma_peripheral_config { > >      +       int n_fifos_src; > >      +       int n_fifos_dst; > >      +       bool sw_done; > >      +}; > >      + > >       #endif > > > >    Hi Sascha > >    This is our internal definition for this sdma_peripheral_config. > >    Could you please adopt this? > > This structure is completely internal to the kernel and can be adjusted > when we need it. I don't see a reason to add unused fields to it just to > be compatible with a downstream kernel. > > Yes, it is not used by micfil. But the fifo_offset and words_per_fifo > is part the multi fifo script support scope, if only add fifo_num,  it > looks > like this feature is not complete. No, it's not. I only added the parts that I am interested in and that I can test. I have some multichannel audio stuff in my pipeline, I might add more pieces later. > By the way,  which multi fifo script version are you using? seems it is > not the latest compared with our release, right? I am using the latest firmware from linux-firmware.git. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A54BC433F5 for ; Thu, 17 Mar 2022 14:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229549AbiCQOm1 (ORCPT ); Thu, 17 Mar 2022 10:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235281AbiCQOm0 (ORCPT ); Thu, 17 Mar 2022 10:42:26 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E17F41BA476 for ; Thu, 17 Mar 2022 07:41:09 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUrJI-0002Oy-MK; Thu, 17 Mar 2022 15:41:04 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nUrJH-0001RD-3X; Thu, 17 Mar 2022 15:41:03 +0100 Date: Thu, 17 Mar 2022 15:41:03 +0100 From: Sascha Hauer To: Shengjiu Wang Cc: alsa-devel@alsa-project.org, Xiubo Li , Fabio Estevam , Sascha Hauer , Vinod Koul , NXP Linux Team , dmaengine@vger.kernel.org, joy.zou@nxp.com Subject: Re: [PATCH 10/19] dma: imx-sdma: Add multi fifo support Message-ID: <20220317144103.GV405@pengutronix.de> References: <20220317082818.503143-1-s.hauer@pengutronix.de> <20220317082818.503143-11-s.hauer@pengutronix.de> <20220317101950.GU405@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:38:07 up 96 days, 23:23, 78 users, load average: 0.12, 0.16, 0.19 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Thu, Mar 17, 2022 at 08:20:22PM +0800, Shengjiu Wang wrote: > Hi > On Thu, Mar 17, 2022 at 6:19 PM Sascha Hauer <[1]s.hauer@pengutronix.de> > wrote: > > On Thu, Mar 17, 2022 at 05:08:55PM +0800, Shengjiu Wang wrote: > >    On Thu, Mar 17, 2022 at 4:28 PM Sascha Hauer > <[1][2]s.hauer@pengutronix.de> > >    wrote: > > > >      +struct sdma_peripheral_config { > >      +       int n_fifos_src; > >      +       int n_fifos_dst; > >      +       bool sw_done; > >      +}; > >      + > >       #endif > > > >    Hi Sascha > >    This is our internal definition for this sdma_peripheral_config. > >    Could you please adopt this? > > This structure is completely internal to the kernel and can be adjusted > when we need it. I don't see a reason to add unused fields to it just to > be compatible with a downstream kernel. > > Yes, it is not used by micfil. But the fifo_offset and words_per_fifo > is part the multi fifo script support scope, if only add fifo_num,  it > looks > like this feature is not complete. No, it's not. I only added the parts that I am interested in and that I can test. I have some multichannel audio stuff in my pipeline, I might add more pieces later. > By the way,  which multi fifo script version are you using? seems it is > not the latest compared with our release, right? I am using the latest firmware from linux-firmware.git. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |