From: Lukas Wunner <lukas@wunner.de>
To: Miguel Angel Ajo <majopela@redhat.com>
Cc: Mark Brown <broonie@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Javier Martinez Canillas <javierm@redhat.com>,
linux-spi@vger.kernel.org
Subject: Re: bcm2711 / RPi4 not functional after d62069c22eda
Date: Fri, 18 Mar 2022 13:59:25 +0100 [thread overview]
Message-ID: <20220318125925.GA21543@wunner.de> (raw)
In-Reply-To: <CAC3B9fkpO13QhCgVO-qyynbwdh_z60CKgpUhn-40NyGNGz_q8Q@mail.gmail.com>
[cc += linux-spi; please do not write developers directly without cc'ing
relevant lists]
On Fri, Mar 18, 2022 at 11:54:35AM +0100, Miguel Angel Ajo wrote:
> On Fri, Mar 18, 2022 at 11:47 AM Miguel Angel Ajo <majopela@redhat.com>
> wrote:
> > I wanted to share a regression found after commit:
> >
> > d62069c22eda spi: bcm2835: Remove shared interrupt support
[...]
> > After this commit I get:
> >
> > [root@rpi4-64 ~]# dmesg | grep spi
> > [ 18.781250] spi-bcm2835 fe204000.spi: could not register SPI
> > controller: -517
> > [ 19.134138] spi-bcm2835 fe204000.spi: could not register SPI
> > controller: -517
> > [ 19.895147] spi-bcm2835 fe204000.spi: could not register SPI
> > controller: -517
> > [ 20.400137] spi-bcm2835 fe204000.spi: could not register SPI
> > controller: -517
Those are transient errors, -517 is -EPROBE_DEFER. Probing fails
because a resource is not available (yet), to be retried again later
if/when it becomes available.
> > ecfbd3c introduced support for the bcm2711 SoC that shares
> > one interrupt over multiple spi controller instances.
> >
> > Do we have a more detailed description of the exact issue for
> > which we reverted?, is there a plan to re-introduce the shared interrupt
> > support while fixing the issue?
See here for why the commit was reverted:
https://lore.kernel.org/linux-spi/20200529174358.som3snunfxch6phi@wunner.de/
There was a second attempt to introduce shared interrupt support,
but after a lengthy discussion, it was not pursued to fruition:
https://lore.kernel.org/linux-spi/20200604212819.715-1-f.fainelli@gmail.com/
So I believe shared interrupt support only exists in the Raspberry Pi
Foundation's downstream kernel, but not yet in the mainline kernel.
Thanks,
Lukas
next parent reply other threads:[~2022-03-18 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAC3B9fn9DWezr3rspLbomuRLtRjSvW89cLMWR9TTCYsX=PDM_w@mail.gmail.com>
[not found] ` <CAC3B9fkpO13QhCgVO-qyynbwdh_z60CKgpUhn-40NyGNGz_q8Q@mail.gmail.com>
2022-03-18 12:59 ` Lukas Wunner [this message]
2022-03-18 15:31 ` bcm2711 / RPi4 not functional after d62069c22eda Florian Fainelli
2022-03-18 16:17 ` Miguel Angel Ajo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318125925.GA21543@wunner.de \
--to=lukas@wunner.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=javierm@redhat.com \
--cc=linux-spi@vger.kernel.org \
--cc=majopela@redhat.com \
--cc=nsaenz@kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.