From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 553B1C433EF for ; Fri, 18 Mar 2022 16:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wUEJVM+xuU+hoL67Jm0KjjVLFy5SKk/1A3CrLPZlto8=; b=HVGnbQlyMxGj4z Ka/cBfoQsxVEuMqdyZ8Ru9nf0JQKrIixloPfVX63/ecE2nljlS0WF3M709LM7iKVRgGyFUqhEaopK ZnSttxc+R43X9Ok9yO/3qDqbcxogJJVC7Xdlx2BXUwHVL8KqaeTtuCACCXCu7sXrZFU15BDxcIOM6 s1PRlSyzUtcdPPDD8zuFwUS58a1vfa7UAyEl+NdNFSm/SHm1QUCsfE5CRl0jCu8Y2HORsdOo/qTKg CQe2RfZWvtZN7KsmsUPT0lv8uMiZpSKwkSYs8EVvibFxjoi2Zg0ZTrJprdrdn3MsgPFnWRxGO5pJZ uRBEepFxaBFGrkdbLJsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVFf3-002QMx-Sw; Fri, 18 Mar 2022 16:41:09 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVFf1-002QM3-JX for linux-mediatek@lists.infradead.org; Fri, 18 Mar 2022 16:41:09 +0000 Received: by mail-pj1-x102d.google.com with SMTP id bx24-20020a17090af49800b001c6872a9e4eso4667108pjb.5 for ; Fri, 18 Mar 2022 09:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YqeA3yzSovnWISu9O1IIYzrK5bErdUVNL8Ziq3eSYwE=; b=WWKSAR2dgARpIW+G+PXd3YLnUwrniUXkKPt4go9LCVGTfI7J10WokWED37htpO3ypO PRWjgCRVpAfvFv+fs3eZMCUSm95FrQTtkg6ASkXVMubxcEWKs/W75JAGMhxCKeTnOPuM nwz7TlEXlYnApEeYVJpKxo40kB3RIcEHdgE6/nnnS9wJGfimhPImk+44654WHfr+rN12 Fv0J1cnKU5hBIPH8NJ/VlmiaAeOvyRzPECfkJftxdXKuFTTiOqLhgp1eHL8Ai7ikHygW Oqt4tlJskcbTGGopUy1m2LHruXrlLjdPTHfb2NfyrhUQta5/BBu8zwaM7Goi9Q9izRnX YKew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YqeA3yzSovnWISu9O1IIYzrK5bErdUVNL8Ziq3eSYwE=; b=T9lJnxnY0uf45Dr4nn/j7nZ1QvkgvNFttTCsQfZNLBTANH42PLS+PL2pEg0qsuN+Cv Vj6R0FntSEzcJYc2YOG3zDuoV2trWWnrhPBz/VEoOBeFnh5dT7QiYmLRLmWXGy7wxesq GCtNyZDGF9xP0FZUPO/lqxqHsn0+g8U2z6cEGtgdCpm+PN69BgkA/A+SV9SddpO6uqLx Q0PKhXL/Bm5E/Vp6XaonJOJ590mXECKBnLT9Ds9KwRoImXPFDW6oWuzEjOVxYtepgCno tAge3blbpQm0nmn+Q8IRNks2tBTc0yTGviLh8Ky8Ik4zdg4/AaSjoWI5HKh5bNNI+RJ9 DD+g== X-Gm-Message-State: AOAM533FWjSzY8zrRWH2hcqBGOGu8nJ/0hOOT+boinzDRVjUkWu5DMJU YQ9W5MusAT36N53v1B0KgWdotg== X-Google-Smtp-Source: ABdhPJyXYHj5tfou62Tf3lMqf0AvHuY99MCgO1pcsZ+JpImXFJRu9csewD/PBr64ga/R0Dzup1yxYw== X-Received: by 2002:a17:902:70cc:b0:154:1cc8:9df8 with SMTP id l12-20020a17090270cc00b001541cc89df8mr333225plt.32.1647621665507; Fri, 18 Mar 2022 09:41:05 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id y8-20020a17090aa40800b001c6ccb2c395sm327061pjp.9.2022.03.18.09.41.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 09:41:04 -0700 (PDT) Date: Fri, 18 Mar 2022 10:41:02 -0600 From: Mathieu Poirier To: Tinghan Shen Cc: Bjorn Andersson , Matthias Brugger , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v5] remoteproc: mediatek: Fix side effect of mt8195 sram power on Message-ID: <20220318164102.GA2898105@p14s> References: <20220318114200.4344-1-tinghan.shen@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220318114200.4344-1-tinghan.shen@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_094107_657913_E4020E96 X-CRM114-Status: GOOD ( 29.82 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgMTgsIDIwMjIgYXQgMDc6NDI6MDBQTSArMDgwMCwgVGluZ2hhbiBTaGVuIHdy b3RlOgo+IFRoZSBkZWZpbml0aW9uIG9mIEwxVENNX1NSQU1fUEROIGJpdHMgb24gbXQ4MTk1IGlz IGRpZmZlcmVudCB0byBtdDgxOTIuCj4gCj4gTDFUQ01fU1JBTV9QRE4gYml0c1szOjBdIGNvbnRy b2wgdGhlIHBvd2VyIG9mIG10ODE5NSBMMVRDTSBTUkFNLgo+IAo+IEwxVENNX1NSQU1fUEROIGJp dHNbNzo0XSBjb250cm9sIHRoZSBhY2Nlc3MgcGF0aCB0byBFTUkgZm9yIFNDUC4KPiBUaGVzZSBi aXRzIGhhdmUgdG8gYmUgcG93ZXJlZCBvbiB0byBhbGxvdyBFTUkgYWNjZXNzIGZvciBTQ1AuCj4g Cj4gQml0c1s3OjRdIGFsc28gYWZmZWN0IGF1ZGlvIERTUCBiZWNhdXNlIGF1ZGlvIERTUCBhbmQg U0NQIGFyZQo+IHBsYWNlZCBvbiB0aGUgc2FtZSBoYXJkd2FyZSBidXMuIElmIFNDUCBjYW5ub3Qg YWNjZXNzIEVNSSwgYXVkaW8gRFNQIGlzCj4gYmxvY2tlZCB0b28uCj4gCj4gTDFUQ01fU1JBTV9Q RE4gYml0c1szMTo4XSBhcmUgbm90IHVzZWQuCj4gCj4gVGhpcyBmaXggcmVtb3ZlcyBtb2RpZmlj YXRpb24gb2YgYml0c1s3OjRdIHdoZW4gcG93ZXIgb24vb2ZmIG10ODE5NSBTQ1AKPiBMMVRDTS4g SXQncyBiZWNhdXNlIHRoZSBtb2RpZmljYXRpb24gaW50cm9kdWNlcyBhIHNob3J0IHBlcmlvZCBv ZiB0aW1lCj4gYmxvY2tpbmcgYXVkaW8gRFNQIHRvIGFjY2VzcyBFTUkuIFRoaXMgd2FzIG5vdCBh IHByb2JsZW0gdW50aWwgd2UgaGF2ZQo+IHRvIGxvYWQgYm90aCBTQ1AgbW9kdWxlIGFuZCBhdWRp byBEU1AgbW9kdWxlLiBhdWRpbyBEU1AgbmVlZHMgdG8gYWNjZXNzCj4gRU1JIGJlY2F1c2UgaXQg aGFzIHNvdXJjZS9kYXRhIG9uIERSQU0uIEF1ZGlvIERTUCB3aWxsIGhhdmUgdW5leHBlY3RlZAo+ IGJlaGF2aW9yIHdoZW4gaXQgYWNjZXNzZXMgRU1JIGFuZCB0aGUgU0NQIGRyaXZlciBibG9ja3Mg dGhlIEVNSSBwYXRoIGF0Cj4gdGhlIHNhbWUgdGltZS4KPiAKPiBGaXhlczogNzkxMTFkZjQxNGZj ICgicmVtb3RlcHJvYzogbWVkaWF0ZWs6IFN1cHBvcnQgbXQ4MTk1IHNjcCIpCj4gU2lnbmVkLW9m Zi1ieTogVGluZ2hhbiBTaGVuIDx0aW5naGFuLnNoZW5AbWVkaWF0ZWsuY29tPgo+IFJldmlld2Vk LWJ5OiBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyA8YW5nZWxvZ2lvYWNjaGluby5kZWxyZWdu b0Bjb2xsYWJvcmEuY29tPgo+IFJldmlld2VkLWJ5OiBNYXR0aGlhcyBCcnVnZ2VyIDxtYXR0aGlh cy5iZ2dAZ21haWwuY29tPgo+IAo+IC0tLQo+IHY1OiByZWJhc2VkIG9uIHJwcm9jLW5leHQKPiB2 NDogYWRkIEZpeGVzIGFuZCBSZXZpZXdlZC1ieSB0YWdzCj4gdjM6IGZpeCBidWlsZCBlcnJvcgo+ IHYyOiBhcHBseSBjb21tZW50cyBhYm91dCBtYWNybyBkZWZpbml0aW9uIGFuZCBmdW5jdGlvbiBj YWxscwo+IC0tLQo+ICBkcml2ZXJzL3JlbW90ZXByb2MvbXRrX2NvbW1vbi5oIHwgIDIgKwo+ICBk cml2ZXJzL3JlbW90ZXByb2MvbXRrX3NjcC5jICAgIHwgNjcgKysrKysrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKSwgMTYgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcmVtb3RlcHJvYy9tdGtfY29tbW9u LmggYi9kcml2ZXJzL3JlbW90ZXByb2MvbXRrX2NvbW1vbi5oCj4gaW5kZXggNzFjZTQ5NzdjYjBi Li5lYTZmYTExMDBhMDAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9yZW1vdGVwcm9jL210a19jb21t b24uaAo+ICsrKyBiL2RyaXZlcnMvcmVtb3RlcHJvYy9tdGtfY29tbW9uLmgKPiBAQCAtNTQsNiAr NTQsOCBAQAo+ICAjZGVmaW5lIE1UODE5Ml9DT1JFMF9XRFRfSVJRCQkweDEwMDMwCj4gICNkZWZp bmUgTVQ4MTkyX0NPUkUwX1dEVF9DRkcJCTB4MTAwMzQKPiAgCj4gKyNkZWZpbmUgTVQ4MTk1X0wx VENNX1NSQU1fUEROX1JFU0VSVkVEX1JTSV9CSVRTCQlHRU5NQVNLKDcsIDQpCj4gKwo+ICAjZGVm aW5lIFNDUF9GV19WRVJfTEVOCQkJMzIKPiAgI2RlZmluZSBTQ1BfU0hBUkVfQlVGRkVSX1NJWkUJ CTI4OAo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9yZW1vdGVwcm9jL210a19zY3AuYyBiL2Ry aXZlcnMvcmVtb3RlcHJvYy9tdGtfc2NwLmMKPiBpbmRleCAzODYwOTE1M2JmNjQuLjA2OGVkZjIx ZWE1MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3JlbW90ZXByb2MvbXRrX3NjcC5jCj4gKysrIGIv ZHJpdmVycy9yZW1vdGVwcm9jL210a19zY3AuYwo+IEBAIC0zNjUsMjIgKzM2NSwyMiBAQCBzdGF0 aWMgaW50IG10ODE4M19zY3BfYmVmb3JlX2xvYWQoc3RydWN0IG10a19zY3AgKnNjcCkKPiAgCXJl dHVybiAwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBtdDgxOTJfcG93ZXJfb25fc3JhbSh2b2lk IF9faW9tZW0gKmFkZHIpCj4gK3N0YXRpYyB2b2lkIHNjcF9zcmFtX3Bvd2VyX29uKHZvaWQgX19p b21lbSAqYWRkciwgdTMyIHJlc2VydmVkX21hc2spCj4gIHsKPiAgCWludCBpOwo+ICAKPiAgCWZv ciAoaSA9IDMxOyBpID49IDA7IGktLSkKPiAtCQl3cml0ZWwoR0VOTUFTSyhpLCAwKSwgYWRkcik7 Cj4gKwkJd3JpdGVsKEdFTk1BU0soaSwgMCkgJiB+cmVzZXJ2ZWRfbWFzaywgYWRkcik7Cj4gIAl3 cml0ZWwoMCwgYWRkcik7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIG10ODE5Ml9wb3dlcl9vZmZf c3JhbSh2b2lkIF9faW9tZW0gKmFkZHIpCj4gK3N0YXRpYyB2b2lkIHNjcF9zcmFtX3Bvd2VyX29m Zih2b2lkIF9faW9tZW0gKmFkZHIsIHUzMiByZXNlcnZlZF9tYXNrKQo+ICB7Cj4gIAlpbnQgaTsK PiAgCj4gIAl3cml0ZWwoMCwgYWRkcik7Cj4gIAlmb3IgKGkgPSAwOyBpIDwgMzI7IGkrKykKPiAt CQl3cml0ZWwoR0VOTUFTSyhpLCAwKSwgYWRkcik7Cj4gKwkJd3JpdGVsKEdFTk1BU0soaSwgMCkg JiB+cmVzZXJ2ZWRfbWFzaywgYWRkcik7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgbXQ4MTg2X3Nj cF9iZWZvcmVfbG9hZChzdHJ1Y3QgbXRrX3NjcCAqc2NwKQo+IEBAIC00MTIsMTEgKzQxMiwzMiBA QCBzdGF0aWMgaW50IG10ODE5Ml9zY3BfYmVmb3JlX2xvYWQoc3RydWN0IG10a19zY3AgKnNjcCkK PiAgCXdyaXRlbCgxLCBzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0NPUkUwX1NXX1JTVE5fU0VUKTsK PiAgCj4gIAkvKiBlbmFibGUgU1JBTSBjbG9jayAqLwo+IC0JbXQ4MTkyX3Bvd2VyX29uX3NyYW0o c2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzApOwo+IC0JbXQ4MTkyX3Bvd2Vy X29uX3NyYW0oc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzEpOwo+IC0JbXQ4 MTkyX3Bvd2VyX29uX3NyYW0oc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzIp Owo+IC0JbXQ4MTkyX3Bvd2VyX29uX3NyYW0oc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMVRDTV9T UkFNX1BETik7Cj4gLQltdDgxOTJfcG93ZXJfb25fc3JhbShzY3AtPnJlZ19iYXNlICsgTVQ4MTky X0NQVTBfU1JBTV9QRCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vbihzY3AtPnJlZ19iYXNlICsgTVQ4 MTkyX0wyVENNX1NSQU1fUERfMCwgMCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vbihzY3AtPnJlZ19i YXNlICsgTVQ4MTkyX0wyVENNX1NSQU1fUERfMSwgMCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vbihz Y3AtPnJlZ19iYXNlICsgTVQ4MTkyX0wyVENNX1NSQU1fUERfMiwgMCk7Cj4gKwlzY3Bfc3JhbV9w b3dlcl9vbihzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0wxVENNX1NSQU1fUEROLCAwKTsKPiArCXNj cF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfQ1BVMF9TUkFNX1BELCAwKTsK PiArCj4gKwkvKiBlbmFibGUgTVBVIGZvciBhbGwgbWVtb3J5IHJlZ2lvbnMgKi8KPiArCXdyaXRl bCgweGZmLCBzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0NPUkUwX01FTV9BVFRfUFJFREVGKTsKPiAr Cj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIGludCBtdDgxOTVfc2NwX2JlZm9yZV9s b2FkKHN0cnVjdCBtdGtfc2NwICpzY3ApCj4gK3sKPiArCS8qIGNsZWFyIFNQTSBpbnRlcnJ1cHQs IFNDUDJTUE1fSVBDX0NMUiAqLwo+ICsJd3JpdGVsKDB4ZmYsIHNjcC0+cmVnX2Jhc2UgKyBNVDgx OTJfU0NQMlNQTV9JUENfQ0xSKTsKPiArCj4gKwl3cml0ZWwoMSwgc2NwLT5yZWdfYmFzZSArIE1U ODE5Ml9DT1JFMF9TV19SU1ROX1NFVCk7Cj4gKwo+ICsJLyogZW5hYmxlIFNSQU0gY2xvY2sgKi8K PiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDJUQ01fU1JBTV9Q RF8wLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDJU Q01fU1JBTV9QRF8xLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jhc2UgKyBN VDgxOTJfTDJUQ01fU1JBTV9QRF8yLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVn X2Jhc2UgKyBNVDgxOTJfTDFUQ01fU1JBTV9QRE4sCj4gKwkJCSAgTVQ4MTk1X0wxVENNX1NSQU1f UEROX1JFU0VSVkVEX1JTSV9CSVRTKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jh c2UgKyBNVDgxOTJfQ1BVMF9TUkFNX1BELCAwKTsKPiAgCj4gIAkvKiBlbmFibGUgTVBVIGZvciBh bGwgbWVtb3J5IHJlZ2lvbnMgKi8KPiAgCXdyaXRlbCgweGZmLCBzY3AtPnJlZ19iYXNlICsgTVQ4 MTkyX0NPUkUwX01FTV9BVFRfUFJFREVGKTsKPiBAQCAtNTcyLDExICs1OTMsMjUgQEAgc3RhdGlj IHZvaWQgbXQ4MTgzX3NjcF9zdG9wKHN0cnVjdCBtdGtfc2NwICpzY3ApCj4gIHN0YXRpYyB2b2lk IG10ODE5Ml9zY3Bfc3RvcChzdHJ1Y3QgbXRrX3NjcCAqc2NwKQo+ICB7Cj4gIAkvKiBEaXNhYmxl IFNSQU0gY2xvY2sgKi8KPiAtCW10ODE5Ml9wb3dlcl9vZmZfc3JhbShzY3AtPnJlZ19iYXNlICsg TVQ4MTkyX0wyVENNX1NSQU1fUERfMCk7Cj4gLQltdDgxOTJfcG93ZXJfb2ZmX3NyYW0oc2NwLT5y ZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzEpOwo+IC0JbXQ4MTkyX3Bvd2VyX29mZl9z cmFtKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDJUQ01fU1JBTV9QRF8yKTsKPiAtCW10ODE5Ml9w b3dlcl9vZmZfc3JhbShzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0wxVENNX1NSQU1fUEROKTsKPiAt CW10ODE5Ml9wb3dlcl9vZmZfc3JhbShzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0NQVTBfU1JBTV9Q RCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vZmYoc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9T UkFNX1BEXzAsIDApOwo+ICsJc2NwX3NyYW1fcG93ZXJfb2ZmKHNjcC0+cmVnX2Jhc2UgKyBNVDgx OTJfTDJUQ01fU1JBTV9QRF8xLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29mZihzY3AtPnJlZ19i YXNlICsgTVQ4MTkyX0wyVENNX1NSQU1fUERfMiwgMCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vZmYo c2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMVRDTV9TUkFNX1BETiwgMCk7Cj4gKwlzY3Bfc3JhbV9w b3dlcl9vZmYoc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9DUFUwX1NSQU1fUEQsIDApOwo+ICsKPiAr CS8qIERpc2FibGUgU0NQIHdhdGNoZG9nICovCj4gKwl3cml0ZWwoMCwgc2NwLT5yZWdfYmFzZSAr IE1UODE5Ml9DT1JFMF9XRFRfQ0ZHKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgbXQ4MTk1X3Nj cF9zdG9wKHN0cnVjdCBtdGtfc2NwICpzY3ApCj4gK3sKPiArCS8qIERpc2FibGUgU1JBTSBjbG9j ayAqLwo+ICsJc2NwX3NyYW1fcG93ZXJfb2ZmKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDJUQ01f U1JBTV9QRF8wLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29mZihzY3AtPnJlZ19iYXNlICsgTVQ4 MTkyX0wyVENNX1NSQU1fUERfMSwgMCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vZmYoc2NwLT5yZWdf YmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzIsIDApOwo+ICsJc2NwX3NyYW1fcG93ZXJfb2Zm KHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDFUQ01fU1JBTV9QRE4sCj4gKwkJCSAgIE1UODE5NV9M MVRDTV9TUkFNX1BETl9SRVNFUlZFRF9SU0lfQklUUyk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vZmYo c2NwLT5yZWdfYmFzZSArIE1UODE5Ml9DUFUwX1NSQU1fUEQsIDApOwo+ICAKPiAgCS8qIERpc2Fi bGUgU0NQIHdhdGNoZG9nICovCj4gIAl3cml0ZWwoMCwgc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9D T1JFMF9XRFRfQ0ZHKTsKPiBAQCAtOTIyLDExICs5NTcsMTEgQEAgc3RhdGljIGNvbnN0IHN0cnVj dCBtdGtfc2NwX29mX2RhdGEgbXQ4MTkyX29mX2RhdGEgPSB7Cj4gIAo+ICBzdGF0aWMgY29uc3Qg c3RydWN0IG10a19zY3Bfb2ZfZGF0YSBtdDgxOTVfb2ZfZGF0YSA9IHsKPiAgCS5zY3BfY2xrX2dl dCA9IG10ODE5NV9zY3BfY2xrX2dldCwKPiAtCS5zY3BfYmVmb3JlX2xvYWQgPSBtdDgxOTJfc2Nw X2JlZm9yZV9sb2FkLAo+ICsJLnNjcF9iZWZvcmVfbG9hZCA9IG10ODE5NV9zY3BfYmVmb3JlX2xv YWQsCj4gIAkuc2NwX2lycV9oYW5kbGVyID0gbXQ4MTkyX3NjcF9pcnFfaGFuZGxlciwKPiAgCS5z Y3BfcmVzZXRfYXNzZXJ0ID0gbXQ4MTkyX3NjcF9yZXNldF9hc3NlcnQsCj4gIAkuc2NwX3Jlc2V0 X2RlYXNzZXJ0ID0gbXQ4MTkyX3NjcF9yZXNldF9kZWFzc2VydCwKPiAtCS5zY3Bfc3RvcCA9IG10 ODE5Ml9zY3Bfc3RvcCwKPiArCS5zY3Bfc3RvcCA9IG10ODE5NV9zY3Bfc3RvcCwKPiAgCS5zY3Bf ZGFfdG9fdmEgPSBtdDgxOTJfc2NwX2RhX3RvX3ZhLAo+ICAJLmhvc3RfdG9fc2NwX3JlZyA9IE1U ODE5Ml9HSVBDX0lOX1NFVCwKPiAgCS5ob3N0X3RvX3NjcF9pbnRfYml0ID0gTVQ4MTkyX0hPU1Rf SVBDX0lOVF9CSVQsCgoKICBHRU4gICAgIE1ha2VmaWxlCiAgVVBEICAgICBpbmNsdWRlL2NvbmZp Zy9rZXJuZWwucmVsZWFzZQogIFVQRCAgICAgaW5jbHVkZS9nZW5lcmF0ZWQvdXRzcmVsZWFzZS5o CiAgQ0FMTCAgICAvaG9tZS9tcG9pcmllci93b3JrL3JlbW90ZXByb2Mva2VybmVsLXJldmlldy9z Y3JpcHRzL2F0b21pYy9jaGVjay1hdG9taWNzLnNoCiAgQ0FMTCAgICAvaG9tZS9tcG9pcmllci93 b3JrL3JlbW90ZXByb2Mva2VybmVsLXJldmlldy9zY3JpcHRzL2NoZWNrc3lzY2FsbHMuc2gKICBD SEsgICAgIGluY2x1ZGUvZ2VuZXJhdGVkL2NvbXBpbGUuaAogIENDICAgICAgaW5pdC92ZXJzaW9u Lm8KICBBUiAgICAgIGluaXQvYnVpbHQtaW4uYQogIENDICAgICAga2VybmVsL3N5cy5vCiAgQ0Mg ICAgICBuZXQvZXRodG9vbC9pb2N0bC5vCiAgQ0MgICAgICBrZXJuZWwvbW9kdWxlLm8KICBDQyAg ICAgIGtlcm5lbC90cmFjZS90cmFjZS5vCiAgQ0MgICAgICBkcml2ZXJzL2Jhc2UvZmlybXdhcmVf bG9hZGVyL21haW4ubwogIENDICAgICAgZHJpdmVycy9iYXNlL2Zpcm13YXJlX2xvYWRlci9idWls dGluL21haW4ubwogIEFSICAgICAgbmV0L2V0aHRvb2wvYnVpbHQtaW4uYQogIEFSICAgICAgZHJp dmVycy9iYXNlL2Zpcm13YXJlX2xvYWRlci9idWlsdGluL2J1aWx0LWluLmEKICBBUiAgICAgIG5l dC9idWlsdC1pbi5hCiAgQVIgICAgICBkcml2ZXJzL2Jhc2UvZmlybXdhcmVfbG9hZGVyL2J1aWx0 LWluLmEKICBBUiAgICAgIGRyaXZlcnMvYmFzZS9idWlsdC1pbi5hCiAgQ0MgICAgICBkcml2ZXJz L3JlbW90ZXByb2MvbXRrX3NjcC5vCiAgQ0MgICAgICBkcml2ZXJzL3JlbW90ZXByb2MvbXRrX3Nj cF9pcGkubwogIENDICAgICAgZHJpdmVycy9yYXMvcmFzLm8KICBDQyAgICAgIGRyaXZlcnMvcmVt b3RlcHJvYy9zdG0zMl9ycHJvYy5vCiAgQ0MgICAgICBkcml2ZXJzL252bWVtL2NvcmUubwogIEFS ICAgICAga2VybmVsL3RyYWNlL2J1aWx0LWluLmEKICBBUiAgICAgIGtlcm5lbC9idWlsdC1pbi5h Ci9ob21lL21wb2lyaWVyL3dvcmsvcmVtb3RlcHJvYy9rZXJuZWwtcmV2aWV3L2RyaXZlcnMvcmVt b3RlcHJvYy9tdGtfc2NwLmM6IEluIGZ1bmN0aW9uIOKAmG10ODE4Nl9zY3BfYmVmb3JlX2xvYWTi gJk6Ci9ob21lL21wb2lyaWVyL3dvcmsvcmVtb3RlcHJvYy9rZXJuZWwtcmV2aWV3L2RyaXZlcnMv cmVtb3RlcHJvYy9tdGtfc2NwLmM6Mzk2OjI6IGVycm9yOiBpbXBsaWNpdCBkZWNsYXJhdGlvbiBv ZiBmdW5jdGlvbiDigJhtdDgxOTJfcG93ZXJfb25fc3JhbeKAmSBbLVdlcnJvcj1pbXBsaWNpdC1m dW5jdGlvbi1kZWNsYXJhdGlvbl0KICAzOTYgfCAgbXQ4MTkyX3Bvd2VyX29uX3NyYW0oc2NwLT5y ZWdfYmFzZSArIE1UODE4M19TQ1BfU1JBTV9QRE4pOwogICAgICB8ICBefn5+fn5+fn5+fn5+fn5+ fn5+fgouLi4KCk5vIG5lZWQgdG8gc2VuZCBtZSBhbm90aGVyIHJldmlzaW9uIHJpZ2h0IGF3YXkg LSBJIHdvbid0IGFwcGx5IHlvdXIgY29kZSBmb3IKdGhpcyBtZXJnZSB3aW5kb3cuCgo+IC0tIAo+ IDIuMTguMAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F991C433EF for ; Fri, 18 Mar 2022 16:41:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236116AbiCRQm0 (ORCPT ); Fri, 18 Mar 2022 12:42:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234757AbiCRQmZ (ORCPT ); Fri, 18 Mar 2022 12:42:25 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33E1B1D419A for ; Fri, 18 Mar 2022 09:41:06 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id z3so7370000plg.8 for ; Fri, 18 Mar 2022 09:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YqeA3yzSovnWISu9O1IIYzrK5bErdUVNL8Ziq3eSYwE=; b=WWKSAR2dgARpIW+G+PXd3YLnUwrniUXkKPt4go9LCVGTfI7J10WokWED37htpO3ypO PRWjgCRVpAfvFv+fs3eZMCUSm95FrQTtkg6ASkXVMubxcEWKs/W75JAGMhxCKeTnOPuM nwz7TlEXlYnApEeYVJpKxo40kB3RIcEHdgE6/nnnS9wJGfimhPImk+44654WHfr+rN12 Fv0J1cnKU5hBIPH8NJ/VlmiaAeOvyRzPECfkJftxdXKuFTTiOqLhgp1eHL8Ai7ikHygW Oqt4tlJskcbTGGopUy1m2LHruXrlLjdPTHfb2NfyrhUQta5/BBu8zwaM7Goi9Q9izRnX YKew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YqeA3yzSovnWISu9O1IIYzrK5bErdUVNL8Ziq3eSYwE=; b=png/0MbvXWVrJNOyaHldvX7Tik7YiMva5D94qo7KW1U6XE+qU8X/CYG19lDDGZ/pNc XJNJPw7fRxn6aWFlkDN7zHvAeAA0vK6uxpacBq+6MQ+WriAVmCi1jN94y7mdvRlz9K9L fbrW+CTCrSHfk/DBnjyM61TM9ppVG3FBTUR8IdJDFp4hOiejQC/76W7p0Qkhvnz7a/En fySyWc4iM+ktQfmqGkKMPoKQAiwUMVxcFNy5k4Xnqqs2u+A0hhrVffPoK/S46DryGSt8 cSFI+TK4TmWB4+z6SWD0sd6j9k0FbXEPS6c6XB2PpznxqEoHXMi0IqHE9XlQnqp07SXF lMHw== X-Gm-Message-State: AOAM530Oxe/pobTvTqtjFeZ2ptUwmwTuo7IeIKV5gij42TnZ8QVasUYr c5Z8RzqbXLsxrsyItjtY5tDTng== X-Google-Smtp-Source: ABdhPJyXYHj5tfou62Tf3lMqf0AvHuY99MCgO1pcsZ+JpImXFJRu9csewD/PBr64ga/R0Dzup1yxYw== X-Received: by 2002:a17:902:70cc:b0:154:1cc8:9df8 with SMTP id l12-20020a17090270cc00b001541cc89df8mr333225plt.32.1647621665507; Fri, 18 Mar 2022 09:41:05 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id y8-20020a17090aa40800b001c6ccb2c395sm327061pjp.9.2022.03.18.09.41.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 09:41:04 -0700 (PDT) Date: Fri, 18 Mar 2022 10:41:02 -0600 From: Mathieu Poirier To: Tinghan Shen Cc: Bjorn Andersson , Matthias Brugger , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v5] remoteproc: mediatek: Fix side effect of mt8195 sram power on Message-ID: <20220318164102.GA2898105@p14s> References: <20220318114200.4344-1-tinghan.shen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220318114200.4344-1-tinghan.shen@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Fri, Mar 18, 2022 at 07:42:00PM +0800, Tinghan Shen wrote: > The definition of L1TCM_SRAM_PDN bits on mt8195 is different to mt8192. > > L1TCM_SRAM_PDN bits[3:0] control the power of mt8195 L1TCM SRAM. > > L1TCM_SRAM_PDN bits[7:4] control the access path to EMI for SCP. > These bits have to be powered on to allow EMI access for SCP. > > Bits[7:4] also affect audio DSP because audio DSP and SCP are > placed on the same hardware bus. If SCP cannot access EMI, audio DSP is > blocked too. > > L1TCM_SRAM_PDN bits[31:8] are not used. > > This fix removes modification of bits[7:4] when power on/off mt8195 SCP > L1TCM. It's because the modification introduces a short period of time > blocking audio DSP to access EMI. This was not a problem until we have > to load both SCP module and audio DSP module. audio DSP needs to access > EMI because it has source/data on DRAM. Audio DSP will have unexpected > behavior when it accesses EMI and the SCP driver blocks the EMI path at > the same time. > > Fixes: 79111df414fc ("remoteproc: mediatek: Support mt8195 scp") > Signed-off-by: Tinghan Shen > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: Matthias Brugger > > --- > v5: rebased on rproc-next > v4: add Fixes and Reviewed-by tags > v3: fix build error > v2: apply comments about macro definition and function calls > --- > drivers/remoteproc/mtk_common.h | 2 + > drivers/remoteproc/mtk_scp.c | 67 +++++++++++++++++++++++++-------- > 2 files changed, 53 insertions(+), 16 deletions(-) > > diff --git a/drivers/remoteproc/mtk_common.h b/drivers/remoteproc/mtk_common.h > index 71ce4977cb0b..ea6fa1100a00 100644 > --- a/drivers/remoteproc/mtk_common.h > +++ b/drivers/remoteproc/mtk_common.h > @@ -54,6 +54,8 @@ > #define MT8192_CORE0_WDT_IRQ 0x10030 > #define MT8192_CORE0_WDT_CFG 0x10034 > > +#define MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS GENMASK(7, 4) > + > #define SCP_FW_VER_LEN 32 > #define SCP_SHARE_BUFFER_SIZE 288 > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 38609153bf64..068edf21ea51 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -365,22 +365,22 @@ static int mt8183_scp_before_load(struct mtk_scp *scp) > return 0; > } > > -static void mt8192_power_on_sram(void __iomem *addr) > +static void scp_sram_power_on(void __iomem *addr, u32 reserved_mask) > { > int i; > > for (i = 31; i >= 0; i--) > - writel(GENMASK(i, 0), addr); > + writel(GENMASK(i, 0) & ~reserved_mask, addr); > writel(0, addr); > } > > -static void mt8192_power_off_sram(void __iomem *addr) > +static void scp_sram_power_off(void __iomem *addr, u32 reserved_mask) > { > int i; > > writel(0, addr); > for (i = 0; i < 32; i++) > - writel(GENMASK(i, 0), addr); > + writel(GENMASK(i, 0) & ~reserved_mask, addr); > } > > static int mt8186_scp_before_load(struct mtk_scp *scp) > @@ -412,11 +412,32 @@ static int mt8192_scp_before_load(struct mtk_scp *scp) > writel(1, scp->reg_base + MT8192_CORE0_SW_RSTN_SET); > > /* enable SRAM clock */ > - mt8192_power_on_sram(scp->reg_base + MT8192_L2TCM_SRAM_PD_0); > - mt8192_power_on_sram(scp->reg_base + MT8192_L2TCM_SRAM_PD_1); > - mt8192_power_on_sram(scp->reg_base + MT8192_L2TCM_SRAM_PD_2); > - mt8192_power_on_sram(scp->reg_base + MT8192_L1TCM_SRAM_PDN); > - mt8192_power_on_sram(scp->reg_base + MT8192_CPU0_SRAM_PD); > + scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0); > + scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0); > + scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0); > + scp_sram_power_on(scp->reg_base + MT8192_L1TCM_SRAM_PDN, 0); > + scp_sram_power_on(scp->reg_base + MT8192_CPU0_SRAM_PD, 0); > + > + /* enable MPU for all memory regions */ > + writel(0xff, scp->reg_base + MT8192_CORE0_MEM_ATT_PREDEF); > + > + return 0; > +} > + > +static int mt8195_scp_before_load(struct mtk_scp *scp) > +{ > + /* clear SPM interrupt, SCP2SPM_IPC_CLR */ > + writel(0xff, scp->reg_base + MT8192_SCP2SPM_IPC_CLR); > + > + writel(1, scp->reg_base + MT8192_CORE0_SW_RSTN_SET); > + > + /* enable SRAM clock */ > + scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0); > + scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0); > + scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0); > + scp_sram_power_on(scp->reg_base + MT8192_L1TCM_SRAM_PDN, > + MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS); > + scp_sram_power_on(scp->reg_base + MT8192_CPU0_SRAM_PD, 0); > > /* enable MPU for all memory regions */ > writel(0xff, scp->reg_base + MT8192_CORE0_MEM_ATT_PREDEF); > @@ -572,11 +593,25 @@ static void mt8183_scp_stop(struct mtk_scp *scp) > static void mt8192_scp_stop(struct mtk_scp *scp) > { > /* Disable SRAM clock */ > - mt8192_power_off_sram(scp->reg_base + MT8192_L2TCM_SRAM_PD_0); > - mt8192_power_off_sram(scp->reg_base + MT8192_L2TCM_SRAM_PD_1); > - mt8192_power_off_sram(scp->reg_base + MT8192_L2TCM_SRAM_PD_2); > - mt8192_power_off_sram(scp->reg_base + MT8192_L1TCM_SRAM_PDN); > - mt8192_power_off_sram(scp->reg_base + MT8192_CPU0_SRAM_PD); > + scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0); > + scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0); > + scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0); > + scp_sram_power_off(scp->reg_base + MT8192_L1TCM_SRAM_PDN, 0); > + scp_sram_power_off(scp->reg_base + MT8192_CPU0_SRAM_PD, 0); > + > + /* Disable SCP watchdog */ > + writel(0, scp->reg_base + MT8192_CORE0_WDT_CFG); > +} > + > +static void mt8195_scp_stop(struct mtk_scp *scp) > +{ > + /* Disable SRAM clock */ > + scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0); > + scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0); > + scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0); > + scp_sram_power_off(scp->reg_base + MT8192_L1TCM_SRAM_PDN, > + MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS); > + scp_sram_power_off(scp->reg_base + MT8192_CPU0_SRAM_PD, 0); > > /* Disable SCP watchdog */ > writel(0, scp->reg_base + MT8192_CORE0_WDT_CFG); > @@ -922,11 +957,11 @@ static const struct mtk_scp_of_data mt8192_of_data = { > > static const struct mtk_scp_of_data mt8195_of_data = { > .scp_clk_get = mt8195_scp_clk_get, > - .scp_before_load = mt8192_scp_before_load, > + .scp_before_load = mt8195_scp_before_load, > .scp_irq_handler = mt8192_scp_irq_handler, > .scp_reset_assert = mt8192_scp_reset_assert, > .scp_reset_deassert = mt8192_scp_reset_deassert, > - .scp_stop = mt8192_scp_stop, > + .scp_stop = mt8195_scp_stop, > .scp_da_to_va = mt8192_scp_da_to_va, > .host_to_scp_reg = MT8192_GIPC_IN_SET, > .host_to_scp_int_bit = MT8192_HOST_IPC_INT_BIT, GEN Makefile UPD include/config/kernel.release UPD include/generated/utsrelease.h CALL /home/mpoirier/work/remoteproc/kernel-review/scripts/atomic/check-atomics.sh CALL /home/mpoirier/work/remoteproc/kernel-review/scripts/checksyscalls.sh CHK include/generated/compile.h CC init/version.o AR init/built-in.a CC kernel/sys.o CC net/ethtool/ioctl.o CC kernel/module.o CC kernel/trace/trace.o CC drivers/base/firmware_loader/main.o CC drivers/base/firmware_loader/builtin/main.o AR net/ethtool/built-in.a AR drivers/base/firmware_loader/builtin/built-in.a AR net/built-in.a AR drivers/base/firmware_loader/built-in.a AR drivers/base/built-in.a CC drivers/remoteproc/mtk_scp.o CC drivers/remoteproc/mtk_scp_ipi.o CC drivers/ras/ras.o CC drivers/remoteproc/stm32_rproc.o CC drivers/nvmem/core.o AR kernel/trace/built-in.a AR kernel/built-in.a /home/mpoirier/work/remoteproc/kernel-review/drivers/remoteproc/mtk_scp.c: In function ‘mt8186_scp_before_load’: /home/mpoirier/work/remoteproc/kernel-review/drivers/remoteproc/mtk_scp.c:396:2: error: implicit declaration of function ‘mt8192_power_on_sram’ [-Werror=implicit-function-declaration] 396 | mt8192_power_on_sram(scp->reg_base + MT8183_SCP_SRAM_PDN); | ^~~~~~~~~~~~~~~~~~~~ ... No need to send me another revision right away - I won't apply your code for this merge window. > -- > 2.18.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 701C1C433EF for ; Fri, 18 Mar 2022 16:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+XiaaKWMPZs1Mc4gs0gJoHFAmdzGiDnKEpTy5SwrUfc=; b=nP5bdCbo8G34FR KWH0mgJkXAR63wUiTXcBzLDmIWrFZFZdaatXKtzt5M/fGSnXMgtjpabvtiM3j26HNfTGxJD9n/Mel xtrhG3tGIoHuPpGwwGhD/q8QyF3gxrZXitELGcI5ogzTjCbqqt+WBYgfgAwwxdzladCMVt5+0onQs 9J9wq0QaCFlls0UKdXpeCcjDWWPI1hpHd+vq09xjrCUIxer7n0SJdj+CBPvxaGloU4bt/ibyKGA0j mM0yboeOcieZBbz/YsYjI7hZNHw8H4EUYOxAicWFaCabx7e0FLNZ0Td1E9RlqMggp1o11DqyVYJ6V 7yI/2iNmjnc2I6xZJtXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVFf5-002QNE-RL; Fri, 18 Mar 2022 16:41:12 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVFf1-002QM6-Hp for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 16:41:09 +0000 Received: by mail-pl1-x62f.google.com with SMTP id p17so7364978plo.9 for ; Fri, 18 Mar 2022 09:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YqeA3yzSovnWISu9O1IIYzrK5bErdUVNL8Ziq3eSYwE=; b=WWKSAR2dgARpIW+G+PXd3YLnUwrniUXkKPt4go9LCVGTfI7J10WokWED37htpO3ypO PRWjgCRVpAfvFv+fs3eZMCUSm95FrQTtkg6ASkXVMubxcEWKs/W75JAGMhxCKeTnOPuM nwz7TlEXlYnApEeYVJpKxo40kB3RIcEHdgE6/nnnS9wJGfimhPImk+44654WHfr+rN12 Fv0J1cnKU5hBIPH8NJ/VlmiaAeOvyRzPECfkJftxdXKuFTTiOqLhgp1eHL8Ai7ikHygW Oqt4tlJskcbTGGopUy1m2LHruXrlLjdPTHfb2NfyrhUQta5/BBu8zwaM7Goi9Q9izRnX YKew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YqeA3yzSovnWISu9O1IIYzrK5bErdUVNL8Ziq3eSYwE=; b=3YIWy5227IVwYb8h6svMyDzf0F/8uvWv0H1+RoEfr8ud0vyS45Pm7UjIpPkJ/VNTot nwn0s80idSU3+pXi0h8JpuPZSq/xUCva2V7w0OTTGK+n2Sq1IFOhg57VhrI8036uYfJ0 Ht13JQ+dArCSe7MalK9bJLUm5ikXgxTgjLoUku6uvl9ssJwW/VSg2NvL5QI4329OCfBk SM+JIh4y+bTNYkCmwZHX/S+IvBa0BynghLGU6k+Sm3PPLodtWW6Kmtg4MD0WJBHRlnoM H0RiMBYeBBcOGLhSUrG0tfz66QvWIh3kJeBvjYTYG+z9QugVfbyntaqzytfPCuEHUQSa 8xXQ== X-Gm-Message-State: AOAM532Bbpue8SGOlY6vWWEfA5wHpk/lIt64iNOZ5DkbsoisSyVPB1Ib aUSk5LAKHn1ZfsE+frjJIjsd5w== X-Google-Smtp-Source: ABdhPJyXYHj5tfou62Tf3lMqf0AvHuY99MCgO1pcsZ+JpImXFJRu9csewD/PBr64ga/R0Dzup1yxYw== X-Received: by 2002:a17:902:70cc:b0:154:1cc8:9df8 with SMTP id l12-20020a17090270cc00b001541cc89df8mr333225plt.32.1647621665507; Fri, 18 Mar 2022 09:41:05 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id y8-20020a17090aa40800b001c6ccb2c395sm327061pjp.9.2022.03.18.09.41.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 09:41:04 -0700 (PDT) Date: Fri, 18 Mar 2022 10:41:02 -0600 From: Mathieu Poirier To: Tinghan Shen Cc: Bjorn Andersson , Matthias Brugger , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v5] remoteproc: mediatek: Fix side effect of mt8195 sram power on Message-ID: <20220318164102.GA2898105@p14s> References: <20220318114200.4344-1-tinghan.shen@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220318114200.4344-1-tinghan.shen@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_094107_651258_155C860F X-CRM114-Status: GOOD ( 31.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgMTgsIDIwMjIgYXQgMDc6NDI6MDBQTSArMDgwMCwgVGluZ2hhbiBTaGVuIHdy b3RlOgo+IFRoZSBkZWZpbml0aW9uIG9mIEwxVENNX1NSQU1fUEROIGJpdHMgb24gbXQ4MTk1IGlz IGRpZmZlcmVudCB0byBtdDgxOTIuCj4gCj4gTDFUQ01fU1JBTV9QRE4gYml0c1szOjBdIGNvbnRy b2wgdGhlIHBvd2VyIG9mIG10ODE5NSBMMVRDTSBTUkFNLgo+IAo+IEwxVENNX1NSQU1fUEROIGJp dHNbNzo0XSBjb250cm9sIHRoZSBhY2Nlc3MgcGF0aCB0byBFTUkgZm9yIFNDUC4KPiBUaGVzZSBi aXRzIGhhdmUgdG8gYmUgcG93ZXJlZCBvbiB0byBhbGxvdyBFTUkgYWNjZXNzIGZvciBTQ1AuCj4g Cj4gQml0c1s3OjRdIGFsc28gYWZmZWN0IGF1ZGlvIERTUCBiZWNhdXNlIGF1ZGlvIERTUCBhbmQg U0NQIGFyZQo+IHBsYWNlZCBvbiB0aGUgc2FtZSBoYXJkd2FyZSBidXMuIElmIFNDUCBjYW5ub3Qg YWNjZXNzIEVNSSwgYXVkaW8gRFNQIGlzCj4gYmxvY2tlZCB0b28uCj4gCj4gTDFUQ01fU1JBTV9Q RE4gYml0c1szMTo4XSBhcmUgbm90IHVzZWQuCj4gCj4gVGhpcyBmaXggcmVtb3ZlcyBtb2RpZmlj YXRpb24gb2YgYml0c1s3OjRdIHdoZW4gcG93ZXIgb24vb2ZmIG10ODE5NSBTQ1AKPiBMMVRDTS4g SXQncyBiZWNhdXNlIHRoZSBtb2RpZmljYXRpb24gaW50cm9kdWNlcyBhIHNob3J0IHBlcmlvZCBv ZiB0aW1lCj4gYmxvY2tpbmcgYXVkaW8gRFNQIHRvIGFjY2VzcyBFTUkuIFRoaXMgd2FzIG5vdCBh IHByb2JsZW0gdW50aWwgd2UgaGF2ZQo+IHRvIGxvYWQgYm90aCBTQ1AgbW9kdWxlIGFuZCBhdWRp byBEU1AgbW9kdWxlLiBhdWRpbyBEU1AgbmVlZHMgdG8gYWNjZXNzCj4gRU1JIGJlY2F1c2UgaXQg aGFzIHNvdXJjZS9kYXRhIG9uIERSQU0uIEF1ZGlvIERTUCB3aWxsIGhhdmUgdW5leHBlY3RlZAo+ IGJlaGF2aW9yIHdoZW4gaXQgYWNjZXNzZXMgRU1JIGFuZCB0aGUgU0NQIGRyaXZlciBibG9ja3Mg dGhlIEVNSSBwYXRoIGF0Cj4gdGhlIHNhbWUgdGltZS4KPiAKPiBGaXhlczogNzkxMTFkZjQxNGZj ICgicmVtb3RlcHJvYzogbWVkaWF0ZWs6IFN1cHBvcnQgbXQ4MTk1IHNjcCIpCj4gU2lnbmVkLW9m Zi1ieTogVGluZ2hhbiBTaGVuIDx0aW5naGFuLnNoZW5AbWVkaWF0ZWsuY29tPgo+IFJldmlld2Vk LWJ5OiBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyA8YW5nZWxvZ2lvYWNjaGluby5kZWxyZWdu b0Bjb2xsYWJvcmEuY29tPgo+IFJldmlld2VkLWJ5OiBNYXR0aGlhcyBCcnVnZ2VyIDxtYXR0aGlh cy5iZ2dAZ21haWwuY29tPgo+IAo+IC0tLQo+IHY1OiByZWJhc2VkIG9uIHJwcm9jLW5leHQKPiB2 NDogYWRkIEZpeGVzIGFuZCBSZXZpZXdlZC1ieSB0YWdzCj4gdjM6IGZpeCBidWlsZCBlcnJvcgo+ IHYyOiBhcHBseSBjb21tZW50cyBhYm91dCBtYWNybyBkZWZpbml0aW9uIGFuZCBmdW5jdGlvbiBj YWxscwo+IC0tLQo+ICBkcml2ZXJzL3JlbW90ZXByb2MvbXRrX2NvbW1vbi5oIHwgIDIgKwo+ICBk cml2ZXJzL3JlbW90ZXByb2MvbXRrX3NjcC5jICAgIHwgNjcgKysrKysrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKSwgMTYgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcmVtb3RlcHJvYy9tdGtfY29tbW9u LmggYi9kcml2ZXJzL3JlbW90ZXByb2MvbXRrX2NvbW1vbi5oCj4gaW5kZXggNzFjZTQ5NzdjYjBi Li5lYTZmYTExMDBhMDAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9yZW1vdGVwcm9jL210a19jb21t b24uaAo+ICsrKyBiL2RyaXZlcnMvcmVtb3RlcHJvYy9tdGtfY29tbW9uLmgKPiBAQCAtNTQsNiAr NTQsOCBAQAo+ICAjZGVmaW5lIE1UODE5Ml9DT1JFMF9XRFRfSVJRCQkweDEwMDMwCj4gICNkZWZp bmUgTVQ4MTkyX0NPUkUwX1dEVF9DRkcJCTB4MTAwMzQKPiAgCj4gKyNkZWZpbmUgTVQ4MTk1X0wx VENNX1NSQU1fUEROX1JFU0VSVkVEX1JTSV9CSVRTCQlHRU5NQVNLKDcsIDQpCj4gKwo+ICAjZGVm aW5lIFNDUF9GV19WRVJfTEVOCQkJMzIKPiAgI2RlZmluZSBTQ1BfU0hBUkVfQlVGRkVSX1NJWkUJ CTI4OAo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9yZW1vdGVwcm9jL210a19zY3AuYyBiL2Ry aXZlcnMvcmVtb3RlcHJvYy9tdGtfc2NwLmMKPiBpbmRleCAzODYwOTE1M2JmNjQuLjA2OGVkZjIx ZWE1MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3JlbW90ZXByb2MvbXRrX3NjcC5jCj4gKysrIGIv ZHJpdmVycy9yZW1vdGVwcm9jL210a19zY3AuYwo+IEBAIC0zNjUsMjIgKzM2NSwyMiBAQCBzdGF0 aWMgaW50IG10ODE4M19zY3BfYmVmb3JlX2xvYWQoc3RydWN0IG10a19zY3AgKnNjcCkKPiAgCXJl dHVybiAwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBtdDgxOTJfcG93ZXJfb25fc3JhbSh2b2lk IF9faW9tZW0gKmFkZHIpCj4gK3N0YXRpYyB2b2lkIHNjcF9zcmFtX3Bvd2VyX29uKHZvaWQgX19p b21lbSAqYWRkciwgdTMyIHJlc2VydmVkX21hc2spCj4gIHsKPiAgCWludCBpOwo+ICAKPiAgCWZv ciAoaSA9IDMxOyBpID49IDA7IGktLSkKPiAtCQl3cml0ZWwoR0VOTUFTSyhpLCAwKSwgYWRkcik7 Cj4gKwkJd3JpdGVsKEdFTk1BU0soaSwgMCkgJiB+cmVzZXJ2ZWRfbWFzaywgYWRkcik7Cj4gIAl3 cml0ZWwoMCwgYWRkcik7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIG10ODE5Ml9wb3dlcl9vZmZf c3JhbSh2b2lkIF9faW9tZW0gKmFkZHIpCj4gK3N0YXRpYyB2b2lkIHNjcF9zcmFtX3Bvd2VyX29m Zih2b2lkIF9faW9tZW0gKmFkZHIsIHUzMiByZXNlcnZlZF9tYXNrKQo+ICB7Cj4gIAlpbnQgaTsK PiAgCj4gIAl3cml0ZWwoMCwgYWRkcik7Cj4gIAlmb3IgKGkgPSAwOyBpIDwgMzI7IGkrKykKPiAt CQl3cml0ZWwoR0VOTUFTSyhpLCAwKSwgYWRkcik7Cj4gKwkJd3JpdGVsKEdFTk1BU0soaSwgMCkg JiB+cmVzZXJ2ZWRfbWFzaywgYWRkcik7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgbXQ4MTg2X3Nj cF9iZWZvcmVfbG9hZChzdHJ1Y3QgbXRrX3NjcCAqc2NwKQo+IEBAIC00MTIsMTEgKzQxMiwzMiBA QCBzdGF0aWMgaW50IG10ODE5Ml9zY3BfYmVmb3JlX2xvYWQoc3RydWN0IG10a19zY3AgKnNjcCkK PiAgCXdyaXRlbCgxLCBzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0NPUkUwX1NXX1JTVE5fU0VUKTsK PiAgCj4gIAkvKiBlbmFibGUgU1JBTSBjbG9jayAqLwo+IC0JbXQ4MTkyX3Bvd2VyX29uX3NyYW0o c2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzApOwo+IC0JbXQ4MTkyX3Bvd2Vy X29uX3NyYW0oc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzEpOwo+IC0JbXQ4 MTkyX3Bvd2VyX29uX3NyYW0oc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzIp Owo+IC0JbXQ4MTkyX3Bvd2VyX29uX3NyYW0oc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMVRDTV9T UkFNX1BETik7Cj4gLQltdDgxOTJfcG93ZXJfb25fc3JhbShzY3AtPnJlZ19iYXNlICsgTVQ4MTky X0NQVTBfU1JBTV9QRCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vbihzY3AtPnJlZ19iYXNlICsgTVQ4 MTkyX0wyVENNX1NSQU1fUERfMCwgMCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vbihzY3AtPnJlZ19i YXNlICsgTVQ4MTkyX0wyVENNX1NSQU1fUERfMSwgMCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vbihz Y3AtPnJlZ19iYXNlICsgTVQ4MTkyX0wyVENNX1NSQU1fUERfMiwgMCk7Cj4gKwlzY3Bfc3JhbV9w b3dlcl9vbihzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0wxVENNX1NSQU1fUEROLCAwKTsKPiArCXNj cF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfQ1BVMF9TUkFNX1BELCAwKTsK PiArCj4gKwkvKiBlbmFibGUgTVBVIGZvciBhbGwgbWVtb3J5IHJlZ2lvbnMgKi8KPiArCXdyaXRl bCgweGZmLCBzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0NPUkUwX01FTV9BVFRfUFJFREVGKTsKPiAr Cj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIGludCBtdDgxOTVfc2NwX2JlZm9yZV9s b2FkKHN0cnVjdCBtdGtfc2NwICpzY3ApCj4gK3sKPiArCS8qIGNsZWFyIFNQTSBpbnRlcnJ1cHQs IFNDUDJTUE1fSVBDX0NMUiAqLwo+ICsJd3JpdGVsKDB4ZmYsIHNjcC0+cmVnX2Jhc2UgKyBNVDgx OTJfU0NQMlNQTV9JUENfQ0xSKTsKPiArCj4gKwl3cml0ZWwoMSwgc2NwLT5yZWdfYmFzZSArIE1U ODE5Ml9DT1JFMF9TV19SU1ROX1NFVCk7Cj4gKwo+ICsJLyogZW5hYmxlIFNSQU0gY2xvY2sgKi8K PiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDJUQ01fU1JBTV9Q RF8wLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDJU Q01fU1JBTV9QRF8xLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jhc2UgKyBN VDgxOTJfTDJUQ01fU1JBTV9QRF8yLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVn X2Jhc2UgKyBNVDgxOTJfTDFUQ01fU1JBTV9QRE4sCj4gKwkJCSAgTVQ4MTk1X0wxVENNX1NSQU1f UEROX1JFU0VSVkVEX1JTSV9CSVRTKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29uKHNjcC0+cmVnX2Jh c2UgKyBNVDgxOTJfQ1BVMF9TUkFNX1BELCAwKTsKPiAgCj4gIAkvKiBlbmFibGUgTVBVIGZvciBh bGwgbWVtb3J5IHJlZ2lvbnMgKi8KPiAgCXdyaXRlbCgweGZmLCBzY3AtPnJlZ19iYXNlICsgTVQ4 MTkyX0NPUkUwX01FTV9BVFRfUFJFREVGKTsKPiBAQCAtNTcyLDExICs1OTMsMjUgQEAgc3RhdGlj IHZvaWQgbXQ4MTgzX3NjcF9zdG9wKHN0cnVjdCBtdGtfc2NwICpzY3ApCj4gIHN0YXRpYyB2b2lk IG10ODE5Ml9zY3Bfc3RvcChzdHJ1Y3QgbXRrX3NjcCAqc2NwKQo+ICB7Cj4gIAkvKiBEaXNhYmxl IFNSQU0gY2xvY2sgKi8KPiAtCW10ODE5Ml9wb3dlcl9vZmZfc3JhbShzY3AtPnJlZ19iYXNlICsg TVQ4MTkyX0wyVENNX1NSQU1fUERfMCk7Cj4gLQltdDgxOTJfcG93ZXJfb2ZmX3NyYW0oc2NwLT5y ZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzEpOwo+IC0JbXQ4MTkyX3Bvd2VyX29mZl9z cmFtKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDJUQ01fU1JBTV9QRF8yKTsKPiAtCW10ODE5Ml9w b3dlcl9vZmZfc3JhbShzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0wxVENNX1NSQU1fUEROKTsKPiAt CW10ODE5Ml9wb3dlcl9vZmZfc3JhbShzY3AtPnJlZ19iYXNlICsgTVQ4MTkyX0NQVTBfU1JBTV9Q RCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vZmYoc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMlRDTV9T UkFNX1BEXzAsIDApOwo+ICsJc2NwX3NyYW1fcG93ZXJfb2ZmKHNjcC0+cmVnX2Jhc2UgKyBNVDgx OTJfTDJUQ01fU1JBTV9QRF8xLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29mZihzY3AtPnJlZ19i YXNlICsgTVQ4MTkyX0wyVENNX1NSQU1fUERfMiwgMCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vZmYo c2NwLT5yZWdfYmFzZSArIE1UODE5Ml9MMVRDTV9TUkFNX1BETiwgMCk7Cj4gKwlzY3Bfc3JhbV9w b3dlcl9vZmYoc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9DUFUwX1NSQU1fUEQsIDApOwo+ICsKPiAr CS8qIERpc2FibGUgU0NQIHdhdGNoZG9nICovCj4gKwl3cml0ZWwoMCwgc2NwLT5yZWdfYmFzZSAr IE1UODE5Ml9DT1JFMF9XRFRfQ0ZHKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgbXQ4MTk1X3Nj cF9zdG9wKHN0cnVjdCBtdGtfc2NwICpzY3ApCj4gK3sKPiArCS8qIERpc2FibGUgU1JBTSBjbG9j ayAqLwo+ICsJc2NwX3NyYW1fcG93ZXJfb2ZmKHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDJUQ01f U1JBTV9QRF8wLCAwKTsKPiArCXNjcF9zcmFtX3Bvd2VyX29mZihzY3AtPnJlZ19iYXNlICsgTVQ4 MTkyX0wyVENNX1NSQU1fUERfMSwgMCk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vZmYoc2NwLT5yZWdf YmFzZSArIE1UODE5Ml9MMlRDTV9TUkFNX1BEXzIsIDApOwo+ICsJc2NwX3NyYW1fcG93ZXJfb2Zm KHNjcC0+cmVnX2Jhc2UgKyBNVDgxOTJfTDFUQ01fU1JBTV9QRE4sCj4gKwkJCSAgIE1UODE5NV9M MVRDTV9TUkFNX1BETl9SRVNFUlZFRF9SU0lfQklUUyk7Cj4gKwlzY3Bfc3JhbV9wb3dlcl9vZmYo c2NwLT5yZWdfYmFzZSArIE1UODE5Ml9DUFUwX1NSQU1fUEQsIDApOwo+ICAKPiAgCS8qIERpc2Fi bGUgU0NQIHdhdGNoZG9nICovCj4gIAl3cml0ZWwoMCwgc2NwLT5yZWdfYmFzZSArIE1UODE5Ml9D T1JFMF9XRFRfQ0ZHKTsKPiBAQCAtOTIyLDExICs5NTcsMTEgQEAgc3RhdGljIGNvbnN0IHN0cnVj dCBtdGtfc2NwX29mX2RhdGEgbXQ4MTkyX29mX2RhdGEgPSB7Cj4gIAo+ICBzdGF0aWMgY29uc3Qg c3RydWN0IG10a19zY3Bfb2ZfZGF0YSBtdDgxOTVfb2ZfZGF0YSA9IHsKPiAgCS5zY3BfY2xrX2dl dCA9IG10ODE5NV9zY3BfY2xrX2dldCwKPiAtCS5zY3BfYmVmb3JlX2xvYWQgPSBtdDgxOTJfc2Nw X2JlZm9yZV9sb2FkLAo+ICsJLnNjcF9iZWZvcmVfbG9hZCA9IG10ODE5NV9zY3BfYmVmb3JlX2xv YWQsCj4gIAkuc2NwX2lycV9oYW5kbGVyID0gbXQ4MTkyX3NjcF9pcnFfaGFuZGxlciwKPiAgCS5z Y3BfcmVzZXRfYXNzZXJ0ID0gbXQ4MTkyX3NjcF9yZXNldF9hc3NlcnQsCj4gIAkuc2NwX3Jlc2V0 X2RlYXNzZXJ0ID0gbXQ4MTkyX3NjcF9yZXNldF9kZWFzc2VydCwKPiAtCS5zY3Bfc3RvcCA9IG10 ODE5Ml9zY3Bfc3RvcCwKPiArCS5zY3Bfc3RvcCA9IG10ODE5NV9zY3Bfc3RvcCwKPiAgCS5zY3Bf ZGFfdG9fdmEgPSBtdDgxOTJfc2NwX2RhX3RvX3ZhLAo+ICAJLmhvc3RfdG9fc2NwX3JlZyA9IE1U ODE5Ml9HSVBDX0lOX1NFVCwKPiAgCS5ob3N0X3RvX3NjcF9pbnRfYml0ID0gTVQ4MTkyX0hPU1Rf SVBDX0lOVF9CSVQsCgoKICBHRU4gICAgIE1ha2VmaWxlCiAgVVBEICAgICBpbmNsdWRlL2NvbmZp Zy9rZXJuZWwucmVsZWFzZQogIFVQRCAgICAgaW5jbHVkZS9nZW5lcmF0ZWQvdXRzcmVsZWFzZS5o CiAgQ0FMTCAgICAvaG9tZS9tcG9pcmllci93b3JrL3JlbW90ZXByb2Mva2VybmVsLXJldmlldy9z Y3JpcHRzL2F0b21pYy9jaGVjay1hdG9taWNzLnNoCiAgQ0FMTCAgICAvaG9tZS9tcG9pcmllci93 b3JrL3JlbW90ZXByb2Mva2VybmVsLXJldmlldy9zY3JpcHRzL2NoZWNrc3lzY2FsbHMuc2gKICBD SEsgICAgIGluY2x1ZGUvZ2VuZXJhdGVkL2NvbXBpbGUuaAogIENDICAgICAgaW5pdC92ZXJzaW9u Lm8KICBBUiAgICAgIGluaXQvYnVpbHQtaW4uYQogIENDICAgICAga2VybmVsL3N5cy5vCiAgQ0Mg ICAgICBuZXQvZXRodG9vbC9pb2N0bC5vCiAgQ0MgICAgICBrZXJuZWwvbW9kdWxlLm8KICBDQyAg ICAgIGtlcm5lbC90cmFjZS90cmFjZS5vCiAgQ0MgICAgICBkcml2ZXJzL2Jhc2UvZmlybXdhcmVf bG9hZGVyL21haW4ubwogIENDICAgICAgZHJpdmVycy9iYXNlL2Zpcm13YXJlX2xvYWRlci9idWls dGluL21haW4ubwogIEFSICAgICAgbmV0L2V0aHRvb2wvYnVpbHQtaW4uYQogIEFSICAgICAgZHJp dmVycy9iYXNlL2Zpcm13YXJlX2xvYWRlci9idWlsdGluL2J1aWx0LWluLmEKICBBUiAgICAgIG5l dC9idWlsdC1pbi5hCiAgQVIgICAgICBkcml2ZXJzL2Jhc2UvZmlybXdhcmVfbG9hZGVyL2J1aWx0 LWluLmEKICBBUiAgICAgIGRyaXZlcnMvYmFzZS9idWlsdC1pbi5hCiAgQ0MgICAgICBkcml2ZXJz L3JlbW90ZXByb2MvbXRrX3NjcC5vCiAgQ0MgICAgICBkcml2ZXJzL3JlbW90ZXByb2MvbXRrX3Nj cF9pcGkubwogIENDICAgICAgZHJpdmVycy9yYXMvcmFzLm8KICBDQyAgICAgIGRyaXZlcnMvcmVt b3RlcHJvYy9zdG0zMl9ycHJvYy5vCiAgQ0MgICAgICBkcml2ZXJzL252bWVtL2NvcmUubwogIEFS ICAgICAga2VybmVsL3RyYWNlL2J1aWx0LWluLmEKICBBUiAgICAgIGtlcm5lbC9idWlsdC1pbi5h Ci9ob21lL21wb2lyaWVyL3dvcmsvcmVtb3RlcHJvYy9rZXJuZWwtcmV2aWV3L2RyaXZlcnMvcmVt b3RlcHJvYy9tdGtfc2NwLmM6IEluIGZ1bmN0aW9uIOKAmG10ODE4Nl9zY3BfYmVmb3JlX2xvYWTi gJk6Ci9ob21lL21wb2lyaWVyL3dvcmsvcmVtb3RlcHJvYy9rZXJuZWwtcmV2aWV3L2RyaXZlcnMv cmVtb3RlcHJvYy9tdGtfc2NwLmM6Mzk2OjI6IGVycm9yOiBpbXBsaWNpdCBkZWNsYXJhdGlvbiBv ZiBmdW5jdGlvbiDigJhtdDgxOTJfcG93ZXJfb25fc3JhbeKAmSBbLVdlcnJvcj1pbXBsaWNpdC1m dW5jdGlvbi1kZWNsYXJhdGlvbl0KICAzOTYgfCAgbXQ4MTkyX3Bvd2VyX29uX3NyYW0oc2NwLT5y ZWdfYmFzZSArIE1UODE4M19TQ1BfU1JBTV9QRE4pOwogICAgICB8ICBefn5+fn5+fn5+fn5+fn5+ fn5+fgouLi4KCk5vIG5lZWQgdG8gc2VuZCBtZSBhbm90aGVyIHJldmlzaW9uIHJpZ2h0IGF3YXkg LSBJIHdvbid0IGFwcGx5IHlvdXIgY29kZSBmb3IKdGhpcyBtZXJnZSB3aW5kb3cuCgo+IC0tIAo+ IDIuMTguMAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=