All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 5/5] package/wget: bump version to 1.21.3
Date: Fri, 18 Mar 2022 21:50:22 +0100	[thread overview]
Message-ID: <20220318215022.31a913e5@gmx.net> (raw)
In-Reply-To: <20220318202044.10413-5-ps.report@gmx.net>

Hello *,

On Fri, 18 Mar 2022 21:20:44 +0100, Peter Seiderer <ps.report@gmx.net> wrote:

> - bump version to 1.21.3 (for details see [1])
>
> - remove legacy --with-libidn option (see [2]), replace with
>   --enable-iri option in case locale support and libidn2 are available
>
> [1] https://lists.gnu.org/archive/html/info-gnu/2022-02/msg00017.html
> [2] https://git.savannah.gnu.org/cgit/wget.git/commit/configure.ac?id=a24e67e239ef949cc77a4c4e5a0beb703026a296
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
>   - split out from original patch
>   - fix iri option enable dependency
> ---
>  package/wget/wget.hash |  4 ++--
>  package/wget/wget.mk   | 14 ++++++--------
>  2 files changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/package/wget/wget.hash b/package/wget/wget.hash
> index 7f89bedb88..22674650a2 100644
> --- a/package/wget/wget.hash
> +++ b/package/wget/wget.hash
> @@ -1,6 +1,6 @@
>  # Locally calculated after checking pgp signature
> -# https://ftp.gnu.org/gnu/wget/wget-1.21.2.tar.lz.sig
> +# https://ftp.gnu.org/gnu/wget/wget-1.21.3.tar.lz.sig
>  # with key 6B98F637D879C5236E277C5C64FF90AAE8C70AF9
> -sha256  1727a330a86acacb3e57615ce268f5f29978bf7adec4abe6a30d370207bc91b3  wget-1.21.2.tar.lz
> +sha256  dbd2fb5e47149d4752d0eaa0dac68cc49cf20d46df4f8e326ffc8f18b2af4ea5  wget-1.21.3.tar.lz
>  # Locally calculated
>  sha256  e79e9c8a0c85d735ff98185918ec94ed7d175efc377012787aebcf3b80f0d90b  COPYING
> diff --git a/package/wget/wget.mk b/package/wget/wget.mk
> index 69ca8f261c..079afbee48 100644
> --- a/package/wget/wget.mk
> +++ b/package/wget/wget.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>
> -WGET_VERSION = 1.21.2
> +WGET_VERSION = 1.21.3
>  WGET_SOURCE = wget-$(WGET_VERSION).tar.lz
>  WGET_SITE = $(BR2_GNU_MIRROR)/wget
>  WGET_DEPENDENCIES = host-pkgconf
> @@ -38,15 +38,13 @@ else
>  WGET_CONF_OPTS += --without-ssl
>  endif
>
> -ifeq ($(BR2_PACKAGE_LIBICONV),y)
> -WGET_DEPENDENCIES += libiconv
> -endif

The above code one should be kept as there is at least one other
location in the source using iconv (protexted by '#ifdef HAVE_ICONV',
see src/url.c)...

> -
> -ifeq ($(BR2_PACKAGE_LIBIDN2),y)
> -WGET_CONF_OPTS += --with-libidn
> +# BR2_ENABLE_LOCALE and BR2_PACKAGE_LIBICONV are mutually exclusive
> +ifeq ($(BR2_ENABLE_LOCALE)$(BR2_PACKAGE_LIBICONV)$(BR2_PACKAGE_LIBIDN2),yy)
> +WGET_CONF_OPTS += --enable-iri
>  WGET_DEPENDENCIES += libidn2
> +WGET_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv)

And so the above line can be removed...

Will send an updated patch set...

Regards,
Peter

>  else
> -WGET_CONF_OPTS += --without-libidn
> +WGET_CONF_OPTS += --disable-iri
>  endif
>
>  ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBUUID),y)

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-03-18 20:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 20:20 [Buildroot] [PATCH v2 1/5] package/wget: explicit set some default options Peter Seiderer
2022-03-18 20:20 ` [Buildroot] [PATCH v2 2/5] package/wget: use explicit --with/without-libuuid option Peter Seiderer
2022-03-18 21:27   ` Yann E. MORIN
2022-03-21 12:21   ` Peter Korsgaard
2022-03-18 20:20 ` [Buildroot] [PATCH v2 3/5] package/wget: add optional libpsl dependency Peter Seiderer
2022-03-18 21:34   ` Yann E. MORIN
2022-03-21 12:21   ` Peter Korsgaard
2022-03-18 20:20 ` [Buildroot] [PATCH v2 4/5] package/wget: add optional c-ares dependency Peter Seiderer
2022-03-18 21:33   ` Yann E. MORIN
2022-03-21 12:22   ` Peter Korsgaard
2022-03-18 20:20 ` [Buildroot] [PATCH v2 5/5] package/wget: bump version to 1.21.3 Peter Seiderer
2022-03-18 20:50   ` Peter Seiderer [this message]
2022-03-18 21:25 ` [Buildroot] [PATCH v2 1/5] package/wget: explicit set some default options Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220318215022.31a913e5@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.