Re: [Buildroot] [PATCH 1/1] package/wireplumber: fix introspection build

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Fabrice, All,

On 2022-03-18 22:58 +0100, Fabrice Fontaine spake thusly:
> Le ven. 18 mars 2022 à 22:50, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
> > On 2022-03-18 20:33 +0100, Fabrice Fontaine spake thusly:
> > > introspection needs host-doxygen and host-python-lxml since the addition
> > > of the package in commit c9a3c10417aadce9ee4922e30235776409ce8eb3 and
> > > https://gitlab.freedesktop.org/pipewire/wireplumber/-/commit/2e5b13f970fe3dd28a4ce75868d46403034c6822
> >
> > As per that diff, it seems doxygen is only needed when actually building
> > the documentation:
> >
> >     https://gitlab.freedesktop.org/pipewire/wireplumber/-/commit/2e5b13f970fe3dd28a4ce75868d46403034c6822#0cc1139e3347f573ae1feee5b73dbc8a8a21fcfa
> As written in the commit title, wireplumber "build gobject
> introspection from xml files generated by Doxygen"

Yes, but still, by itself, it does not make sense to do that if
documentation is not built.

I.e.: no doc => no files generated by doxygen => no introspection on
those files.

(but see below).

> >     doxygen_p = find_program('doxygen', required: get_option('doc'))
> 
> Indeed, this is what is done in this commit.
> But the next one (i.e.
> https://gitlab.freedesktop.org/pipewire/wireplumber/-/commit/93c2e7d686ba678991185e711533ce29826b5374)
> adds the following:
> 
> if get_option('doc').enabled() or get_option('introspection').enabled()
>   doxygen_p = find_program('doxygen', version: '>= 1.9.0', required: true)
> elif get_option('doc').auto() or get_option('introspection').auto()
>   doxygen_p = find_program('doxygen', version: '>= 1.9.0', required: false)
> else
>   doxygen_p = disabler()

That commiyt should have also been mentioned, or at least the
following...

> > But we are alredy passing -Ddoc=disabled, so why is it still trying to
> > build the documentation?
> It's not building the "full" documentation (which depends on sphinx,
> etc.), only the file that is needed for gobject-introspection.

... here shjould have been mentioned.

Applied to master with those explanations added, thanks.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot